Merge lp:~gilir/file-roller/fix-lp-705698 into lp:~ubuntu-desktop/file-roller/ubuntu

Proposed by Julien Lavergne
Status: Merged
Merged at revision: 42
Proposed branch: lp:~gilir/file-roller/fix-lp-705698
Merge into: lp:~ubuntu-desktop/file-roller/ubuntu
Diff against target: 85 lines (+64/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/91_zip_command_order.patch (+56/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~gilir/file-roller/fix-lp-705698
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Review via email: mp+49459@code.launchpad.net

This proposal supersedes a proposal from 2011-02-11.

Description of the change

This change fix the previous update, which introduce a regression.
See bug #705698 for detail
Update with upstream fix.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-01-17 23:23:11 +0000
3+++ debian/changelog 2011-02-11 20:34:15 +0000
4@@ -1,3 +1,10 @@
5+file-roller (2.32.1-0ubuntu3) natty; urgency=low
6+
7+ * debian/patches/91_zip_command_order.patch:
8+ - From upstream, correctly set the order of arguments (LP: #705698)
9+
10+ -- Julien Lavergne <gilir@ubuntu.com> Sun, 23 Jan 2011 22:55:45 +0100
11+
12 file-roller (2.32.1-0ubuntu2) natty; urgency=low
13
14 * debian/rules:
15
16=== added file 'debian/patches/91_zip_command_order.patch'
17--- debian/patches/91_zip_command_order.patch 1970-01-01 00:00:00 +0000
18+++ debian/patches/91_zip_command_order.patch 2011-02-11 20:34:15 +0000
19@@ -0,0 +1,56 @@
20+From 28436ba1c76541e29d930c3ee8e29805ac09259c Mon Sep 17 00:00:00 2001
21+From: Paolo Bacchilega <paobac@src.gnome.org>
22+Date: Fri, 11 Feb 2011 19:22:17 +0000
23+Subject: zip: fixed -- position for the extraction command, added for list and test
24+
25+[bug #639664]
26+---
27+diff --git a/src/fr-command-zip.c b/src/fr-command-zip.c
28+index 32c4410..8be5a1b 100644
29+--- a/src/fr-command-zip.c
30++++ b/src/fr-command-zip.c
31+@@ -189,6 +189,7 @@ fr_command_zip_list (FrCommand *comm)
32+ fr_process_begin_command (comm->process, "unzip");
33+ fr_process_set_begin_func (comm->process, list__begin, comm);
34+ fr_process_add_arg (comm->process, "-ZTs");
35++ fr_process_add_arg (comm->process, "--");
36+ fr_process_add_arg (comm->process, comm->filename);
37+ fr_process_end_command (comm->process);
38+ fr_process_start (comm->process);
39+@@ -253,6 +254,7 @@ fr_command_zip_add (FrCommand *comm,
40+
41+ fr_process_add_arg (comm->process, comm->filename);
42+ fr_process_add_arg (comm->process, "--");
43++
44+ for (scan = file_list; scan; scan = scan->next)
45+ fr_process_add_arg (comm->process, scan->data);
46+
47+@@ -276,6 +278,7 @@ fr_command_zip_delete (FrCommand *comm,
48+
49+ fr_process_add_arg (comm->process, comm->filename);
50+ fr_process_add_arg (comm->process, "--");
51++
52+ for (scan = file_list; scan; scan = scan->next) {
53+ char *escaped;
54+
55+@@ -319,8 +322,9 @@ fr_command_zip_extract (FrCommand *comm,
56+ fr_process_add_arg (comm->process, "-j");
57+ add_password_arg (comm, comm->password);
58+
59+- fr_process_add_arg (comm->process, comm->filename);
60+ fr_process_add_arg (comm->process, "--");
61++ fr_process_add_arg (comm->process, comm->filename);
62++
63+ for (scan = file_list; scan; scan = scan->next) {
64+ char *escaped;
65+
66+@@ -339,6 +343,7 @@ fr_command_zip_test (FrCommand *comm)
67+ fr_process_begin_command (comm->process, "unzip");
68+ fr_process_add_arg (comm->process, "-t");
69+ add_password_arg (comm, comm->password);
70++ fr_process_add_arg (comm->process, "--");
71+ fr_process_add_arg (comm->process, comm->filename);
72+ fr_process_end_command (comm->process);
73+ }
74+--
75+cgit v0.8.3.1
76
77=== modified file 'debian/patches/series'
78--- debian/patches/series 2011-01-17 23:23:11 +0000
79+++ debian/patches/series 2011-02-11 20:34:15 +0000
80@@ -2,4 +2,5 @@
81 02_lpi.patch
82 20_am-maintainer-mode.patch
83 90_hyphen_archive_creation.patch
84+91_zip_command_order.patch
85 99_ltmain_as-needed.patch

Subscribers

People subscribed via source and target branches

to all changes: