Code review comment for lp:~gesha/linaro-license-protection/remove-fallback

Revision history for this message
Данило Шеган (danilo) wrote :

In the call to cls.dirEntries, it is unclear what do arguments represent (especially "False"). Python does have one of my favourite features for readability, which is passing arguments by keywords: please use that.

Where you check

         if len(androidpaths) > 0 and len(ubuntupaths) > 0:

you could add an "else" block and get rid of the "else" block in the if below (and replace "elif" simply with "else"): not a big deal, but will move "corner" cases to one if, and actual handling to another.

In tests, I wonder if subdir argument is still needed at all for make_temp_dir?

review: Needs Fixing

« Back to merge proposal