Code review comment for lp:~gesha/linaro-license-protection/non-recursive-search

Revision history for this message
Stevan Radaković (stevanr) wrote :

Hey gesha, this looks good.

One comment though, I don't think we should make flashfirmware non-mandatory so easy.
It should be put under discussion first in the email thread we had, I already told fabo about this.
This effects only android, and it was determined previously that it should have fallback links.
Let's remove it for now, it doesn't have to do anything with the bug were're fixing here.

review: Needs Fixing

« Back to merge proposal