Code review comment for lp:~gesha/linaro-license-protection/build-info-doc

Revision history for this message
Deepti B. Kalakeri (deeptik) wrote :

Hello Gesha,

Changes looks fine. Just few typos:

18 +Build-Name: landing-snowball
19 + Would be a unique over all the builds of the same type. For now used as

>> Should be instead "Would be unique over all the builds of the same type. For now used as"

29 +OpenID-Launchpad-Teams: linaro
30 + LP team names members of are allowed to access protected files. No OpenID

>> Should be instead "LP team names, members of which are allowed to access protected files. No OpenID"

33 + Default to 'no' if not present. If the field is set to 'yes' then

>> Should be instead "Defaults to 'no' if not present. If the field is set to 'yes' then"

46 +If no BUILD-INFO,txt is found it falls back to per-file/per-directoryEULA

>> BUILD-INFO,txt should be instead BUILD-INFO.txt include dot instead comma. And "per-file/per-directoryEULA" should be "per-file/per-directory EULA " (missing space befor EULA)

38 +
39 +- If line begins with space character ' ' it is treated as a part of last found
40 +variable which turns as multiline variable and is appended to it.
41 +- Variable names are case insensitive.

Are the line 38 - 41 belong to the description of License-Text: EULA full text included in BUILD-INFO.txt?? If yes then we should remove the blank line present at line 38

Also, line 24 - 28 are not aligned properly when compared to other lines.

review: Needs Fixing

« Back to merge proposal