Code review comment for lp:~gesha/linaro-license-protection/add-multiple-sites-support

Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Looks fine.

Since we have multiple settings and wsgi files it would be possible to use a separate database for each site and remove the site_id requirement. The databases build themselves up as they go, so unless the OpenID code stores data in them, we can just delete the existing database at a later date and start fresh.

Currently the set up uses sqlite3, which is fine for development but not for deployment, but I assume you and the sys-admins know that and will use a more traditional database when live!

review: Approve

« Back to merge proposal