Merge lp:~gesha/linaro-license-protection/1218356 into lp:~linaro-automation/linaro-license-protection/trunk
Proposed by
Georgy Redkozubov
Status: | Merged |
---|---|
Approved by: | Milo Casagrande |
Approved revision: | 217 |
Merged at revision: | 216 |
Proposed branch: | lp:~gesha/linaro-license-protection/1218356 |
Merge into: | lp:~linaro-automation/linaro-license-protection/trunk |
Diff against target: |
80 lines (+34/-3) 2 files modified
license_protected_downloads/views.py (+32/-3) settings.py (+2/-0) |
To merge this branch: | bzr merge lp:~gesha/linaro-license-protection/1218356 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Milo Casagrande (community) | Approve | ||
Review via email: mp+186059@code.launchpad.net |
Description of the change
This branch adds git description tab on snapshots/releases with projects information from annotated source manifest.
To post a comment you must log in.
Hey Georgy,
thanks for working on this.
It looks good to go, the only comment I have is here:
+ for i, n in enumerate(nodes): getAttribute( 'name') , data.strip( ))
+ if n.nodeType == n.COMMENT_NODE:
+ comment = nodes[i]
+ commentedNode = nodes[i + 2]
+ text += line % (commentedNode.
+ comment.
+
Can you give more meaningful name to "i" and "n"? "index" and "node" should be fine I guess.
In case, please do when merging.
Thanks.