Code review comment for lp:~gesha/linaro-license-protection/1146220

Revision history for this message
Stevan Radaković (stevanr) wrote :

Nice work gesha, thanks!

Only thing I dislike here is having return values(PASS, FAIL) in the method instead of using the exceptions as this is a very good example on when they should be used. That way you don't need to return anything at all, just catch exception if the method throws it. Tests would need to go through a little change as well because of it.

review: Needs Fixing (code)

« Back to merge proposal