Merge lp:~gesha/linaro-android-frontend/hide-howtos into lp:linaro-android-frontend

[Georgy Redkozubov]

This branch adds possibility to hide files from the Downloads list on the build details page.
Files to be hidden are described by patterns array. All files are checked during generation of the Downloads list against this patterns array and skipped if are found there.

[Stevan Radaković (stevanr)]

Hey Georgy, great work.

One comment about the patternInName function though, IMO the description of this function should be more like patternInName(name, list) to increase its re-usability and also it's a good practice to reduce the references to global variables as much as possible (yes, even in JS:)

review: Needs Fixing

[lp:~gesha/linaro-android-frontend/hide-howtos]

316. By Georgy Redkozubov on 2013-06-24

Made patternInName function reusable.

[Georgy Redkozubov (gesha)]

Thanks for comments. Fixed both.

[Stevan Radaković (stevanr)]

Thanks!
Approve +1.

review: Approve

=== modified file 'static/buildDetails.js'
--- static/buildDetails.js	2013-02-19 14:48:32 +0000
+++ static/buildDetails.js	2013-06-24 11:52:25 +0000
@@ -33,6 +33,18 @@
     }
     var jobUrl = globalConfig.jenkinsURL + "/job/" + buildName;
 
+    function patternInName (name, list) {
+      // Check for patterns from 'list' in 'name'.
+      // If found returns 'true' otherwise 'false'.
+      for (var i = 0; i < list.length; i++) {
+        if (name.indexOf(list[i])>=0)
+        {
+          return true;
+        }
+      }
+      return false;
+    }
+
     function receivedTestResultJSON (response, loadingNode) {
         var columns = [
             {label:"Name", formatter: function (o) {
@@ -252,6 +264,7 @@
         var downloadUrl = 'http://snapshots.linaro.org/android/' + rawBuildName + '/' + results.number.toString() + '/';
           handleRenderedFiles('android/' + rawBuildName + '/' +
                               results.number.toString());
+        var hiddenFilesPatterns = ['HOWTO_', 'BUILD-INFO', 'EULA', 'textile'];
 
 
         Y.one('#all-output a').setAttribute('href', downloadUrl);
@@ -286,7 +299,7 @@
 
           for (var i = 0; i < manifest.length; i++)
           {
-            if (!manifest[i].match(/\S/))
+            if (!manifest[i].match(/\S/) || patternInName(manifest[i], hiddenFilesPatterns))
             {
               continue;
             }
@@ -302,6 +315,10 @@
           var listNode = Y.Node.create('<ul/>');
           for (var i = 0; i < results.artifacts.length; i++) {
             var artifact = results.artifacts[i];
+            if (patternInName(artifact, hiddenFilesPatterns))
+            {
+              continue;
+            }
             var itemNode = Y.Node.create('<li><a/></li>');
             itemNode.one('a').setContent(artifact.displayPath);
             // Strip static '/build/out' from relativePath