Code review comment for lp:~gesha/linaro-android-frontend/add-toolchain-tab

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Categorization logic starts to look really complicated. It may also starting to be a performance penalty to re-evaluate all those boolean functions for each item, might be better idea to just have single functions which analyzes items and return category where it should go. Those are mostly comments for any future work, looks good for what it is now.

review: Approve

« Back to merge proposal