Merge lp:~gero-bare/switchboard/fix-regression-yet-again into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Gero.Bare
Status: Merged
Approved by: Corentin Noël
Approved revision: 614
Merged at revision: 614
Proposed branch: lp:~gero-bare/switchboard/fix-regression-yet-again
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 34 lines (+6/-11)
1 file modified
src/Switchboard.vala (+6/-11)
To merge this branch: bzr merge lp:~gero-bare/switchboard/fix-regression-yet-again
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+291907@code.launchpad.net

Commit message

Use only one Idle to show the plug

Description of the change

Fix missing widgets in parental control. Bug introduced in r612.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Switchboard.vala'
--- src/Switchboard.vala 2016-04-11 19:58:54 +0000
+++ src/Switchboard.vala 2016-04-14 15:15:36 +0000
@@ -176,6 +176,12 @@
176 }176 }
177177
178 public void load_plug (Switchboard.Plug plug) {178 public void load_plug (Switchboard.Plug plug) {
179 //FIXME lower priority for gcc plugs due crash bug #1528361
180 var priority = GLib.Priority.DEFAULT_IDLE;
181 if (plug.code_name.contains ("-gcc-")) {
182 priority = GLib.Priority.LOW;
183 }
184
179 Idle.add (() => {185 Idle.add (() => {
180 if (!loaded_plugs.contains (plug.code_name)) {186 if (!loaded_plugs.contains (plug.code_name)) {
181 stack.add_named (plug.get_widget (), plug.code_name);187 stack.add_named (plug.get_widget (), plug.code_name);
@@ -197,17 +203,6 @@
197 });203 });
198204
199 previous_plugs.add (plug);205 previous_plugs.add (plug);
200 return false;
201 });
202
203
204 //FIXME lower priority for gcc plugs due crash bug #1528361
205 var priority = GLib.Priority.DEFAULT_IDLE;
206 if (plug.code_name.contains ("-gcc-")) {
207 priority = GLib.Priority.LOW;
208 }
209
210 Idle.add (()=> {
211 // Launch plug's executable206 // Launch plug's executable
212 navigation_button.set_sensitive (true);207 navigation_button.set_sensitive (true);
213 navigation_button.set_text (all_settings_label);208 navigation_button.set_text (all_settings_label);

Subscribers

People subscribed via source and target branches

to all changes: