Merge lp:~gero-bare/switchboard/fix-regression-yet-again into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Gero.Bare
Status: Merged
Approved by: Corentin Noël
Approved revision: 614
Merged at revision: 614
Proposed branch: lp:~gero-bare/switchboard/fix-regression-yet-again
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 34 lines (+6/-11)
1 file modified
src/Switchboard.vala (+6/-11)
To merge this branch: bzr merge lp:~gero-bare/switchboard/fix-regression-yet-again
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+291907@code.launchpad.net

Commit message

Use only one Idle to show the plug

Description of the change

Fix missing widgets in parental control. Bug introduced in r612.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Switchboard.vala'
2--- src/Switchboard.vala 2016-04-11 19:58:54 +0000
3+++ src/Switchboard.vala 2016-04-14 15:15:36 +0000
4@@ -176,6 +176,12 @@
5 }
6
7 public void load_plug (Switchboard.Plug plug) {
8+ //FIXME lower priority for gcc plugs due crash bug #1528361
9+ var priority = GLib.Priority.DEFAULT_IDLE;
10+ if (plug.code_name.contains ("-gcc-")) {
11+ priority = GLib.Priority.LOW;
12+ }
13+
14 Idle.add (() => {
15 if (!loaded_plugs.contains (plug.code_name)) {
16 stack.add_named (plug.get_widget (), plug.code_name);
17@@ -197,17 +203,6 @@
18 });
19
20 previous_plugs.add (plug);
21- return false;
22- });
23-
24-
25- //FIXME lower priority for gcc plugs due crash bug #1528361
26- var priority = GLib.Priority.DEFAULT_IDLE;
27- if (plug.code_name.contains ("-gcc-")) {
28- priority = GLib.Priority.LOW;
29- }
30-
31- Idle.add (()=> {
32 // Launch plug's executable
33 navigation_button.set_sensitive (true);
34 navigation_button.set_text (all_settings_label);

Subscribers

People subscribed via source and target branches

to all changes: