Code review comment for lp:~gero-bare/scratch/add-linter-support

Revision history for this message
Zisu Andrei (matzipan) wrote :

Ok so I installed it. First of all, I think it should use another icon. Secondly, if I don't have any tabs open, if I click on the icon, I get:

[DEBUG 22:11:33.500717] LinterManagerPlugin.vala:202: Linter Hook on notebook bottom
[FATAL 22:11:35.684459] scratch_services_document_get_is_file_temporary: assertion 'self != NULL' failed
Segmentation fault (core dumped)

Also the configuration window could use a bit of visual improvement. Would it be possible to add it to Scratch's preferences dialog?

Also, maybe there should be an option to run lint on save?

review: Needs Fixing

« Back to merge proposal