Merge lp:~gero-bare/midori/midori-small-fixes into lp:~midori/midori/webkit2gtk4abiBreak

Proposed by Gero.Bare
Status: Merged
Merged at revision: 6940
Proposed branch: lp:~gero-bare/midori/midori-small-fixes
Merge into: lp:~midori/midori/webkit2gtk4abiBreak
Diff against target: 41 lines (+3/-3)
3 files modified
midori/midori-browser.c (+1/-1)
midori/midori-privatedata.c (+1/-1)
midori/midori-view.c (+1/-1)
To merge this branch: bzr merge lp:~gero-bare/midori/midori-small-fixes
Reviewer Review Type Date Requested Status
Cris Dywan Pending
Review via email: mp+256876@code.launchpad.net

Description of the change

My compiler (both clang 3.6 and gcc 4.9 in Arch Linux) is bitching about some small errors.
This should address that.
Thanks for your branch man.

To post a comment you must log in.
6940. By Gero.Bare

Fix blank line.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'midori/midori-browser.c'
--- midori/midori-browser.c 2015-04-21 00:54:44 +0000
+++ midori/midori-browser.c 2015-04-21 02:08:13 +0000
@@ -3637,10 +3637,10 @@
3637 MidoriBrowser* browser,3637 MidoriBrowser* browser,
3638 gboolean use_dom)3638 gboolean use_dom)
3639{3639{
3640 GtkWidget* view = midori_browser_get_current_tab (browser);
3641 #ifdef HAVE_WEBKIT23640 #ifdef HAVE_WEBKIT2
3642 /* TODO: midori_view_save_source isn't async and not WebKit2-friendly */3641 /* TODO: midori_view_save_source isn't async and not WebKit2-friendly */
3643 #else3642 #else
3643 GtkWidget* view = midori_browser_get_current_tab (browser);
3644 gchar* filename = midori_view_save_source (MIDORI_VIEW (view), NULL, NULL, use_dom);3644 gchar* filename = midori_view_save_source (MIDORI_VIEW (view), NULL, NULL, use_dom);
3645 gchar* text_editor;3645 gchar* text_editor;
3646 GFileInfo* info;3646 GFileInfo* info;
36473647
=== modified file 'midori/midori-privatedata.c'
--- midori/midori-privatedata.c 2015-04-16 01:47:45 +0000
+++ midori/midori-privatedata.c 2015-04-21 02:08:13 +0000
@@ -119,7 +119,7 @@
119 {119 {
120 MidoriPrivateDataItem* privacy = data_items->data;120 MidoriPrivateDataItem* privacy = data_items->data;
121 button = g_object_get_data (G_OBJECT (dialog), privacy->name);121 button = g_object_get_data (G_OBJECT (dialog), privacy->name);
122 g_return_if_fail (button != NULL && GTK_IS_TOGGLE_BUTTON (button));122 g_return_val_if_fail (button != NULL && GTK_IS_TOGGLE_BUTTON (button), false);
123 if (gtk_toggle_button_get_active (button))123 if (gtk_toggle_button_get_active (button))
124 count++;124 count++;
125 }125 }
126126
=== modified file 'midori/midori-view.c'
--- midori/midori-view.c 2015-04-21 00:54:44 +0000
+++ midori/midori-view.c 2015-04-21 02:08:13 +0000
@@ -4545,7 +4545,7 @@
4545 GFile *file;4545 GFile *file;
4546 char *converted = NULL;4546 char *converted = NULL;
4547 WebKitWebView * web_view = WEBKIT_WEB_VIEW (view->web_view);4547 WebKitWebView * web_view = WEBKIT_WEB_VIEW (view->web_view);
4548 g_return_if_fail (uri);4548 g_return_val_if_fail (uri,NULL);
45494549
4550 if (!outfile)4550 if (!outfile)
4551 converted = g_filename_to_utf8 (uri, -1, NULL, NULL, NULL);4551 converted = g_filename_to_utf8 (uri, -1, NULL, NULL, NULL);

Subscribers

People subscribed via source and target branches

to all changes: