Code review comment for lp:~gerlowskija/music-app/repeat_button_autopilot_tests

Revision history for this message
Jason (gerlowskija) wrote :

It's no problem, they were things I should have caught anyway. Are pep8 and pyflakes run on all the core app builds (just for future reference)? Are there any other checks I should be doing before I push a branch?

> Sorry Jason, pyflakes is another coding standard type program and it has
> complained about the following:
>
> + pyflakes .
> ./tests/autopilot/music_app/tests/test_music.py:12: 'sys' imported but unused
> ./tests/autopilot/music_app/tests/test_music.py:217: local variable
> 'shufflebutton' is assigned to but never used
> ./debian/tmp/usr/lib/python2.7/dist-packages/music_app/tests/test_music.py:12:
> 'sys' imported but unused
> ./debian/tmp/usr/lib/python2.7/dist-
> packages/music_app/tests/test_music.py:217: local variable 'shufflebutton' is
> assigned to but never used
> ./debian/music-app-autopilot/usr/lib/python2.7/dist-
> packages/music_app/tests/test_music.py:12: 'sys' imported but unused
> ./debian/music-app-autopilot/usr/lib/python2.7/dist-
> packages/music_app/tests/test_music.py:217: local variable 'shufflebutton' is
> assigned to but never used
>
> I think you need to delete the two lines of code it points out.

« Back to merge proposal