Code review comment for lp:~gerlowskija/music-app/repeat_button_autopilot_tests

Revision history for this message
Jason (gerlowskija) wrote :

Ok, sounds easy enough. Just as a process question, should I make those changes as their own commit/revision, or is there a way to edit the branch I've already pushed to contain those changes in the original commit itself?

> Jason,
>
> There are a few things that need fixing. Pep8 is a program that checks python
> coding standards. You can check this by installing 'pep8' and running it
> against the python source like so:
>
> $ pep8 tests/autopilot/music_app/tests/test_music.py
>
> tests/autopilot/music_app/tests/test_music.py:40:80: E501 line too long (83 >
> 79 characters)
> tests/autopilot/music_app/tests/test_music.py:621:80: E501 line too long (80 >
> 79 characters)
> tests/autopilot/music_app/tests/test_music.py:654:80: E501 line too long (80 >
> 79 characters)
>
> Here's what the Jenkins CI infrastructure sees as the issue:
>
> + pep8 --repeat --show-source .
> ./tests/autopilot/music_app/tests/test_music.py:40:80: E501 line too long (83
> > 79 characters)
> song =
> self.main_view.get_album_sheet_listview_tracktitle(self.FIRST_TITLE)
> ^
> ./tests/autopilot/music_app/tests/test_music.py:621:80: E501 line too long (80
> > 79 characters)
> """With repeat on, the first song should play after the last one
> ends"""
> ^
> ./tests/autopilot/music_app/tests/test_music.py:654:80: E501 line too long (80
> > 79 characters)
> """With repeat on, 'previous' from the first song plays the last
> one."""
> ^
> ./debian/tmp/usr/lib/python2.7/dist-
> packages/music_app/tests/test_music.py:40:80: E501 line too long (83 > 79
> characters)
> song =
> self.main_view.get_album_sheet_listview_tracktitle(self.FIRST_TITLE)
> ^
> ./debian/tmp/usr/lib/python2.7/dist-
> packages/music_app/tests/test_music.py:621:80: E501 line too long (80 > 79
> characters)
> """With repeat on, the first song should play after the last one
> ends"""
> ^
> ./debian/tmp/usr/lib/python2.7/dist-
> packages/music_app/tests/test_music.py:654:80: E501 line too long (80 > 79
> characters)
> """With repeat on, 'previous' from the first song plays the last
> one."""
> ^
> ./debian/music-app-autopilot/usr/lib/python2.7/dist-
> packages/music_app/tests/test_music.py:40:80: E501 line too long (83 > 79
> characters)
> song =
> self.main_view.get_album_sheet_listview_tracktitle(self.FIRST_TITLE)
> ^
> ./debian/music-app-autopilot/usr/lib/python2.7/dist-
> packages/music_app/tests/test_music.py:621:80: E501 line too long (80 > 79
> characters)
> """With repeat on, the first song should play after the last one
> ends"""
> ^
> ./debian/music-app-autopilot/usr/lib/python2.7/dist-
> packages/music_app/tests/test_music.py:654:80: E501 line too long (80 > 79
> characters)
> """With repeat on, 'previous' from the first song plays the last
> one."""

« Back to merge proposal