Oh I see. I didn't make a utility to turn shuffle on, since in the tests I
added I just needed to turn it off. But it makes sense to add a function
for it, and add it in. Good catch! I'll push up a revised change in a bit.
On Thu, Apr 10, 2014 at 10:11 PM, Victor Thompson <<email address hidden>
> wrote:
> See around L290:
>
> #ensure shuffle is on
> if not self.player.shuffle:
> logger.debug("Turning on shuffle")
> self.pointing_device.click_object(shufflebutton)
> else:
> logger.debug("Shuffle already on")
> self.assertThat(self.player.shuffle, Eventually(Equals(True)))
>
>
> Or just search for "shufflebutton". In the same regard, you can delete
> L255 (but this was a pointless line of code before your changes--so feel
> free to disregard this suggestion):
>
> shufflebutton = self.main_view.get_shuffle_button()
>
>
> --
>
> https://code.launchpad.net/~gerlowskija/music-app/repeat_button_autopilot_tests/+merge/214870
> You are the owner of
> lp:~gerlowskija/music-app/repeat_button_autopilot_tests.
>
Oh I see. I didn't make a utility to turn shuffle on, since in the tests I
added I just needed to turn it off. But it makes sense to add a function
for it, and add it in. Good catch! I'll push up a revised change in a bit.
On Thu, Apr 10, 2014 at 10:11 PM, Victor Thompson <<email address hidden>
> wrote:
> See around L290: shuffle: debug(" Turning on shuffle") device. click_object( shufflebutton) debug(" Shuffle already on") (self.player. shuffle, Eventually( Equals( True))) view.get_ shuffle_ button( ) /code.launchpad .net/~gerlowski ja/music- app/repeat_ button_ autopilot_ tests/+ merge/214870
>
> #ensure shuffle is on
> if not self.player.
> logger.
> self.pointing_
> else:
> logger.
> self.assertThat
>
>
> Or just search for "shufflebutton". In the same regard, you can delete
> L255 (but this was a pointless line of code before your changes--so feel
> free to disregard this suggestion):
>
> shufflebutton = self.main_
>
>
> --
>
> https:/
> You are the owner of
> lp:~gerlowskija/music-app/repeat_button_autopilot_tests.
>