Code review comment for lp:~gerboland/unity8/orientationLock

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Thumbs up.

--------------------

"""
tryCompare(rootSessionContainer, "orientation", childSessionContainer.orientation);
"""

Nitpick:
You should swap rootSessionContainer with childSessionContainer, as the last parameter is the expected value.
Ie, you expect childSessionContainer.orientation (the property whose value should change) to eventually be rootSessionContainer.orientation (the value that you've manually set), not the other way round.

review: Approve

« Back to merge proposal