Code review comment for lp:~gerboland/unity-api/appManVersion2

Revision history for this message
Michael Zanetti (mzanetti) wrote :

The stages and State enums are not tested. Can you please add a test that checks for all the values, but also that Stages are flags and can be used as such in QML?

===

Now that Stages are flags, we need to define their values explicitly in the enum definition. Now we have 0 and 1. ORing them loses information about 0.

===

Otherwise I think we're good now in terms of the API itself.

review: Needs Fixing

« Back to merge proposal