Code review comment for lp:~gerboland/unity-2d/unity-core5-change-fix

Revision history for this message
Michal Hruby (mhr3) wrote :

1) Please don't ignore setting HOME_VIEW on lenses, they might not update properly if it's not set. (setting it on all lenses is fine as well).

2) It would also be nice to make sure the viewtype is set to HIDDEN when the dash is closed (optional as this point though).

3) The plain dbus call probably shouldn't be there :)

review: Needs Fixing

« Back to merge proposal