Code review comment for lp:~gerboland/unity-2d/launcher-tweaks

Revision history for this message
Albert Astals Cid (aacid) wrote :

In
 anchors.rightMargin: declarativeView.dashActive ? 0 : 1
should that 1 be border.width?

I find it confusing to have one Item Accessible.name: "borderWithDash" and id: border and then a different Item with Accessible.name: "border" and no id, woulnd't it be better to name the second one "borderWithoutDash" and not change the first one?

In the second "border" i think it'd be better if you bind all the other properties to the "first" border, so if something changes we just need to change one, i.e.

anchors.right: border.anchors.right
anchors.left: border.anchors.left
visible: !border.visible

« Back to merge proposal