The code looks good and clean, and it fixes the unit test that was hanging.
I have a tiny remark style-wise, which you may safely ignore if you feel like it: the x11FileDescriptor variable is referred to only once, so you can remove it and invoke directly ConnectionNumber(m_display) when instantiating the QSocketNotifier. Other than that, it all looks perfect to me.
As to bug #859596 I can’t really tell whether that fixes it, but it should considering comment #8.
The code looks good and clean, and it fixes the unit test that was hanging.
I have a tiny remark style-wise, which you may safely ignore if you feel like it: the x11FileDescriptor variable is referred to only once, so you can remove it and invoke directly ConnectionNumbe r(m_display) when instantiating the QSocketNotifier. Other than that, it all looks perfect to me.
As to bug #859596 I can’t really tell whether that fixes it, but it should considering comment #8.