Code review comment for lp:~gerboland/unity-2d/dash-lenses

Revision history for this message
Florian Boucault (fboucault) wrote :

In places/LensButton.qml:

    Image {
        id: indicator
        width: 5
        height: 9

maybe use sourceSize.width and sourceSize.height instead if it works?

[...]

        y: 37
        anchors.horizontalCenter: parent.horizontalCenter

Setting it centered horizontally conflicts with hardcoding its y coordinate.

review: Needs Fixing

« Back to merge proposal