Code review comment for lp:~gerboland/qtubuntu/exposeOrientation

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

In src/ubuntumirclient/screen.cpp:

"""
- case QOrientationReading::LeftUp: {
+ case QOrientationReading::RightUp: {
             mCurrentOrientation = (mNativeOrientation == Qt::LandscapeOrientation) ?
- Qt::InvertedPortraitOrientation : Qt::LandscapeOrientation;
+ Qt::InvertedPortraitOrientation : Qt::InvertedLandscapeOrientation;
"""

This is wrong. The original code had the correct conversion.

"""
- case QOrientationReading::RightUp: {
+ case QOrientationReading::LeftUp: {
             mCurrentOrientation = (mNativeOrientation == Qt::LandscapeOrientation) ?
- Qt::PortraitOrientation : Qt::InvertedLandscapeOrientation;
+ Qt::PortraitOrientation : Qt::LandscapeOrientation;
"""

Same here.

See https://www.dropbox.com/s/4ctoecuq4269j5m/QtScreenOrientation.png?dl=0

review: Needs Fixing

« Back to merge proposal