Code review comment for lp:~gerboland/qtubuntu/exposeOrientation

> Then please use the same nomenclature that the mir event uses in that internal
> OrientationChangeEvent, thus avoiding mentioning landscape or portrait at this
> point, which is misleading. You could stick with the
> QOrientationReading::Orientation enum.

Can you explain your reasoning why this is misleading? We need to convert from Mir event nomenclature (normal,left,right,inverted) to QScreenOrientation (portrait, landscape, invertedlandscape, invertedportrait) somewhere, it struck me as a good idea to convert to Qt's definition as quickly as possible.

Do I understand you want me to add an intermediary 3rd nomenclature, the QOrientationReading::Orientation. So then we have Mir->QOrientationReading->QScreenOrientation ?