Merge lp:~gerboland/qtubuntu/disable-gles3-for-now into lp:qtubuntu

Proposed by Michał Sawicz
Status: Merged
Merged at revision: 335
Proposed branch: lp:~gerboland/qtubuntu/disable-gles3-for-now
Merge into: lp:qtubuntu
Diff against target: 33 lines (+12/-0)
2 files modified
src/ubuntumirclient/glcontext.cpp (+10/-0)
src/ubuntumirclient/glcontext.h (+2/-0)
To merge this branch: bzr merge lp:~gerboland/qtubuntu/disable-gles3-for-now
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+297902@code.launchpad.net

Commit message

Disable GLESv3 for now

LP#1490956
LP#1594198

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:327
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/83/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2075
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2103
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2014
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2014
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2014
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2005/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/83/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/ubuntumirclient/glcontext.cpp'
--- src/ubuntumirclient/glcontext.cpp 2016-06-03 09:55:43 +0000
+++ src/ubuntumirclient/glcontext.cpp 2016-06-20 12:13:03 +0000
@@ -95,6 +95,16 @@
95 }95 }
96}96}
9797
98// WORKAROUND for bug 1594198 - avoid having Qt use GLESv3
99QSurfaceFormat UbuntuOpenGLContext::format() const
100{
101 auto format = QEGLPlatformContext::format();
102 if (format.renderableType() == QSurfaceFormat::OpenGLES && format.majorVersion() > 2) {
103 format.setMajorVersion(2);
104 }
105 return format;
106}
107
98// Following method used internally in the base class QEGLPlatformContext to access108// Following method used internally in the base class QEGLPlatformContext to access
99// the egl surface of a QPlatformSurface/UbuntuWindow109// the egl surface of a QPlatformSurface/UbuntuWindow
100EGLSurface UbuntuOpenGLContext::eglSurfaceForPlatformSurface(QPlatformSurface *surface)110EGLSurface UbuntuOpenGLContext::eglSurfaceForPlatformSurface(QPlatformSurface *surface)
101111
=== modified file 'src/ubuntumirclient/glcontext.h'
--- src/ubuntumirclient/glcontext.h 2016-05-19 16:26:30 +0000
+++ src/ubuntumirclient/glcontext.h 2016-06-20 12:13:03 +0000
@@ -32,6 +32,8 @@
32 void swapBuffers(QPlatformSurface *surface) final;32 void swapBuffers(QPlatformSurface *surface) final;
33 bool makeCurrent(QPlatformSurface *surface) final;33 bool makeCurrent(QPlatformSurface *surface) final;
3434
35 QSurfaceFormat format() const final;
36
35protected:37protected:
36 EGLSurface eglSurfaceForPlatformSurface(QPlatformSurface *surface) final;38 EGLSurface eglSurfaceForPlatformSurface(QPlatformSurface *surface) final;
37};39};

Subscribers

People subscribed via source and target branches