Merge lp:~gerboland/qtubuntu/disable-gles3-for-now into lp:qtubuntu

Proposed by Michał Sawicz
Status: Merged
Merged at revision: 335
Proposed branch: lp:~gerboland/qtubuntu/disable-gles3-for-now
Merge into: lp:qtubuntu
Diff against target: 33 lines (+12/-0)
2 files modified
src/ubuntumirclient/glcontext.cpp (+10/-0)
src/ubuntumirclient/glcontext.h (+2/-0)
To merge this branch: bzr merge lp:~gerboland/qtubuntu/disable-gles3-for-now
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+297902@code.launchpad.net

Commit message

Disable GLESv3 for now

LP#1490956
LP#1594198

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:327
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/83/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2075
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2103
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2014
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2014
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2014
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2005/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2005
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2005/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/83/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntumirclient/glcontext.cpp'
2--- src/ubuntumirclient/glcontext.cpp 2016-06-03 09:55:43 +0000
3+++ src/ubuntumirclient/glcontext.cpp 2016-06-20 12:13:03 +0000
4@@ -95,6 +95,16 @@
5 }
6 }
7
8+// WORKAROUND for bug 1594198 - avoid having Qt use GLESv3
9+QSurfaceFormat UbuntuOpenGLContext::format() const
10+{
11+ auto format = QEGLPlatformContext::format();
12+ if (format.renderableType() == QSurfaceFormat::OpenGLES && format.majorVersion() > 2) {
13+ format.setMajorVersion(2);
14+ }
15+ return format;
16+}
17+
18 // Following method used internally in the base class QEGLPlatformContext to access
19 // the egl surface of a QPlatformSurface/UbuntuWindow
20 EGLSurface UbuntuOpenGLContext::eglSurfaceForPlatformSurface(QPlatformSurface *surface)
21
22=== modified file 'src/ubuntumirclient/glcontext.h'
23--- src/ubuntumirclient/glcontext.h 2016-05-19 16:26:30 +0000
24+++ src/ubuntumirclient/glcontext.h 2016-06-20 12:13:03 +0000
25@@ -32,6 +32,8 @@
26 void swapBuffers(QPlatformSurface *surface) final;
27 bool makeCurrent(QPlatformSurface *surface) final;
28
29+ QSurfaceFormat format() const final;
30+
31 protected:
32 EGLSurface eglSurfaceForPlatformSurface(QPlatformSurface *surface) final;
33 };

Subscribers

People subscribed via source and target branches