Merge lp:~gerboland/qtmir/url-dispatcher-respawns-so-appMan-should-not into lp:qtmir
Status: | Rejected |
---|---|
Rejected by: | Gerry Boland |
Proposed branch: | lp:~gerboland/qtmir/url-dispatcher-respawns-so-appMan-should-not |
Merge into: | lp:qtmir |
Diff against target: |
73 lines (+36/-4) 2 files modified
src/modules/Unity/Application/application_manager.cpp (+13/-4) tests/modules/ApplicationManager/application_manager_test.cpp (+23/-0) |
To merge this branch: | bzr merge lp:~gerboland/qtmir/url-dispatcher-respawns-so-appMan-should-not |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mir development team | Pending | ||
Review via email: mp+238319@code.launchpad.net |
Commit message
AppMan: url-dispatcher launches focusRequested apps itself, so ensure AppMan sets the app state appropriately
Let app1 be lifecycle killed, but still in the app list. app2 uses url-dispatcher to focus app1. This causes url-dispatcher to launch a new instance of app1, and then notify AppMan to request focus for app1.
However it is possible if shell acted upon the requestFocus signal, and called focusApplicatio
Description of the change
AppMan: url-dispatcher launches focusRequested apps itself, so ensure AppMan sets the app state appropriately
Let app1 be lifecycle killed, but still in the app list. app2 uses url-dispatcher to focus app1. This causes url-dispatcher to launch a new instance of app1, and then notify AppMan to request focus for app1.
However it is possible if shell acted upon the requestFocus signal, and called focusApplicatio
Unmerged revisions
- 277. By Gerry Boland
-
Remove unnecessary include
- 276. By Gerry Boland
-
Merge trunk
- 275. By Gerry Boland
-
Update comments to explain new situation
- 274. By Gerry Boland
-
AppMan: url-dispatcher launches focusRequested apps itself, so ensure AppMan sets the app state appropriately
Let app1 be lifecycle killed, but still in the app list. app2 uses url-dispatcher to focus app1. This causes url-dispatcher to launch a new instance of app1, and then notify AppMan to request focus for app1.
However it is possible if shell acted upon the requestFocus signal, and called focusApplicatio
n(app1) - before the onProcessStarti ng(app1) notification from upstart was received, AppMan would respawn app1 itself. So 2 instances of app1 would be executing, and later AppMan would then reject one of them.