> in src/platforms/mirserver/qmirserver.cpp:
>
> """
> connect(d->serverWorker, &MirServerWorker::stopped, this,
> &QMirServer::serverStopped, Qt::DirectConnection);
> """
>
> I think this line deserves a comment explaining why this has to be a direct
> connection, which will cause QMirServer::serverStopped to be called from
> within MirServerWorker's thread.
>
> trunk has a terse comment about it.
Fair point. The line above it also creates a direct connection, and that line has a comment pointing to the explanation. But yeah, that connection is easily missed, will fix
> in src/platforms/ mirserver/ qmirserver. cpp: d->serverWorker , &MirServerWorke r::stopped, this, :serverStopped, Qt::DirectConne ction); :serverStopped to be called from
>
> """
> connect(
> &QMirServer:
> """
>
> I think this line deserves a comment explaining why this has to be a direct
> connection, which will cause QMirServer:
> within MirServerWorker's thread.
>
> trunk has a terse comment about it.
Fair point. The line above it also creates a direct connection, and that line has a comment pointing to the explanation. But yeah, that connection is easily missed, will fix