Code review comment for lp:~gerboland/qtmir/qmirserver-hides-mirserver

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

In src/platforms/mirserver/qmirserver.h:

"""
    Q_SLOT void serverStopped();
"""

Are you sure you want this slot in the public API?

And, by the way, it's named like a signal. It should be onServerStopped() or, even better, quit().

« Back to merge proposal