Code review comment for lp:~gerboland/qtmir/multimonitor

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Code looks ok.

Tested on a N7 with unity8 and it works. Connecting an external monitor shows the cloned image there (albeit cut off) and disconnecting it doesn't crash unity8.

qml-demo-shell on the N7 freezes. Don't know if it's related to this MP.

Also could not test on my laptop as its flimsy micro-HDMI port seems to be broken, or preferably, my "HDMI to micro-HDMI" adaptor. :(

review: Approve

« Back to merge proposal