Code review comment for lp:~gerboland/qtmir/desktopFileReader

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Please silence logging in the test to avoid polluting the results like this:

"""
[ RUN ] DesktopFileReader.testMissingDesktopFile
qtmir.applications: DesktopFileReader::DesktopFileReader - this= 0x1b09b30 appId= "calculator"
Desktop file for appId: "calculator" at: "/home/dandrader/qtmir/desktopFileReader_build/tests/modules/DesktopFileReader/missing.desktop" does not exist, or is not valid
[ OK ] DesktopFileReader.testMissingDesktopFile (0 ms)
"""

I plan to do it for all tests at some point but it would be good to do it already for new tests.

« Back to merge proposal