Code review comment for lp:~gerboland/miral/no-unsigned-int-index

Revision history for this message
Gerry Boland (gerboland) wrote :

> + void windowAdded(const qtmir::WindowInfo, const int index);
>
> You do know that top level const is meaningless in [member] function
> declarations?

Yeah, I do. It is a habit, I tend to use const as much as possible, as even if the compiler cannot use it, it might hint to developer how api is intended to be used. How useful that actually is, I cannot say. Welcome to remove them if they annoy you.

« Back to merge proposal