Code review comment for lp:~gerboland/miral/add-interactivity-to-WM

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

On balance I think it better to land this "wiring" than to try to perfect it first.

~~~~

+#include "miral/window_info.h"

Once MirAL supports everything we need we intend to separate the Qt use of MirAL from the project. So I'd be inclined to use <> includes for miral headers.

~~~~

I see this a few times: "static_cast<std::shared_ptr<mir::scene::Surface>>(m_windowInfo.window);" but I don't see why you use the cast operator. Ideally we don't want Qt to use mir::xxx::Yyy, so is this just a tag to review later?

review: Approve

« Back to merge proposal