Code review comment for lp:~gerboland/miral/add-interactivity-to-WM

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

/home/alan/display_server/miral/miral-qt/tests/modules/Application/application_test.cpp:287:35: error: allocating an object of abstract class type 'qtmir::FakeMirSurface'
    FakeMirSurface *surface = new FakeMirSurface;
                                  ^
/home/alan/display_server/miral/miral-qt/src/modules/Unity/Application/mirsurfaceinterface.h:52:18: note: unimplemented pure virtual method 'requestPosition' in 'FakeMirSurface'
    virtual void requestPosition(const QPoint newPosition) = 0;
                 ^
/home/alan/display_server/miral/miral-qt/src/modules/Unity/Application/mirsurfaceinterface.h:121:18: note: unimplemented pure virtual method 'setShellChrome' in 'FakeMirSurface'
    virtual void setShellChrome(Mir::ShellChrome shellChrome) = 0;
                 ^

review: Needs Fixing

« Back to merge proposal