Merge lp:~gerardo-santana/gnome-control-center/gnome-control-center into lp:gnome-control-center

Proposed by Gerardo Santana
Status: Rejected
Rejected by: William Grant
Proposed branch: lp:~gerardo-santana/gnome-control-center/gnome-control-center
Merge into: lp:gnome-control-center
Diff against target: 86 lines (+51/-0)
2 files modified
panels/mouse/gnome-mouse-properties.c (+7/-0)
panels/mouse/gnome-mouse-properties.ui (+44/-0)
To merge this branch: bzr merge lp:~gerardo-santana/gnome-control-center/gnome-control-center
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Disapprove
Bastien Nocera Pending
VCS imports Pending
Review via email: mp+109335@code.launchpad.net

Description of the change

adds a checkbox for "Enable natural scrolling" under "Enable horizontal scrolling" in Touchpad tab

To post a comment you must log in.
Revision history for this message
Gerardo Santana (gerardo-santana) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. The issue you are reporting is an upstream one and it would be nice if somebody having it could send the bug to the developers of the software by following the instructions at https://wiki.ubuntu.com/Bugs/Upstream/GNOME. If you have done so, please tell us the number of the upstream bug (or the link), so we can add a bugwatch that will inform us about its status. Thanks in advance.

Revision history for this message
Sebastien Bacher (seb128) wrote :

the current version has a checkbox for natural scrolling, the patch would need to be redone to add horizontal scrolling if that's still something wanted.

Closing since it was never forwarded upstream as asked in the previous comment

review: Disapprove

Unmerged revisions

11812. By Gerardo Santana

Enables natural scrolling setting

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'panels/mouse/gnome-mouse-properties.c'
--- panels/mouse/gnome-mouse-properties.c 2012-03-13 18:12:47 +0000
+++ panels/mouse/gnome-mouse-properties.c 2012-06-08 11:54:44 +0000
@@ -174,6 +174,8 @@
174174
175 gtk_widget_set_sensitive (WID ("horiz_scroll_toggle"),175 gtk_widget_set_sensitive (WID ("horiz_scroll_toggle"),
176 !gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (WID ("scroll_disabled_radio"))));176 !gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (WID ("scroll_disabled_radio"))));
177 gtk_widget_set_sensitive (WID ("natural_scroll_toggle"),
178 !gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (WID ("scroll_disabled_radio"))));
177}179}
178180
179static void181static void
@@ -187,6 +189,8 @@
187189
188 gtk_widget_set_sensitive (WID ("horiz_scroll_toggle"),190 gtk_widget_set_sensitive (WID ("horiz_scroll_toggle"),
189 !gtk_toggle_button_get_active (disabled));191 !gtk_toggle_button_get_active (disabled));
192 gtk_widget_set_sensitive (WID ("natural_scroll_toggle"),
193 !gtk_toggle_button_get_active (disabled));
190194
191 if (gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (WID ("scroll_edge_radio"))))195 if (gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (WID ("scroll_edge_radio"))))
192 method = GSD_TOUCHPAD_SCROLL_METHOD_EDGE_SCROLLING;196 method = GSD_TOUCHPAD_SCROLL_METHOD_EDGE_SCROLLING;
@@ -304,6 +308,9 @@
304 g_settings_bind (touchpad_settings, "horiz-scroll-enabled",308 g_settings_bind (touchpad_settings, "horiz-scroll-enabled",
305 WID ("horiz_scroll_toggle"), "active",309 WID ("horiz_scroll_toggle"), "active",
306 G_SETTINGS_BIND_DEFAULT);310 G_SETTINGS_BIND_DEFAULT);
311 g_settings_bind (touchpad_settings, "natural-scroll-enabled",
312 WID ("natural_scroll_toggle"), "active",
313 G_SETTINGS_BIND_DEFAULT);
307 g_settings_bind (touchpad_settings, "motion-acceleration",314 g_settings_bind (touchpad_settings, "motion-acceleration",
308 gtk_range_get_adjustment (GTK_RANGE (WID ("touchpad_accel_scale"))), "value",315 gtk_range_get_adjustment (GTK_RANGE (WID ("touchpad_accel_scale"))), "value",
309 G_SETTINGS_BIND_DEFAULT);316 G_SETTINGS_BIND_DEFAULT);
310317
=== modified file 'panels/mouse/gnome-mouse-properties.ui'
--- panels/mouse/gnome-mouse-properties.ui 2012-04-22 11:57:19 +0000
+++ panels/mouse/gnome-mouse-properties.ui 2012-06-08 11:54:44 +0000
@@ -1087,6 +1087,50 @@
1087 <property name="position">2</property>1087 <property name="position">2</property>
1088 </packing>1088 </packing>
1089 </child>1089 </child>
1090 <child>
1091 <object class="GtkHBox" id="hbox17">
1092 <property name="visible">True</property>
1093 <property name="can_focus">False</property>
1094 <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property>
1095 <child>
1096 <object class="GtkLabel" id="label37">
1097 <property name="visible">True</property>
1098 <property name="can_focus">False</property>
1099 <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property>
1100 <property name="xalign">0</property>
1101 <property name="yalign">0</property>
1102 <property name="label"> </property>
1103 </object>
1104 <packing>
1105 <property name="expand">False</property>
1106 <property name="fill">False</property>
1107 <property name="position">0</property>
1108 </packing>
1109 </child>
1110 <child>
1111 <object class="GtkCheckButton" id="natural_scroll_toggle">
1112 <property name="label" translatable="yes">Enable _natural scrolling</property>
1113 <property name="visible">True</property>
1114 <property name="can_focus">True</property>
1115 <property name="receives_default">False</property>
1116 <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property>
1117 <property name="use_action_appearance">False</property>
1118 <property name="use_underline">True</property>
1119 <property name="draw_indicator">True</property>
1120 </object>
1121 <packing>
1122 <property name="expand">False</property>
1123 <property name="fill">False</property>
1124 <property name="position">1</property>
1125 </packing>
1126 </child>
1127 </object>
1128 <packing>
1129 <property name="expand">False</property>
1130 <property name="fill">False</property>
1131 <property name="position">2</property>
1132 </packing>
1133 </child>
1090 </object>1134 </object>
1091 <packing>1135 <packing>
1092 <property name="expand">False</property>1136 <property name="expand">False</property>

Subscribers

People subscribed via source and target branches

to all changes: