Code review comment for lp:~georg-zotti/stellarium/gz_milkyway-extinction

Revision history for this message
gzotti (georg-zotti) wrote :

Fabien, do you mean in StelPainter::projectArray() or even prj->project()? At this step we need azimuthal coordinates, I don't see how I could extract those from this overall projection to viewport. Where can this be done?

The longest change in code was the required extension of StelPainter into actually being able to use vertex color arrays - the shader was already here, but StelVertexArray had no color array.

I had to increase Milky Way vertex density for better accuracy, but decreased overall spherical coverage by removing half of the texture (the black parts at the poles) and so also removed about half the required vertices.

I don't know how often update() is called. If less frequently than draw() but still every few frames, the extinction loop could also go there.

I will try to test equal setups of trunk vs. this for performance comparison.

« Back to merge proposal