Code review comment for lp:~georg-zotti/stellarium/gz_fix-ecliptic-obliquity

Revision history for this message
gzotti (georg-zotti) wrote :

> Georg, are you can add unit tests for this feature? It should be helpful for
> checking accuracy and checking for correct for the code.

Alright, a few unit tests against the numerical example given in the paper are completed (r7625). There was even a minus missing in the (otherwise unused) reference solution :-P
Not sure about how the unit tests are used in an automatic workflow, are debug messages allowed? I leave them in but commented away, for further development.

Alex, I hope this completes the package of your requests. This branch does not care for other planets' orbital planes which were never properly handled by now, only applications in terrestrial history will see a benefit.

Again, this is Step 1 of 3 to be done in the next few weeks to solve several critical questions by historically inclined audience. #2 shall be correct application of DeltaT, and #3 shall bring in Nutation with the IAU-2000A model fitting to the 2006 precession of which this Vondrak model is a compatible, extended version.

Anything missing?

review: Needs Resubmitting

« Back to merge proposal