Code review comment for lp:~georg-zotti/stellarium/gz_fix-ObjectInfoMap

Revision history for this message
gzotti (georg-zotti) wrote :

Key name format is rather arbitrary as long as there is no reference documentation/guideline. I removed "km/s" types, which makes the tags harder to understand without docs IMHO.

Is it possible to dump such a map completely to script output, so that keys can be found more easily? (This should be added to the scripting API docs!)

name and localized-name are the only entries where un-/+translated makes sense. The map is mostly useful for scripting extensions.

I have added a basic implementation of the added tags into your various object catalog plugins.
I don't know exact details of object types for some plugins. Please add them. Some entries may have to be harmonized (RA/ra, ...) or even removed (position is already there)?

« Back to merge proposal