Code review comment for lp:~georg-zotti/stellarium/gz_fix-ObjectInfoMap

Revision history for this message
Alexander Wolf (alexwolf) wrote :

Please make names of keys are more consistent - for example:
------------
map.insert("range_km", range);
map.insert("RangeRate_km/s", rangeRate);
------------
Plus keys, like "speed_km/s" is very strange.

Compare it to original format of key: azimuth-geometric.

The list of possible keys is necessary also in description of methods (the doxygen format).

I see inconsistency in filing of types - please compare:
-------------
map.insert("type", q_("meteor shower"));
-------------
and
-------------
map.insert("type", "artificial satellite");
-------------

And obvious that all translatable values should be given to users in two format - English and localized (see keys "name" and "localized-name" in original code).

review: Needs Fixing

« Back to merge proposal