Code review comment for lp:~gebner/compiz/compiz.vertexbuffer-autoprogram-uniform-segfault

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

This makes sense, thanks.

This reminds me that I need to fix the VertexBuffer class to behave in a more sane way when it comes to having no active program set. At the moment it just crashes if you don't call setProgram or setAutoProgram. I remember I wanted to enforce something in its constructor, but at the time didn't want to break ABI. I've filed bug 1162597 about that.

One more thing before we merge this - can you add commit metadata to link this to a bug? I didn't see anything, so I've filed bug 1162598. You can link it by doing this:

bzr commit --empty --fixes lp:1162598
bzr push

On another note, nice work with the color management plugin. If you want it to be included in-tree, just file a bug about it on launchpad and we'll do the paperwork to get it in.

review: Approve

« Back to merge proposal