Merge lp:ical-tcl into lp:~sergii/ical-tcl/main

Proposed by Guillaume Ballin
Status: Needs review
Proposed branch: lp:ical-tcl
Merge into: lp:~sergii/ical-tcl/main
Diff against target: 81 lines (+21/-3)
3 files modified
Makefile.am (+16/-1)
configure.ac (+1/-1)
dayview.tcl (+4/-1)
To merge this branch: bzr merge lp:ical-tcl
Reviewer Review Type Date Requested Status
Guillaume Ballin (community) Approve
Review via email: mp+365625@code.launchpad.net

Commit message

Adding a desktop file to ical and a modern color icon.
Update autotools files to avoid warnings.

To post a comment you must log in.
Revision history for this message
Guillaume Ballin (geballin) :
review: Approve
Revision history for this message
Sergei Golubchik (sergii) wrote :

I'm no longer using ical, or bzr fwiw.

Would you like to take over maintaining it?

Revision history for this message
Guillaume Ballin (geballin) wrote :

Hi,

I'm OK in maintaining it if that can make it continue to live and evolve.
I'm already actually the maintainer of the Arch linux package for iCal on AUR.

Revision history for this message
Sergei Golubchik (sergii) wrote :

Hi, Guillaume!

On Apr 09, Guillaume Ballin wrote:
> Hi,
>
> I'm OK in maintaining it if that can make it continue to live and evolve.
> I'm already actually the maintainer of the Arch linux package for iCal on AUR.

Here you are, you're the new maintainer.

Thanks!

Regards,
Sergei

lp:ical-tcl updated
47. By Guillaume Ballin

Merge for creating Ical 3.0.4
Adding ical.desktop and new modern icon.

Unmerged revisions

47. By Guillaume Ballin

Merge for creating Ical 3.0.4
Adding ical.desktop and new modern icon.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile.am'
--- Makefile.am 2017-02-23 09:11:34 +0000
+++ Makefile.am 2019-04-13 01:05:11 +0000
@@ -6,9 +6,10 @@
6icallib_DATA = $(builddir)/startup.tcl $(builddir)/ps_header.tcl6icallib_DATA = $(builddir)/startup.tcl $(builddir)/ps_header.tcl
7EXTRA_DIST = startup.tcl.in ps_header.ps doc/ical.html doc/interface.html \7EXTRA_DIST = startup.tcl.in ps_header.ps doc/ical.html doc/interface.html \
8 COPYRIGHT.ORIG Makefile.am8 COPYRIGHT.ORIG Makefile.am
9CLEANFILES = $(icallib_DATA)
10dist_man1_MANS = doc/ical.man9dist_man1_MANS = doc/ical.man
1110
11appdir = $(prefix)/share/applications
12app_DATA = ical.desktop
12ical_SOURCES = cal_tcl.C dateeditor.C dispatch.C ical.C ical_tcl.C \13ical_SOURCES = cal_tcl.C dateeditor.C dispatch.C ical.C ical_tcl.C \
13 item_tcl.C object.C time_tcl.C main.C14 item_tcl.C object.C time_tcl.C main.C
14ical_CPPFLAGS = -DICALLIBDIR='"$(icallibdir)"' -I$(srcdir)/calendar -I$(srcdir)/types -I$(srcdir)/time @TK_XINCLUDES@15ical_CPPFLAGS = -DICALLIBDIR='"$(icallibdir)"' -I$(srcdir)/calendar -I$(srcdir)/types -I$(srcdir)/time @TK_XINCLUDES@
@@ -29,6 +30,8 @@
2930
30libtypes_a_SOURCES = types/bitvec.C types/hashfuncs.C types/intset.C31libtypes_a_SOURCES = types/bitvec.C types/hashfuncs.C types/intset.C
3132
33CLEANFILES = $(icallib_DATA) $(app_DATA)
34
32ps_header.tcl: ps_header.ps35ps_header.tcl: ps_header.ps
33 echo 'proc ps_header {} { set val {}' > $@;36 echo 'proc ps_header {} { set val {}' > $@;
34 @SED@ -e 's/\[/\\[/g' \37 @SED@ -e 's/\[/\\[/g' \
@@ -36,6 +39,18 @@
36 -e 's/.*/ set val "$$val&\\n"/' < $< >> $@;39 -e 's/.*/ set val "$$val&\\n"/' < $< >> $@;
37 echo ' return $$val\n}' >> $@40 echo ' return $$val\n}' >> $@
3841
42ical.desktop:
43 echo "[Desktop Entry]" >$@
44 echo "Name=Ical" >>$@
45 echo "Comment=Ical calendar package" >>$@
46 echo "Exec=ical" >>$@
47 echo 'Icon=$(icallibdir)/contrib/ical_icon.png' >>$@
48 echo "Terminal=false" >>$@
49 echo "Type=Application" >>$@
50 echo "Categories=Office" >>$@
51 echo "StartupNotify=true;" >>$@
52 chmod 644 $@
53
39# cannot do it in configure, as libdir is not known there :(54# cannot do it in configure, as libdir is not known there :(
40startup.tcl: startup.tcl.in55startup.tcl: startup.tcl.in
41 @SED@ -e 's!@''PACKAGE_VERSION''@!@PACKAGE_VERSION@!g' \56 @SED@ -e 's!@''PACKAGE_VERSION''@!@PACKAGE_VERSION@!g' \
4257
=== modified file 'configure.ac'
--- configure.ac 2018-02-11 11:25:00 +0000
+++ configure.ac 2019-04-13 01:05:11 +0000
@@ -1,5 +1,5 @@
1AC_INIT([ical], [3.0.4])1AC_INIT([ical], [3.0.4])
2AM_INIT_AUTOMAKE2AM_INIT_AUTOMAKE([subdir-objects])
33
4# Create config files4# Create config files
5AC_CONFIG_HEADER(config.h)5AC_CONFIG_HEADER(config.h)
66
=== added file 'contrib/ical_icon.png'
7Binary files contrib/ical_icon.png 1970-01-01 00:00:00 +0000 and contrib/ical_icon.png 2019-04-13 01:05:11 +0000 differ7Binary files contrib/ical_icon.png 1970-01-01 00:00:00 +0000 and contrib/ical_icon.png 2019-04-13 01:05:11 +0000 differ
=== modified file 'dayview.tcl'
--- dayview.tcl 2011-01-12 11:31:47 +0000
+++ dayview.tcl 2019-04-13 01:05:11 +0000
@@ -7,8 +7,10 @@
7# A DayView shows the notices and appointments for one day.7# A DayView shows the notices and appointments for one day.
88
9set dayview_id 09set dayview_id 0
10set ICAL_ICON [file join [file dirname [info script]] contrib ical_icon.png]
1011
11class DayView {} {12class DayView {} {
13 global ICAL_ICON
12 # Generate new id for window14 # Generate new id for window
13 global dayview_id15 global dayview_id
14 incr dayview_id16 incr dayview_id
@@ -47,7 +49,8 @@
4749
48 wm title $n Calendar50 wm title $n Calendar
49 wm iconname $n ical51 wm iconname $n ical
50 wm iconbitmap $n ical_icon52 image create photo applicationIcon -file $ICAL_ICON;wm iconphoto $n -default applicationIcon
53
51 wm protocol $n WM_DELETE_WINDOW [list ical_close_view $n]54 wm protocol $n WM_DELETE_WINDOW [list ical_close_view $n]
5255
53 $self set_date [date today]56 $self set_date [date today]

Subscribers

People subscribed via source and target branches