Merge lp:~gcrosswhite/leo-editor/ran-setup-through-2to3 into lp:leo-editor/old-trunk

Proposed by Gregory Crosswhite
Status: Needs review
Proposed branch: lp:~gcrosswhite/leo-editor/ran-setup-through-2to3
Merge into: lp:leo-editor/old-trunk
Diff against target: 33 lines (+4/-4)
1 file modified
setup.py (+4/-4)
To merge this branch: bzr merge lp:~gcrosswhite/leo-editor/ran-setup-through-2to3
Reviewer Review Type Date Requested Status
The Leo editor team Pending
Review via email: mp+63760@code.launchpad.net

Description of the change

I ran setup.py through 2to3 to get it working with Python 3. I checked that it still works with python2.5 and python2.6, so I would recommend accepting this patch since it makes Leo installable out-of-the-box with Python 3 without breaking backwards compatability.

To post a comment you must log in.

Unmerged revisions

4297. By Gregory Crosswhite

Ran setup.py through 2to3 to make it compatible with Python 3.

I also checked it with python2.5 and python2.6 and it works just fine,
so this change does not seem to break backwards compatability at all.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'setup.py'
--- setup.py 2010-05-25 19:40:43 +0000
+++ setup.py 2011-06-07 20:19:51 +0000
@@ -42,7 +42,7 @@
42# Tell distutils to put the data_files in platform-specific installation42# Tell distutils to put the data_files in platform-specific installation
43# locations. See here for an explanation:43# locations. See here for an explanation:
44# http://groups.google.com/group/comp.lang.python/browse_thread/thread/35ec7b2fed36eaec/2105ee4d9e8042cb44# http://groups.google.com/group/comp.lang.python/browse_thread/thread/35ec7b2fed36eaec/2105ee4d9e8042cb
45for scheme in INSTALL_SCHEMES.values():45for scheme in list(INSTALL_SCHEMES.values()):
46 scheme['data'] = scheme['purelib']46 scheme['data'] = scheme['purelib']
47#@+node:ville.20090213233714.2:@url http://groups.google.com/group/comp.lang.python/browse_thread/thread/35ec7b2fed36eaec/2105ee4d9e8042cb47#@+node:ville.20090213233714.2:@url http://groups.google.com/group/comp.lang.python/browse_thread/thread/35ec7b2fed36eaec/2105ee4d9e8042cb
48#@-node:ville.20090213233714.2:@url http://groups.google.com/group/comp.lang.python/browse_thread/thread/35ec7b2fed36eaec/2105ee4d9e8042cb48#@-node:ville.20090213233714.2:@url http://groups.google.com/group/comp.lang.python/browse_thread/thread/35ec7b2fed36eaec/2105ee4d9e8042cb
@@ -71,9 +71,9 @@
71 data_files.append([dirpath, [os.path.join(dirpath, f) for f in filenames]])71 data_files.append([dirpath, [os.path.join(dirpath, f) for f in filenames]])
7272
73import pprint73import pprint
74print "data files"74print("data files")
75pprint.pprint(data_files)75pprint.pprint(data_files)
76print "packages (pre-cleanup)"76print("packages (pre-cleanup)")
77pprint.pprint(packages)77pprint.pprint(packages)
7878
79#cleanup unwanted packages79#cleanup unwanted packages
@@ -81,7 +81,7 @@
81# extensions should be provided through repos (packaging)81# extensions should be provided through repos (packaging)
82packages = [pa for pa in packages if not pa.startswith('leo.extensions')]82packages = [pa for pa in packages if not pa.startswith('leo.extensions')]
8383
84print "packages (post-cleanup)"84print("packages (post-cleanup)")
85pprint.pprint(packages)85pprint.pprint(packages)
8686
87#cleanup unwanted data files87#cleanup unwanted data files

Subscribers

People subscribed via source and target branches

to status/vote changes: