Code review comment for lp:~gawhelan/exaile/DBus-enqueue

Revision history for this message
Graham Whelan (gawhelan) wrote :

Johannes Sasongko wrote:
"Do you think it will be better to allow newline characters as the separator as well? I know files may have newline chars in them, but it's not common at all, and I'm guessing the convenience of doing `cat list_of_files.txt | exaile -` outweighs the limitation."

I considered using newline as the separator but I decided to play it safe and use null. I think you're right though, the convenience of using newline does outweigh the limitations, so I've changed it.

I don't think it's necessary to support both. You could add a `-0` option which accepts a null-separated list, but like you said, filenames containing newline chars are so rare I doubt it would be of much use.

« Back to merge proposal