Code review comment for lp:~gawhelan/exaile/DBus-enqueue

Revision history for this message
Johannes Sasongko (sjohannes) wrote :

Thanks, they would be quite handy indeed.

Just one question about this bit:

+ # if '-' is the first argument then we look for a null
+ # separated list of filenames from stdin.
+ # This enables: find PATH -name *.mp3 -print0 | exaile -
+ if args[0] == '-':
+ args = sys.stdin.read().split('\0')

Do you think it will be better to allow newline characters as the separator as well? I know files may have newline chars in them, but it's not common at all, and I'm guessing the convenience of doing `cat list_of_files.txt | exaile -` outweighs the limitation.

In any case, I'm approving the merge, pending your response.

review: Approve

« Back to merge proposal