Merge lp:~gaul/unity/on_entry_added_leak_5.0 into lp:unity

Proposed by Andrew Gaul
Status: Superseded
Proposed branch: lp:~gaul/unity/on_entry_added_leak_5.0
Merge into: lp:unity
Diff against target: 25805 lines (+18358/-228) (has conflicts)
162 files modified
AUTHORS (+17/-0)
CMakeLists.txt (+16/-0)
ChangeLog (+2441/-0)
HACKING (+4/-0)
UnityCore/DBusIndicators.cpp (+38/-2)
UnityCore/DBusIndicators.h (+4/-0)
UnityCore/GLibSignal.cpp (+16/-0)
UnityCore/GLibSignal.h (+4/-0)
UnityCore/Indicator.cpp (+28/-0)
dash/DashController.cpp (+80/-0)
dash/DashController.h (+3/-0)
dash/DashView.cpp (+111/-0)
dash/PlacesGroup.cpp (+6/-0)
dash/ResultRendererTile.cpp (+89/-11)
dash/ResultView.cpp (+10/-0)
dash/ResultViewGrid.cpp (+119/-0)
dash/ResultViewGrid.h (+29/-0)
dash/ScopeBar.cpp (+49/-0)
dash/ScopeBarIcon.cpp (+5/-0)
hud/HudButton.cpp (+50/-2)
hud/HudButton.h (+25/-0)
hud/HudController.cpp (+169/-3)
hud/HudController.h (+43/-5)
hud/HudIcon.cpp (+12/-0)
hud/HudView.cpp (+156/-11)
hud/HudView.h (+32/-1)
launcher/AbstractLauncherIcon.h (+31/-0)
launcher/ApplicationLauncherIcon.cpp (+507/-0)
launcher/ApplicationLauncherIcon.h (+28/-0)
launcher/BFBLauncherIcon.cpp (+9/-0)
launcher/DesktopLauncherIcon.cpp (+14/-0)
launcher/DeviceLauncherSection.cpp (+74/-0)
launcher/DeviceLauncherSection.h (+33/-0)
launcher/DndData.cpp (+20/-0)
launcher/EdgeBarrierController.cpp (+66/-12)
launcher/EdgeBarrierController.h (+4/-0)
launcher/HudLauncherIcon.cpp (+42/-0)
launcher/Launcher.cpp (+576/-1)
launcher/Launcher.h (+33/-1)
launcher/LauncherController.cpp (+331/-1)
launcher/LauncherController.h (+8/-0)
launcher/LauncherIcon.cpp (+64/-5)
launcher/LauncherIcon.h (+17/-0)
launcher/QuicklistMenuItem.cpp (+258/-0)
launcher/QuicklistMenuItem.h (+27/-0)
launcher/QuicklistMenuItemSeparator.cpp (+85/-0)
launcher/QuicklistMenuItemSeparator.h (+2/-0)
launcher/QuicklistView.cpp (+159/-1)
launcher/QuicklistView.h (+5/-0)
launcher/SimpleLauncherIcon.cpp (+12/-0)
launcher/SimpleLauncherIcon.h (+7/-0)
launcher/SoftwareCenterLauncherIcon.cpp (+47/-0)
launcher/SoftwareCenterLauncherIcon.h (+10/-0)
launcher/StandaloneLauncher.cpp (+20/-0)
launcher/SwitcherController.cpp (+139/-0)
launcher/SwitcherController.h (+23/-0)
launcher/SwitcherModel.cpp (+31/-0)
launcher/SwitcherModel.h (+27/-0)
launcher/SwitcherView.cpp (+42/-0)
launcher/SwitcherView.h (+11/-0)
launcher/TrashLauncherIcon.cpp (+30/-0)
launcher/VolumeLauncherIcon.cpp (+496/-0)
launcher/VolumeLauncherIcon.h (+55/-0)
manual-tests/Dash.txt (+60/-29)
manual-tests/Launcher.txt (+214/-0)
manual-tests/Panel.txt (+17/-0)
manual-tests/ShortcutsOverlay.txt (+1/-0)
manual-tests/SoftwareCenter.txt (+211/-104)
manual-tests/Switcher.txt (+91/-0)
manual-tests/WindowButtons.txt (+28/-0)
manual-tests/WindowManagement.txt (+23/-0)
panel/PanelController.cpp (+20/-1)
panel/PanelController.h (+5/-0)
panel/PanelMenuView.cpp (+31/-0)
panel/PanelView.cpp (+10/-0)
plugins/unityshell/src/HudAbstractView.cpp (+33/-0)
plugins/unityshell/src/HudAbstractView.h (+66/-0)
plugins/unityshell/src/LauncherControllerPrivate.h (+160/-0)
plugins/unityshell/src/ScreenEffectFramebufferObject.cpp.OTHER (+238/-0)
plugins/unityshell/src/UnityGestureBroker.cpp (+247/-0)
plugins/unityshell/src/UnityShowdesktopHandler.cpp (+9/-0)
plugins/unityshell/src/compizminimizedwindowhandler.h (+10/-0)
plugins/unityshell/src/unity-launcher-accessible.cpp (+10/-0)
plugins/unityshell/src/unity-util-accessible.cpp (+2/-2)
plugins/unityshell/src/unitya11y.cpp (+20/-0)
plugins/unityshell/src/unityshell.cpp (+753/-9)
plugins/unityshell/src/unityshell.h (+66/-1)
services/panel-service.c (+9/-0)
shortcuts/ShortcutController.cpp (+5/-0)
shortcuts/ShortcutView.cpp (+8/-0)
standalone-clients/CMakeLists.txt.OTHER (+574/-0)
tests/CMakeLists.txt (+191/-0)
tests/autopilot/autopilot/emulators/bamf.py.OTHER (+411/-0)
tests/autopilot/autopilot/keybindings.py.OTHER (+259/-0)
tests/autopilot/autopilot/matchers/__init__.py (+31/-0)
tests/autopilot/autopilot/utilities.py.OTHER (+78/-0)
tests/autopilot/unity/emulators/__init__.py (+289/-0)
tests/autopilot/unity/emulators/dash.py (+58/-1)
tests/autopilot/unity/emulators/hud.py (+5/-0)
tests/autopilot/unity/emulators/icons.py (+13/-0)
tests/autopilot/unity/emulators/launcher.py (+159/-2)
tests/autopilot/unity/emulators/quicklist.py (+46/-0)
tests/autopilot/unity/emulators/tooltip.py (+23/-0)
tests/autopilot/unity/emulators/window_manager.py (+25/-0)
tests/autopilot/unity/tests/__init__.py (+232/-0)
tests/autopilot/unity/tests/test_command_lens.py (+70/-0)
tests/autopilot/unity/tests/test_dash.py (+339/-6)
tests/autopilot/unity/tests/test_home_lens.py (+17/-0)
tests/autopilot/unity/tests/test_hud.py (+390/-0)
tests/autopilot/unity/tests/test_ibus.py (+189/-1)
tests/autopilot/unity/tests/test_launcher.py.OTHER (+999/-0)
tests/autopilot/unity/tests/test_panel.py (+507/-1)
tests/autopilot/unity/tests/test_quicklist.py (+319/-0)
tests/autopilot/unity/tests/test_shortcut_hint.py (+113/-0)
tests/autopilot/unity/tests/test_switcher.py (+58/-0)
tests/test-gestures/CMakeLists.txt (+6/-0)
tests/test-gestures/compiz_mock/core/screen.h (+30/-0)
tests/test-gestures/test_gesture_broker.cpp (+140/-0)
tests/test-minimize-window-handler/test-minimize-handler.cpp (+14/-0)
tests/test_dbus_indicators.cpp (+98/-0)
tests/test_glib_signals.cpp (+23/-0)
tests/test_hud_button.cpp (+76/-0)
tests/test_hud_controller.cpp (+87/-0)
tests/test_hud_private.cpp (+80/-0)
tests/test_hud_view.cpp (+74/-0)
tests/test_im_text_entry.cpp (+173/-0)
tests/test_keyboard_util.cpp (+118/-0)
tests/test_launcher_controller.cpp (+215/-0)
tests/test_main.cpp (+12/-0)
tests/test_resultviewgrid.cpp (+103/-0)
tests/test_service_lens.c.OTHER (+187/-0)
tests/test_service_main.cpp (+68/-0)
tests/test_service_panel.c (+253/-0)
tests/test_service_panel.h (+46/-0)
tests/test_switcher_controller.cpp (+43/-0)
tests/test_time_util.cpp (+38/-0)
tests/test_uscreen_mock.h (+87/-1)
tests/test_utils.h (+31/-0)
tests/unit/TestQuicklistMenuitems.cpp.OTHER (+258/-0)
tools/unity.cmake (+50/-1)
unity-shared/DebugDBusInterface.cpp (+24/-0)
unity-shared/IMTextEntry.cpp (+81/-0)
unity-shared/IMTextEntry.h (+13/-0)
unity-shared/IconRenderer.cpp (+183/-0)
unity-shared/IconTexture.cpp (+2/-0)
unity-shared/IconTexture.h (+4/-0)
unity-shared/OverlayRenderer.cpp (+51/-1)
unity-shared/PluginAdapter.cpp (+222/-0)
unity-shared/PluginAdapter.h (+36/-0)
unity-shared/SearchBar.cpp (+18/-4)
unity-shared/StaticCairoText.cpp (+37/-0)
unity-shared/TimeUtil.h (+6/-0)
unity-shared/UBusMessages.h (+10/-0)
unity-shared/UScreen.cpp (+82/-8)
unity-shared/UScreen.h (+19/-0)
unity-shared/UnityWindowView.cpp (+48/-0)
unity-shared/UnityWindowView.h (+9/-0)
unity-shared/WindowButtons.cpp (+103/-0)
unity-shared/XKeyboardUtil.cpp (+44/-0)
unity-shared/XKeyboardUtil.h (+34/-0)
unity-shared/XWindowManager.cpp (+249/-0)
unity-shared/XWindowManager.h (+132/-0)
Text conflict in AUTHORS
Text conflict in CMakeLists.txt
Text conflict in ChangeLog
Text conflict in HACKING
Text conflict in UnityCore/DBusIndicators.cpp
Text conflict in UnityCore/GLibSignal.cpp
Text conflict in UnityCore/GLibSignal.h
Text conflict in UnityCore/Indicator.cpp
Text conflict in dash/DashController.cpp
Text conflict in dash/DashView.cpp
Text conflict in dash/PlacesGroup.cpp
Text conflict in dash/ResultRendererTile.cpp
Text conflict in dash/ResultView.cpp
Text conflict in dash/ResultViewGrid.cpp
Text conflict in dash/ResultViewGrid.h
Text conflict in dash/ScopeBar.cpp
Text conflict in dash/ScopeBarIcon.cpp
Text conflict in hud/HudButton.cpp
Text conflict in hud/HudButton.h
Text conflict in hud/HudController.cpp
Text conflict in hud/HudController.h
Text conflict in hud/HudIcon.cpp
Path conflict: hud/HudPrivate.cpp / plugins/unityshell/src/HudPrivate.cpp
Path conflict: hud/HudPrivate.h / plugins/unityshell/src/HudPrivate.h
Text conflict in hud/HudView.cpp
Text conflict in hud/HudView.h
Text conflict in launcher/AbstractLauncherIcon.h
Text conflict in launcher/ApplicationLauncherIcon.cpp
Text conflict in launcher/ApplicationLauncherIcon.h
Text conflict in launcher/BFBLauncherIcon.cpp
Text conflict in launcher/DesktopLauncherIcon.cpp
Text conflict in launcher/DeviceLauncherSection.cpp
Text conflict in launcher/DeviceLauncherSection.h
Text conflict in launcher/DndData.cpp
Text conflict in launcher/EdgeBarrierController.cpp
Text conflict in launcher/EdgeBarrierController.h
Text conflict in launcher/HudLauncherIcon.cpp
Text conflict in launcher/Launcher.cpp
Text conflict in launcher/Launcher.h
Text conflict in launcher/LauncherController.cpp
Text conflict in launcher/LauncherController.h
Path conflict: launcher/LauncherControllerPrivate.h / plugins/unityshell/src/LauncherControllerPrivate.h
Text conflict in launcher/LauncherIcon.cpp
Text conflict in launcher/LauncherIcon.h
Text conflict in launcher/QuicklistMenuItem.cpp
Text conflict in launcher/QuicklistMenuItem.h
Text conflict in launcher/QuicklistMenuItemSeparator.cpp
Text conflict in launcher/QuicklistView.cpp
Text conflict in launcher/QuicklistView.h
Text conflict in launcher/SimpleLauncherIcon.cpp
Text conflict in launcher/SimpleLauncherIcon.h
Text conflict in launcher/SoftwareCenterLauncherIcon.cpp
Text conflict in launcher/SoftwareCenterLauncherIcon.h
Text conflict in launcher/StandaloneLauncher.cpp
Text conflict in launcher/SwitcherController.cpp
Text conflict in launcher/SwitcherController.h
Text conflict in launcher/SwitcherModel.cpp
Text conflict in launcher/SwitcherModel.h
Text conflict in launcher/SwitcherView.cpp
Text conflict in launcher/SwitcherView.h
Text conflict in launcher/TrashLauncherIcon.cpp
Text conflict in launcher/VolumeLauncherIcon.cpp
Text conflict in launcher/VolumeLauncherIcon.h
Text conflict in manual-tests/Dash.txt
Text conflict in manual-tests/Launcher.txt
Text conflict in manual-tests/SoftwareCenter.txt
Text conflict in manual-tests/Switcher.txt
Text conflict in manual-tests/WindowButtons.txt
Text conflict in manual-tests/WindowManagement.txt
Text conflict in panel/PanelController.cpp
Text conflict in panel/PanelController.h
Text conflict in panel/PanelMenuView.cpp
Text conflict in panel/PanelView.cpp
Text conflict in plugins/unityshell/src/LauncherControllerPrivate.h
Contents conflict in plugins/unityshell/src/ScreenEffectFramebufferObject.cpp
Text conflict in plugins/unityshell/src/UnityGestureBroker.cpp
Text conflict in plugins/unityshell/src/UnityShowdesktopHandler.cpp
Text conflict in plugins/unityshell/src/compizminimizedwindowhandler.h
Text conflict in plugins/unityshell/src/unity-launcher-accessible.cpp
Text conflict in plugins/unityshell/src/unitya11y.cpp
Text conflict in plugins/unityshell/src/unityshell.cpp
Text conflict in plugins/unityshell/src/unityshell.h
Text conflict in shortcuts/ShortcutController.cpp
Conflict adding files to standalone-clients.  Created directory.
Conflict because standalone-clients is not versioned, but has versioned children.  Versioned directory.
Contents conflict in standalone-clients/CMakeLists.txt
Text conflict in tests/CMakeLists.txt
Conflict adding files to tests/autopilot/autopilot.  Created directory.
Conflict because tests/autopilot/autopilot is not versioned, but has versioned children.  Versioned directory.
Conflict adding files to tests/autopilot/autopilot/emulators.  Created directory.
Conflict because tests/autopilot/autopilot/emulators is not versioned, but has versioned children.  Versioned directory.
Contents conflict in tests/autopilot/autopilot/emulators/bamf.py
Contents conflict in tests/autopilot/autopilot/keybindings.py
Contents conflict in tests/autopilot/autopilot/utilities.py
Text conflict in tests/autopilot/unity/emulators/__init__.py
Text conflict in tests/autopilot/unity/emulators/dash.py
Text conflict in tests/autopilot/unity/emulators/hud.py
Text conflict in tests/autopilot/unity/emulators/icons.py
Text conflict in tests/autopilot/unity/emulators/launcher.py
Text conflict in tests/autopilot/unity/emulators/quicklist.py
Text conflict in tests/autopilot/unity/emulators/tooltip.py
Text conflict in tests/autopilot/unity/emulators/window_manager.py
Text conflict in tests/autopilot/unity/tests/__init__.py
Text conflict in tests/autopilot/unity/tests/test_command_lens.py
Text conflict in tests/autopilot/unity/tests/test_dash.py
Text conflict in tests/autopilot/unity/tests/test_home_lens.py
Text conflict in tests/autopilot/unity/tests/test_hud.py
Text conflict in tests/autopilot/unity/tests/test_ibus.py
Contents conflict in tests/autopilot/unity/tests/test_launcher.py
Text conflict in tests/autopilot/unity/tests/test_panel.py
Text conflict in tests/autopilot/unity/tests/test_quicklist.py
Text conflict in tests/autopilot/unity/tests/test_shortcut_hint.py
Text conflict in tests/autopilot/unity/tests/test_switcher.py
Text conflict in tests/test-gestures/CMakeLists.txt
Text conflict in tests/test-gestures/compiz_mock/core/screen.h
Text conflict in tests/test-gestures/test_gesture_broker.cpp
Text conflict in tests/test-minimize-window-handler/test-minimize-handler.cpp
Conflict adding file tests/test_dbus_indicators.cpp.  Moved existing file to tests/test_dbus_indicators.cpp.moved.
Text conflict in tests/test_glib_signals.cpp
Text conflict in tests/test_hud_button.cpp
Conflict adding file tests/test_hud_controller.cpp.  Moved existing file to tests/test_hud_controller.cpp.moved.
Text conflict in tests/test_hud_private.cpp
Conflict adding file tests/test_hud_view.cpp.  Moved existing file to tests/test_hud_view.cpp.moved.
Text conflict in tests/test_im_text_entry.cpp
Text conflict in tests/test_keyboard_util.cpp
Text conflict in tests/test_launcher_controller.cpp
Text conflict in tests/test_main.cpp
Conflict adding file tests/test_resultviewgrid.cpp.  Moved existing file to tests/test_resultviewgrid.cpp.moved.
Contents conflict in tests/test_service_lens.c
Text conflict in tests/test_service_main.cpp
Conflict adding file tests/test_service_panel.h.  Moved existing file to tests/test_service_panel.h.moved.
Text conflict in tests/test_switcher_controller.cpp
Conflict adding file tests/test_time_util.cpp.  Moved existing file to tests/test_time_util.cpp.moved.
Text conflict in tests/test_uscreen_mock.h
Text conflict in tests/test_utils.h
Conflict adding files to tests/unit.  Created directory.
Conflict because tests/unit is not versioned, but has versioned children.  Versioned directory.
Contents conflict in tests/unit/TestQuicklistMenuitems.cpp
Text conflict in tools/unity.cmake
Text conflict in unity-shared/DebugDBusInterface.cpp
Text conflict in unity-shared/IMTextEntry.cpp
Text conflict in unity-shared/IMTextEntry.h
Text conflict in unity-shared/IconRenderer.cpp
Text conflict in unity-shared/IconTexture.h
Text conflict in unity-shared/OverlayRenderer.cpp
Text conflict in unity-shared/PluginAdapter.cpp
Text conflict in unity-shared/PluginAdapter.h
Text conflict in unity-shared/SearchBar.cpp
Text conflict in unity-shared/StaticCairoText.cpp
Text conflict in unity-shared/TimeUtil.h
Text conflict in unity-shared/UBusMessages.h
Text conflict in unity-shared/UScreen.cpp
Text conflict in unity-shared/UScreen.h
Text conflict in unity-shared/UnityWindowView.cpp
Text conflict in unity-shared/UnityWindowView.h
Text conflict in unity-shared/WindowButtons.cpp
Text conflict in unity-shared/XKeyboardUtil.cpp
Text conflict in unity-shared/XKeyboardUtil.h
Text conflict in unity-shared/XWindowManager.cpp
Text conflict in unity-shared/XWindowManager.h
To merge this branch: bzr merge lp:~gaul/unity/on_entry_added_leak_5.0
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+176753@code.launchpad.net

This proposal has been superseded by a proposal from 2013-07-24.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'AUTHORS'
--- AUTHORS 2013-04-03 13:42:12 +0000
+++ AUTHORS 2013-07-24 18:20:41 +0000
@@ -22,10 +22,14 @@
22 Benjamin Kerensa <bkerensa@ubuntu.com>22 Benjamin Kerensa <bkerensa@ubuntu.com>
23 Bilal Akhtar <bilalakhtar@ubuntu.com>23 Bilal Akhtar <bilalakhtar@ubuntu.com>
24 Bilal Akhtar <bilalakhtar@ubuntu.com>, Thomi Richards <thomi.richards@canonical.com>24 Bilal Akhtar <bilalakhtar@ubuntu.com>, Thomi Richards <thomi.richards@canonical.com>
25<<<<<<< TREE
25 Brandon Schaefer <brandon.schaefer@canonical.com>26 Brandon Schaefer <brandon.schaefer@canonical.com>
26 Brandon Schaefer <brandon.schaefer@canonical.com>, Brandon Schaefer <brandontschaefer@gmail.com>27 Brandon Schaefer <brandon.schaefer@canonical.com>, Brandon Schaefer <brandontschaefer@gmail.com>
27 Brandon Schaefer <brandon.schaefer@canonical.com>, MC Return <mc.return@gmx.net>28 Brandon Schaefer <brandon.schaefer@canonical.com>, MC Return <mc.return@gmx.net>
28 Brandon Schaefer <brandon.schaefer@canonical.com>, Nick Dedekind <nicholas.dedekind@gmail.com>29 Brandon Schaefer <brandon.schaefer@canonical.com>, Nick Dedekind <nicholas.dedekind@gmail.com>
30=======
31 Brandon Schaefer <brandon.schaefer@canonical.com>
32>>>>>>> MERGE-SOURCE
29 Brandon Schaefer <brandontschaefer@gmail.com33 Brandon Schaefer <brandontschaefer@gmail.com
30 Brandon Schaefer <brandontschaefer@gmail.com>34 Brandon Schaefer <brandontschaefer@gmail.com>
31 Brandon Schaefer <brandontschaefer@gmail.com, Brandon Schaefer <brandontschaefer@gmail.com>35 Brandon Schaefer <brandontschaefer@gmail.com, Brandon Schaefer <brandontschaefer@gmail.com>
@@ -96,9 +100,13 @@
96 Marco Trevisan (Treviño) <mail@3v1n0.net>100 Marco Trevisan (Treviño) <mail@3v1n0.net>
97 Marco Trevisan (Treviño) <mail@3v1n0.net>, 3v1n0 <mail@3v1n0.net>101 Marco Trevisan (Treviño) <mail@3v1n0.net>, 3v1n0 <mail@3v1n0.net>
98 Marco Trevisan (Treviño) <mail@3v1n0.net>, Andrea Cimitan <andrea.cimitan@canonical.com>102 Marco Trevisan (Treviño) <mail@3v1n0.net>, Andrea Cimitan <andrea.cimitan@canonical.com>
103<<<<<<< TREE
99 Marco Trevisan (Treviño) <mail@3v1n0.net>, Brandon Schaefer <brandon.schaefer@canonical.com>104 Marco Trevisan (Treviño) <mail@3v1n0.net>, Brandon Schaefer <brandon.schaefer@canonical.com>
100 Marco Trevisan (Treviño) <mail@3v1n0.net>, Brandon Schaefer <brandontschaefer@gmail.com>, Tim Penhey <tim.penhey@canonical.com>105 Marco Trevisan (Treviño) <mail@3v1n0.net>, Brandon Schaefer <brandontschaefer@gmail.com>, Tim Penhey <tim.penhey@canonical.com>
101 Marco Trevisan (Treviño) <mail@3v1n0.net>, Lukas Vacek <lucas.vacek@gmail.com>106 Marco Trevisan (Treviño) <mail@3v1n0.net>, Lukas Vacek <lucas.vacek@gmail.com>
107=======
108 Marco Trevisan (Treviño) <mail@3v1n0.net>, Brandon Schaefer <brandontschaefer@gmail.com>, Tim Penhey <tim.penhey@canonical.com>
109>>>>>>> MERGE-SOURCE
102 Marco Trevisan (Treviño) <mail@3v1n0.net>, Michal Hruby <michal.mhr@gmail.com>110 Marco Trevisan (Treviño) <mail@3v1n0.net>, Michal Hruby <michal.mhr@gmail.com>
103 Marco Trevisan (Treviño) <mail@3v1n0.net>, Thomi Richards <thomi.richards@canonical.com>111 Marco Trevisan (Treviño) <mail@3v1n0.net>, Thomi Richards <thomi.richards@canonical.com>
104 Marius Gedminas <marius@gedmin.as>112 Marius Gedminas <marius@gedmin.as>
@@ -165,19 +173,28 @@
165 Thomi Richards <thomir@gmail.com>, Alex Launi <alex.launi@canonical.com>173 Thomi Richards <thomir@gmail.com>, Alex Launi <alex.launi@canonical.com>
166 Thomi Richards <thomir@gmail.com>, Thomi Richards <thomi.richards@canonical.com>174 Thomi Richards <thomir@gmail.com>, Thomi Richards <thomi.richards@canonical.com>
167 Thomi Richards <thomi.richards@canonical.com>175 Thomi Richards <thomi.richards@canonical.com>
176<<<<<<< TREE
168 Thomi Richards <thomi.richards@canonical.com>, Albert Astals <albert.astals@canonical.com>177 Thomi Richards <thomi.richards@canonical.com>, Albert Astals <albert.astals@canonical.com>
169 Thomi Richards <thomi.richards@canonical.com>, Alex Launi <alex.launi@canonical.com>178 Thomi Richards <thomi.richards@canonical.com>, Alex Launi <alex.launi@canonical.com>
170 Thomi Richards <thomi.richards@canonical.com>, Brandon Schaefer <brandon.schaefer@canonical.com>179 Thomi Richards <thomi.richards@canonical.com>, Brandon Schaefer <brandon.schaefer@canonical.com>
171 Thomi Richards <thomi.richards@canonical.com>, Brandon Schaefer <brandontschaefer@gmail.com>180 Thomi Richards <thomi.richards@canonical.com>, Brandon Schaefer <brandontschaefer@gmail.com>
172 Thomi Richards <thomi.richards@canonical.com>, Christopher Lee <chris.lee@canonical.com>181 Thomi Richards <thomi.richards@canonical.com>, Christopher Lee <chris.lee@canonical.com>
182=======
183 Thomi Richards <thomi.richards@canonical.com>, Alex Launi <alex.launi@canonical.com>
184 Thomi Richards <thomi.richards@canonical.com>, Brandon Schaefer <brandontschaefer@gmail.com>
185>>>>>>> MERGE-SOURCE
173 Thomi Richards <thomi.richards@canonical.com>, Gordon Allott <gord.allott@canonical.com>186 Thomi Richards <thomi.richards@canonical.com>, Gordon Allott <gord.allott@canonical.com>
174 Thomi Richards <thomi.richards@canonical.com>, Jason Smith <jason.smith@canonical.com>187 Thomi Richards <thomi.richards@canonical.com>, Jason Smith <jason.smith@canonical.com>
175 Thomi Richards <thomi.richards@canonical.com>, Miklos Juhasz <juhasz.miklos.1@gmail.com>188 Thomi Richards <thomi.richards@canonical.com>, Miklos Juhasz <juhasz.miklos.1@gmail.com>
176 Thomi Richards <thomi.richards@canonical.com>, Ted Gould <ted@gould.cx>189 Thomi Richards <thomi.richards@canonical.com>, Ted Gould <ted@gould.cx>
177 Thomi Richards <thomi.richards@canonical.com>, Thomi Richards <thomir@gmail.com>190 Thomi Richards <thomi.richards@canonical.com>, Thomi Richards <thomir@gmail.com>
178 Thomi Richards <thomi.richards@canonical.com>, Tim Penhey <tim.penhey@canonical.com>191 Thomi Richards <thomi.richards@canonical.com>, Tim Penhey <tim.penhey@canonical.com>
192<<<<<<< TREE
179 timo.jyrinki@canonical.com193 timo.jyrinki@canonical.com
180 Timo Jyrinki <timo.jyrinki@canonical.com>194 Timo Jyrinki <timo.jyrinki@canonical.com>
195=======
196 Timo Jyrinki <timo.jyrinki@canonical.com>
197>>>>>>> MERGE-SOURCE
181 Tim Penhey <tim.penhey@canonical.com>198 Tim Penhey <tim.penhey@canonical.com>
182 Tim Penhey <tim.penhey@canonical.com>, Bowmore <bowmores@telia.com>199 Tim Penhey <tim.penhey@canonical.com>, Bowmore <bowmores@telia.com>
183 Tim Penhey <tim.penhey@canonical.com>, Gordon Allott <gord.allott@canonical.com>200 Tim Penhey <tim.penhey@canonical.com>, Gordon Allott <gord.allott@canonical.com>
184201
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2013-07-10 17:12:02 +0000
+++ CMakeLists.txt 2013-07-24 18:20:41 +0000
@@ -8,9 +8,15 @@
8# Base bits8# Base bits
9#9#
10set (PROJECT_NAME "unity")10set (PROJECT_NAME "unity")
11<<<<<<< TREE
11set (UNITY_MAJOR 7)12set (UNITY_MAJOR 7)
12set (UNITY_MINOR 0)13set (UNITY_MINOR 0)
13set (UNITY_MICRO 2)14set (UNITY_MICRO 2)
15=======
16set (UNITY_MAJOR 5)
17set (UNITY_MINOR 20)
18set (UNITY_MICRO 0)
19>>>>>>> MERGE-SOURCE
14set (UNITY_VERSION "${UNITY_MAJOR}.${UNITY_MINOR}.${UNITY_MICRO}")20set (UNITY_VERSION "${UNITY_MAJOR}.${UNITY_MINOR}.${UNITY_MICRO}")
15set (UNITY_API_VERSION "6.0")21set (UNITY_API_VERSION "6.0")
16set (UNITY_COMPONENTS_VERSION "6")22set (UNITY_COMPONENTS_VERSION "6")
@@ -212,6 +218,7 @@
212#218#
213# Compiz Plugins219# Compiz Plugins
214#220#
221<<<<<<< TREE
215set(UNITY_PROTOCOL_PRIVATE_DEPS unity-protocol-private>=7.0.8)222set(UNITY_PROTOCOL_PRIVATE_DEPS unity-protocol-private>=7.0.8)
216set(UNITY_PLUGIN_SHARED_DEPS223set(UNITY_PLUGIN_SHARED_DEPS
217 ${UNITY_PROTOCOL_PRIVATE_DEPS}224 ${UNITY_PROTOCOL_PRIVATE_DEPS}
@@ -266,6 +273,15 @@
266 add_subdirectory(shutdown)273 add_subdirectory(shutdown)
267 add_subdirectory(unity-standalone)274 add_subdirectory(unity-standalone)
268endif ()275endif ()
276=======
277set (UNITY_PLUGIN_DEPS "compiz;nux-2.0>=2.0.0;libbamf3;dee-1.0;gio-2.0;gio-unix-2.0;dbusmenu-glib-0.4;x11;libstartup-notification-1.0;gthread-2.0;indicator3-0.4>=0.4.90;atk;unity-misc>=0.4.0;gconf-2.0;libgeis;gtk+-3.0>=3.1;sigc++-2.0;json-glib-1.0;libnotify;gnome-desktop-3.0;gdu;xfixes")
278
279add_subdirectory(plugins/unityshell)
280add_subdirectory(plugins/gtkloader)
281add_subdirectory(plugins/networkarearegion)
282add_subdirectory(plugins/unitydialog)
283add_subdirectory(plugins/unity-mt-grab-handles)
284>>>>>>> MERGE-SOURCE
269285
270# subdirs286# subdirs
271add_subdirectory(doc)287add_subdirectory(doc)
272288
=== modified file 'ChangeLog'
--- ChangeLog 2013-04-03 13:42:12 +0000
+++ ChangeLog 2013-07-24 18:20:41 +0000
@@ -1,3 +1,4 @@
1<<<<<<< TREE
12013-04-03 Stephen M. Webb <stephen.webb@canonical.com>22013-04-03 Stephen M. Webb <stephen.webb@canonical.com>
23
3 Bump the Unity version to 7.0.0.4 Bump the Unity version to 7.0.0.
@@ -31898,6 +31899,2446 @@
3189831899
31899 Release\ 5.10.031900 Release\ 5.10.0
3190031901
31902=======
319032013-04-04 Marco Trevisan (Treviño) <mail@3v1n0.net>
31904
31905 UnityWindow: properly draw the panel shadow when a Nux window is focused or during WS switch
31906
31907 If a nux window is the active one, compiz won't draw it, so the code that is doing the
31908 panelShadow drawing is excluded. We need to make sure that this will be executed
31909 also in this case.
31910
319112013-04-04 Marco Trevisan (Treviño) <mail@3v1n0.net>
31912
31913 UnityShell: paint the panel shadow only if we don't have a mask set
31914
319152013-04-04 Marco Trevisan (Treviño) <mail@3v1n0.net>
31916
31917 UnityWindow: properly draw the panel shadow when a Nux window is focused or during WS switch
31918
31919 If a nux window is the active one, compiz won't draw it, so the code that is doing the panelShadow drawing is excluded. We need to make sure that this will be executed also in this case.
31920
319212013-04-03 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
31922
31923 Partial backport of Unity trunk revno. 2901 to fix where window decorations are being drawn when they should not be (LP: #1122478) (LP: #1083186).
31924
319252013-03-18 Chris Townsend <christopher.townsend@canonical.com>
31926
31927 Fix issue whare a window created without decorations would have decorations when maximizing and minimizing the window very quicly. This fix was taken from upstream Unity.
31928
319292013-02-18 Andrea Azzarone <azzaronea@gmail.com>
31930
31931 Backport fix for 991637.
31932
31933 Merged branch lp:~andyrock/unity/fix-991637-5.0
31934
319352013-02-14 Andrea Azzarone <azzaronea@gmail.com>
31936
31937 Backport fix for 991637.
31938
319392013-01-31 Marco Trevisan (Treviño) <mail@3v1n0.net>
31940
31941 ResultRendererTile: fix a crash if row.renderer<TextureContainer*>() is null
31942
319432013-01-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
31944
31945 test_service_lens: 12.04 has not preview support, fix compilation
31946
319472013-01-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
31948
31949 ResultRendererTile: Fix compilation issue.
31950
319512013-01-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
31952
31953 merging with lp:unity/5.0
31954
319552012-07-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
31956
31957 ResultRendererTile: don't crash in LoadIcon if row.renderer<TextureContainer*>() is null
31958
319592012-12-05 Brandon Schaefer <brandon.schaefer@canonical.com>
31960
31961 Change TimeUtil to use int64, so the buffer wont overflow within our lifetimes.. Fixes: https://bugs.launchpad.net/bugs/806248. Approved by Łukasz Zemczak.
31962
319632012-12-05 Brandon Schaefer <brandon.schaefer@canonical.com>
31964
31965 * Fix header
31966
319672012-12-03 Brandon Schaefer <brandon.schaefer@canonical.com>
31968
31969 * Fix TimeUtil and int32 buffer overflow, now uses an int64
31970
319712012-11-12 Timo Jyrinki <timo.jyrinki@canonical.com>
31972
31973 Release\ 5.18.0
31974
319752012-10-18 Andrea Azzarone <azzaronea@gmail.com>
31976
31977 Use linear filtering to draw icons (when needed).. Fixes: https://bugs.launchpad.net/bugs/1036231. Approved by Marco Trevisan (Treviño).
31978
319792012-10-17 Andrea Azzarone <azzaronea@gmail.com>
31980
31981 Use linear filtering to draw icons (when needed).
31982
319832012-10-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
31984
31985 BamfLauncherIcon: ensure the icon and name values when the running state changes
31986
31987 This avoids to get "?" icons. Fixes: https://bugs.launchpad.net/bugs/772986. Approved by Brandon Schaefer.
31988
319892012-10-12 Marco Trevisan (Treviño) <mail@3v1n0.net>
31990
31991 BamfLauncherIcon: ensure the icon and name values when the running state changes
31992
31993 This avoids to get "?" icons
31994
319952012-10-09 Albert Astals <albert.astals@canonical.com>
31996
31997 Do not reuse the menu entries if their order changes
31998
31999 Since the indicators api only have "add" and "remove" signals, if we reuse an entry that is not in the correct order it will case the menus or whatever this indicator represents to be in the wrong order
32000 . Fixes: https://bugs.launchpad.net/bugs/1062283. Approved by Marco Trevisan (Treviño).
32001
320022012-10-09 Albert Astals <albert.astals@canonical.com>
32003
32004 Do not reuse the menu entries if their order changes
32005
32006 Since the indicators api only have "add" and "remove" signals, if we reuse an entry that is not in the correct order it will case the menus or whatever this indicator represents to be in the wrong order
32007
320082012-10-09 Andrea Azzarone <azzaronea@gmail.com>
32009
32010 Use GMountOperation in g_volume_mount. GMountOperation provides a mechanism for interacting with the use.. Fixes: https://bugs.launchpad.net/bugs/713432. Approved by Marco Trevisan (Treviño).
32011
320122012-10-02 Andrea Azzarone <azzaronea@gmail.com>
32013
32014 Use GMountOperation in g_volume_mount. GMountOperation provides a mechanism for interacting with the use.
32015
320162012-10-05 Brandon Schaefer <brandon.schaefer@canonical.com>
32017
32018 If no icon is found then use the default one. This will cause all blank icons to be a '?' icon.. Fixes: https://bugs.launchpad.net/bugs/886778. Approved by Marco Trevisan (Treviño).
32019
320202012-09-21 Brandon Schaefer <brandon.schaefer@canonical.com>
32021
32022 * If no icon is found, then use the default one.
32023
320242012-10-05 Brandon Schaefer <brandon.schaefer@canonical.com>
32025
32026 Fixes alt+tab losing focus when alt+tabing to quickly due to ubus being to slow to send a message.. Fixes: https://bugs.launchpad.net/bugs/1035628. Approved by Marco Trevisan (Treviño).
32027
320282012-09-26 Brandon Schaefer <brandon.schaefer@canonical.com>
32029
32030 * added manual test
32031
320322012-09-25 Brandon Schaefer <brandon.schaefer@canonical.com>
32033
32034 * Fixes alt+tab focus issues
32035
320362012-10-03 Albert Astals <albert.astals@canonical.com>
32037
32038 Ignore transient unmmaped windows on minimize/unminimize
32039
32040 Doesn't make much sense since they are not shown and it confuses Qt code. Fixes: https://bugs.launchpad.net/bugs/929712. Approved by Marco Trevisan (Treviño).
32041
320422012-10-03 Albert Astals <albert.astals@canonical.com>
32043
32044 Cherry-picked 2786: Ignore transient unmmaped windows on minimize/unminimize
32045
32046 Doesn't make much sense since they are not shown and it confuses Qt code.
32047
320482012-09-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32049
32050 Launcher: start the drag icon request from the original mouse-down position.. Fixes: https://bugs.launchpad.net/bugs/858540. Approved by Andrea Azzarone, Tim Penhey.
32051
320522012-08-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
32053
32054 manual-test: Launcher, added test about dragging launcher icons
32055
320562012-08-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
32057
32058 Launcher: start the drag icon request from the original mouse-down position.
32059
320602012-09-11 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32061
32062 Release\ 5.16.0
32063
320642012-09-10 Francis Ginther <francis.ginther@canonical.com>
32065
32066 Updates dependency on the renamed libgeis.. Fixes: . Approved by Sam Spilsbury.
32067
320682012-08-23 Francis Ginther <francis.ginther@canonical.com>
32069
32070 Update dependency on the renamed libgeis.
32071
320722012-08-22 Andrea Azzarone <azzaronea@gmail.com>
32073
32074 Backport lp:~andyrock/unity/fix-1035951. Fixes: https://bugs.launchpad.net/bugs/1035951. Approved by Łukasz Zemczak.
32075
320762012-08-20 Andrea Azzarone <azzaronea@gmail.com>
32077
32078 Backport lp:~andyrock/unity/fix-1035951.
32079
320802012-08-21 Brandon Schaefer <brandontschaefer@gmail.com>
32081
32082 The switcher in detail mode will now focus the last active window, instead of the current one. If the current focus window activated the switcher.. Fixes: https://bugs.launchpad.net/bugs/1035668. Approved by Tim Penhey.
32083
320842012-08-15 Brandon Schaefer <brandontschaefer@gmail.com>
32085
32086 * Fixed doc string
32087
320882012-08-15 Brandon Schaefer <brandontschaefer@gmail.com>
32089
32090 * more fixes
32091
320922012-08-15 Brandon Schaefer <brandontschaefer@gmail.com>
32093
32094 * ugg more typos
32095
320962012-08-15 Brandon Schaefer <brandontschaefer@gmail.com>
32097
32098 * fixed AP test
32099
321002012-08-15 Brandon Schaefer <brandontschaefer@gmail.com>
32101
32102 * Fixed tpyo
32103
321042012-08-15 Brandon Schaefer <brandontschaefer@gmail.com>
32105
32106 * Fixes Alt+` not switching to last active window
32107
321082012-08-21 Omer Akram <om26er@ubuntu.com>
32109
32110 Fix lensbar indicator to not appear if using alt-f2. thx Nicolas. Fixes: https://bugs.launchpad.net/bugs/998752. Approved by Andrea Azzarone, Tim Penhey.
32111
321122012-08-09 Omer Akram <om26er@ubuntu.com>
32113
32114 backport fix for lp:998752 to P
32115
321162012-08-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
32117
32118 unityshell: correctly damage the LauncherDragWindow region. Fixes: https://bugs.launchpad.net/bugs/1026247, https://bugs.launchpad.net/bugs/1032700. Approved by Brandon Schaefer, Andrea Azzarone.
32119
321202012-08-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
32121
32122 Launcher: ooops, removed the LauncherDragWindow type...
32123
321242012-08-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
32125
32126 Launcher: don't return a temporary
32127
321282012-08-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
32129
32130 Launcher: use ObjectPtr for _drag_window
32131
321322012-08-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
32133
32134 unityshell: correctly damage the LauncherDragWindow region
32135
321362012-08-03 Andrea Azzarone <azzaronea@gmail.com>
32137
32138 Backport lp:~andyrock/unity/fix-987223. Fixes: https://bugs.launchpad.net/bugs/987223. Approved by Marco Trevisan (Treviño).
32139
321402012-08-03 Andrea Azzarone <azzaronea@gmail.com>
32141
32142 Backport fix for 987223.
32143
321442012-08-03 Marco Trevisan (Treviño) <mail@3v1n0.net>
32145
32146 unityshell: fix the nvidia crash on glDrawArrays disabling/enabling the client state on nuxPrologue/Epilogue (LP: #982626) (LP: #1031554). Fixes: https://bugs.launchpad.net/bugs/982626, https://bugs.launchpad.net/bugs/1031554. Approved by Daniel van Vugt, Sam Spilsbury.
32147
321482012-08-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
32149
32150 Ooops, remove badly committed changes
32151
321522012-08-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
32153
32154 unityshell: fix the nvidia crash on glDrawArrays disabling/enabling the client state on nuxPrologue/Epilogue
32155
321562012-08-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
32157
32158 Merge with duflu branch
32159
321602012-08-02 Daniel van Vugt <daniel.van.vugt@canonical.com>
32161
32162 Backport the fixes for regional damage, and the regressions that were introduced by it.
32163 Fixes lots of bugs.. Fixes: https://bugs.launchpad.net/bugs/734908, https://bugs.launchpad.net/bugs/865006, https://bugs.launchpad.net/bugs/874230, https://bugs.launchpad.net/bugs/874619, https://bugs.launchpad.net/bugs/886605, https://bugs.launchpad.net/bugs/915265, https://bugs.launchpad.net/bugs/967112, https://bugs.launchpad.net/bugs/988079, https://bugs.launchpad.net/bugs/992516, https://bugs.launchpad.net/bugs/1016430. Approved by Łukasz Zemczak, Marco Trevisan (Treviño), Daniel van Vugt.
32164
321652012-07-26 Daniel van Vugt <daniel.van.vugt@canonical.com>
32166
32167 Cherry-pick fix for bug #1024459 from lp:unity r2504.
32168
321692012-07-26 Daniel van Vugt <daniel.van.vugt@canonical.com>
32170
32171 Cherry-pick fix for bug #1024911 from lp:unity r2503.
32172
321732012-07-26 Daniel van Vugt <daniel.van.vugt@canonical.com>
32174
32175 Cherry-pick fix for bug #1021665 and #874230 from lp:unity r2478.
32176
321772012-07-26 Daniel van Vugt <daniel.van.vugt@canonical.com>
32178
32179 Cherry-pick fix for bug #1021541 from lp:unity r2473.
32180
321812012-07-26 Daniel van Vugt <daniel.van.vugt@canonical.com>
32182
32183 Cherry-pick fix for bug #1021549 from lp:unity r2472.
32184
321852012-07-26 Daniel van Vugt <daniel.van.vugt@canonical.com>
32186
32187 Cherry-pick regional-damage fix for bug #988079 from lp:unity r2470.
32188
321892012-07-26 Daniel van Vugt <daniel.van.vugt@canonical.com>
32190
32191 Cherry-pick fix for bug #865006 from lp:unity r2410.
32192
321932012-07-27 Marco Trevisan (Treviño) <mail@3v1n0.net>
32194
32195 LauncherController: Rewritten EnsureLaunchers() added tests, fix a crash caused by invalid barrier subscriptions.. Fixes: https://bugs.launchpad.net/bugs/1020075. Approved by Andrea Azzarone.
32196
321972012-07-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32198
32199 EdgeBarrierController: use auto const&
32200
322012012-07-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32202
32203 Backport lp:~3v1n0/unity/launcher-controller-ensure-new
32204
322052012-07-19 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32206
32207 Release\ 5.14.0
32208
322092012-07-18 Gary Lasker <gary.lasker@canonical.com>
32210
32211 manual-tests/SoftwareCenter.txt: added tests for Ubuntu Software Center/Unity launcher integration feature. Fixes: . Approved by Marco Trevisan (Treviño), Brandon Schaefer, Christopher Lee.
32212
322132012-07-12 Gary Lasker <gary.lasker@canonical.com>
32214
32215 clarify the steps for selecting a game (many thanks Christopher Lee)
32216
322172012-07-10 Gary Lasker <gary.lasker@canonical.com>
32218
32219 targeted to the 5.0 series branch, update Unity launcher Software Center integration manual tests and provide additional important test cases to thoroughly test the full set of integration details, including all of the bug fixes for Unity branch https://code.launchpad.net/~bilalakhtar/unity/5.0series-sru-software-center-integration-fixes/+merge/110214 and the corresponding Software Center branch https://code.launchpad.net/~gary-lasker/software-center/unity-launcher-integration-fixes
32220
322212012-07-17 Andrea Azzarone <azzaronea@gmail.com>
32222
32223 Backport lp:~thomir/unity/fix-for-754565. Fixes: https://bugs.launchpad.net/bugs/754565. Approved by Marco Trevisan (Treviño).
32224
322252012-07-16 Andrea Azzarone <azzaronea@gmail.com>
32226
32227 Minor changes.
32228
322292012-07-16 Andrea Azzarone <azzaronea@gmail.com>
32230
32231 Backport AP test.
32232
322332012-07-16 Andrea Azzarone <azzaronea@gmail.com>
32234
32235 Backport lp:~yeganeh/unity/fix-for-754565.
32236
322372011-09-30 Zaid Yeganeh <zaid.yeganeh@gmail.com>
32238
32239 [unityshell] Added key modifier/flags to the mouse events of launcher icons, and added logic for shift+click = new instance
32240
32241 modified:
32242 plugins/unityshell/src/AbstractLauncherIcon.h
32243 - Added flags to the mouse events
32244
32245 plugins/unityshell/src/Launcher.cpp
32246 - Pass through key flags to launcher icons
32247
32248 plugins/unityshell/src/LauncherIcon.cpp
32249 - Logic added for shift click based on flag state
32250
32251 plugins/unityshell/src/LauncherIcon.h
32252 plugins/unityshell/src/SimpleLauncherIcon.cpp
32253 plugins/unityshell/src/SimpleLauncherIcon.h
32254 - Changed interfaces based on the AbstractLauncherIcon
32255
322562012-07-17 Bilal Akhtar <bilalakhtar@ubuntu.com>
32257
32258 SoftwareCenterLauncherIcon: avoid the "Waiting to Install" tooltip to stay after installation
32259
32260 Be consistent with auto-hiding launcher.. Fixes: https://bugs.launchpad.net/bugs/925014, https://bugs.launchpad.net/bugs/1002440, https://bugs.launchpad.net/bugs/1012896. Approved by Marco Trevisan (Treviño), Brandon Schaefer, Thomi Richards.
32261
322622012-06-27 Bilal Akhtar <bilalakhtar@ubuntu.com>
32263
32264 Merge from 5.0 branch
32265
322662012-06-27 Bilal Akhtar <bilalakhtar@ubuntu.com>
32267
32268 Added test, need to probably fix it though
32269
322702012-06-20 Bilal Akhtar <bilalakhtar@ubuntu.com>
32271
32272 Fix urgent quirk after installation of paid app
32273
322742012-06-17 Bilal Akhtar <bilalakhtar@ubuntu.com>
32275
32276 Fixed string comparison, thanks Tim
32277
322782012-06-13 Bilal Akhtar <bilalakhtar@ubuntu.com>
32279
32280 Fix the delay in adding launcher icons to the launcher by ensuring a redraw takes place (bug #1012896) and also fix the string comparison of desktop file with software-center-agent.
32281
322822012-06-13 Bilal Akhtar <bilalakhtar@ubuntu.com>
32283
32284 Fix bug #925014 on the Unity side. Check if an aptdaemon task was specified. If not, then the icon tooltip will stay the same (i.e. the app name, rather than Waiting to install)
32285
322862012-06-13 Bilal Akhtar <bilalakhtar@ubuntu.com>
32287
32288 Fix bug #1002440, by not creating SC launcher icon if the desktop file was unspecified or set to SC's agent, as in the case of paid apps. Instead, the icon will be added at the end of the install
32289
322902012-07-17 Andrea Azzarone <azzaronea@gmail.com>
32291
32292 Backport lp:~andyrock/unity/fix-987955. Fixes: https://bugs.launchpad.net/bugs/987955. Approved by Marco Trevisan (Treviño).
32293
322942012-07-03 Andrea Azzarone <azzaronea@gmail.com>
32295
32296 Backport lp:~andyrock/unity/fix-987955.
32297
322982012-07-16 Brandon Schaefer <brandontschaefer@gmail.com>
32299
32300 Scale mode now does not skip the first super to open the dash.. Fixes: https://bugs.launchpad.net/bugs/1023811. Approved by Marco Trevisan (Treviño).
32301
323022012-07-13 Brandon Schaefer <brandontschaefer@gmail.com>
32303
32304 * fixes launcher -> scale mode -> dash problem
32305
323062012-07-13 Andrea Azzarone <azzaronea@gmail.com>
32307
32308 Backport lp:~andyrock/unity/fix-772445. Fixes: https://bugs.launchpad.net/bugs/772445. Approved by Marco Trevisan (Treviño).
32309
323102012-07-13 Andrea Azzarone <azzaronea@gmail.com>
32311
32312 Minor changes.
32313
323142012-07-13 Andrea Azzarone <azzaronea@gmail.com>
32315
32316 Merge trunk.
32317
323182012-07-13 Andrea Azzarone <azzaronea@gmail.com>
32319
32320 Backport lp:~andyrock/unity/fix-772445
32321
323222012-07-13 Andrea Azzarone <azzaronea@gmail.com>
32323
32324 Backport branch lp:~andyrock/unity/fix-839717. Fixes: https://bugs.launchpad.net/bugs/839717. Approved by Marco Trevisan (Treviño).
32325
323262012-07-13 Andrea Azzarone <azzaronea@gmail.com>
32327
32328 Backport lp:~andyrock/unity/fix-839717.
32329
323302012-07-09 Marco Trevisan (Treviño) <mail@3v1n0.net>
32331
32332 KeyboardUtil: fix possible crash if XkbGetKeyboard returns null
32333
32334 Also use initializer list. Fixes: https://bugs.launchpad.net/bugs/920258. Approved by Gord Allott.
32335
323362012-07-06 Marco Trevisan (Treviño) <mail@3v1n0.net>
32337
32338 KeyboardUtil: fix typo
32339
323402012-07-06 Marco Trevisan (Treviño) <mail@3v1n0.net>
32341
32342 KeyboardUtil: oops, fix return value.
32343
323442012-07-06 Marco Trevisan (Treviño) <mail@3v1n0.net>
32345
32346 KeyboardUtil: fix possible crash if XkbGetKeyboard returns null
32347
32348 Also use initializer list
32349
323502012-07-04 Andrea Azzarone <azzaronea@gmail.com>
32351
32352 Backport lp:~andyrock/unity/fix-932531. Fixes: https://bugs.launchpad.net/bugs/932531. Approved by Tim Penhey.
32353
323542012-07-03 Andrea Azzarone <azzaronea@gmail.com>
32355
32356 Backport lp:~andyrock/unity/fix-932531.
32357
323582012-07-04 Andrea Azzarone <azzaronea@gmail.com>
32359
32360 Backport lp:~andyrock/unity/fix-bug-955158. Fixes: https://bugs.launchpad.net/bugs/955158. Approved by Tim Penhey.
32361
323622012-07-04 Andrea Azzarone <azzaronea@gmail.com>
32363
32364 Remove default_item_layout/list.
32365
323662012-07-03 Andrea Azzarone <azzaronea@gmail.com>
32367
32368 Backport lp:~andyrock/unity/fix-bug-955158.
32369
323702012-07-03 Andrea Azzarone <azzaronea@gmail.com>
32371
32372 Backport lp:~andyrock/unity/fix-934062. Fixes: https://bugs.launchpad.net/bugs/934062. Approved by Marco Trevisan (Treviño).
32373
323742012-07-03 Andrea Azzarone <azzaronea@gmail.com>
32375
32376 Backport lp:~andyrock/unity/fix-934062.
32377
323782012-07-02 Andrea Azzarone <azzaronea@gmail.com>
32379
32380 Backport lp:~andyrock/unity/fix-851982.. Fixes: https://bugs.launchpad.net/bugs/851982. Approved by Brandon Schaefer.
32381
323822012-07-02 Andrea Azzarone <azzaronea@gmail.com>
32383
32384 Backport lp:~andyrock/unity/fix-851982
32385
323862012-06-29 Marco Trevisan (Treviño) <mail@3v1n0.net>
32387
32388 PluginAdapterCompiz: ignore offscreen windows when looking for the top one. Fixes: https://bugs.launchpad.net/bugs/996604. Approved by Brandon Schaefer.
32389
323902012-06-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
32391
32392 test_launcher: add autopilot test to check spread initialization on double click
32393
323942012-06-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
32395
32396 PluginAdapterCompiz: ignore offscreen windows when looking for the top one
32397
323982012-06-29 Didier Roche <didier.roche@canonical.com>
32399
32400 Fix a crash when a GError exception is triggered. Fixes: https://bugs.launchpad.net/bugs/778470. Approved by Sam Spilsbury.
32401
324022012-06-28 Didier Roche <didier.roche@canonical.com>
32403
32404 import glib for handling the GError (LP: #778470)
32405
324062012-06-28 Marco Trevisan (Treviño) <mail@3v1n0.net>
32407
32408 DashView: filter out the unprintable keys when focusing the search bar
32409
32410 The search bar can't be focused when invalid keys (such as shift, ctrl, F1...) are pressed.. Fixes: https://bugs.launchpad.net/bugs/931393. Approved by Andrea Azzarone.
32411
324122012-06-28 Marco Trevisan (Treviño) <mail@3v1n0.net>
32413
32414 DashView: filter out the unprintable keys when focusing the search bar
32415
32416 The search bar can't be focused when invalid keys (such as shift, ctrl, F1...) are pressed...
32417
324182012-06-28 Andrea Azzarone <azzaronea@gmail.com>
32419
32420 Backport lp:~andyrock/unity/fix-1016239. Fixes: https://bugs.launchpad.net/bugs/1016239. Approved by Marco Trevisan (Treviño).
32421
324222012-06-27 Andrea Azzarone <azzaronea@gmail.com>
32423
32424 Backport lp:~andyrock/unity/fix-1016239
32425
324262012-06-27 Brandon Schaefer <brandontschaefer@gmail.com>
32427
32428 The dash will now open when invoked while in spread/scale mode.. Fixes: https://bugs.launchpad.net/bugs/944033. Approved by Thomi Richards.
32429
324302012-06-26 Brandon Schaefer <brandontschaefer@gmail.com>
32431
32432 * Fixes opening the dash when in scale mode
32433
324342012-06-25 Brandon Schaefer <brandontschaefer@gmail.com>
32435
32436 The switcher now focuses it's own window, instead of leaving it to the current one. Now Alt+F4 does not work while the switcher is active.. Fixes: . Approved by Thomi Richards.
32437
324382012-06-25 Brandon Schaefer <brandontschaefer@gmail.com>
32439
32440 * SRU fix for alt+f4 re opening a program while using the switcher.
32441
324422012-06-25 Brandon Schaefer <brandontschaefer@gmail.com>
32443
32444 Fixes closing the shurnk Hud when clicking outside it's geometry.. Fixes: https://bugs.launchpad.net/bugs/962651. Approved by Thomi Richards.
32445
324462012-06-25 Brandon Schaefer <brandontschaefer@gmail.com>
32447
32448 * switched close and it...
32449
324502012-06-25 Brandon Schaefer <brandontschaefer@gmail.com>
32451
32452 * ap and minor fixes
32453
324542012-06-22 Brandon Schaefer <brandontschaefer@gmail.com>
32455
32456 * Hud will close when clicking anywhere outside of it's current geo (including being shrunk)
32457
324582012-06-25 Andrea Azzarone <azzaronea@gmail.com>
32459
32460 Backport lp:~andyrock/unity/fix-994163. Fixes: https://bugs.launchpad.net/bugs/994163. Approved by Łukasz Zemczak.
32461
324622012-06-22 Andrea Azzarone <azzaronea@gmail.com>
32463
32464 Backport lp:~andyrock/unity/fix-994163.
32465
324662012-06-22 Brandon Schaefer <brandontschaefer@gmail.com>
32467
32468 Fixes AP test, get_compiz_option wasn't included in utilities.. Fixes: . Approved by Thomi Richards.
32469
324702012-06-21 Brandon Schaefer <brandontschaefer@gmail.com>
32471
32472 * fixes ap test get_compiz_option wasn't in 5.0
32473
324742012-06-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
32475
32476 IMTextEntry: don't ingore ctrl/alt keypress to make ibus still working. Fixes: . Approved by Brandon Schaefer.
32477
324782012-06-22 Marco Trevisan (Treviño) <mail@3v1n0.net>
32479
32480 IMTextEntry: don't ingore ctrl/alt keypress to make ibus still working
32481
324822012-06-21 Brandon Schaefer <brandontschaefer@gmail.com>
32483
32484 Fixes focus problem when entering expo mode from KeyNav(Alt+F1).. Fixes: https://bugs.launchpad.net/bugs/962408. Approved by Marco Trevisan (Treviño).
32485
324862012-06-21 Brandon Schaefer <brandontschaefer@gmail.com>
32487
32488 * Fixes going into expo mode from key nav mode (alt+f1)
32489
324902012-06-21 Brandon Schaefer <brandontschaefer@gmail.com>
32491
32492 Documents and files now dragged from the Dash to the Launcher into an application will close the dash.. Fixes: https://bugs.launchpad.net/bugs/865168. Approved by Marco Trevisan (Treviño).
32493
324942012-06-21 Brandon Schaefer <brandontschaefer@gmail.com>
32495
32496 * Dragging documents and files to an app on the launcher closes the dash.
32497
324982012-06-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
32499
32500 IMTextEntry: ignore invalid keypress when using modifiers keys.
32501
32502 All the key pressure when pressing the Alt or Super key should be ignored.
32503 When pressing Ctrl key we should only allow: A key, arrow keys, Backspace or Delete keys and Home or Delete keys.. Fixes: https://bugs.launchpad.net/bugs/1013751. Approved by .
32504
325052012-06-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
32506
32507 test_im_text_entry: fix the IMTextEntry inclusion
32508
325092012-06-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
32510
32511 IMTextEntry: ignore invalid keypress when using modifiers keys.
32512
32513 All the key pressure when pressing the Alt or Super key should be ignored.
32514 When pressing Ctrl key we should only allow: A key, arrow keys, Backspace or
32515 Delete keys and Home or Delete keys.
32516
325172012-06-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
32518
32519 DashController / HudController: hide the overlay when the spread is initiated. Fixes: https://bugs.launchpad.net/bugs/870284. Approved by .
32520
325212012-06-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
32522
32523 autopilot, added tests for Dash and Hud on spread
32524
325252012-06-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
32526
32527 HudController: hide the HUD when the spread is initiated
32528
325292012-06-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
32530
32531 DashController: hide the dash when spread is initiated
32532
325332012-06-19 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32534
32535 Cherry-picked from unity trunk (rev2407):
32536 Launcher: Fix dragging to the last position when out of the launcher. Fixes: https://bugs.launchpad.net/bugs/971421. Approved by Marco Trevisan (Treviño).
32537
325382012-06-18 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32539
32540 Cherry-picked from unity trunk (rev2407):
32541 Launcher: Fix dragging to the last position when out of the launcher
32542
325432012-06-17 Andrea Azzarone <azzaronea@gmail.com>
32544
32545 Backport lp:~andyrock/unity/fix-987674. Fixes: https://bugs.launchpad.net/bugs/987674. Approved by Tim Penhey.
32546
325472012-06-15 Andrea Azzarone <azzaronea@gmail.com>
32548
32549 Fix bug 987674.
32550
325512012-06-17 Andrea Azzarone <azzaronea@gmail.com>
32552
32553 Backport lp:~andyrock/unity/hud-reset
32554 . Fixes: https://bugs.launchpad.net/bugs/1011507. Approved by Tim Penhey.
32555
325562012-06-15 Andrea Azzarone <azzaronea@gmail.com>
32557
32558 Add missing files.
32559
325602012-06-15 Andrea Azzarone <azzaronea@gmail.com>
32561
32562 Backport lp:~andyrock/unity/hud-reset.
32563
325642012-06-06 Andrea Azzarone <azzaronea@gmail.com>
32565
32566 Backport lp:~andyrock/unity/fix-1008656.. Fixes: https://bugs.launchpad.net/bugs/1008656. Approved by Łukasz Zemczak.
32567
325682012-06-06 Andrea Azzarone <azzaronea@gmail.com>
32569
32570 Backport lp:~andyrock/unity/fix-1008656.
32571
325722012-06-06 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32573
32574 Back-porting fix from unity trunk.
32575 When dragging a non-application, do not saturate all icons automatically, but only those that are needed.
32576
32577 Eliminates flickering before 'prelighting' the Launcher icons that can handle the current drag-and-drop (LP #863230).. Fixes: https://bugs.launchpad.net/bugs/863230. Approved by .
32578
325792012-06-06 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32580
32581 When dragging a non-application, do not saturate all icons automatically, but only those that are needed.
32582
32583 Eliminates flickering before 'prelighting' the Launcher icons that can handle the current drag-and-drop (LP #863230)
32584
325852012-06-06 Andrea Azzarone <azzaronea@gmail.com>
32586
32587 Draw the result grid in proximity of the search entry. Backport lp:~andyrock/unity/fix-1008603. Fixes: https://bugs.launchpad.net/bugs/1008603. Approved by Łukasz Zemczak.
32588
325892012-06-06 Andrea Azzarone <azzaronea@gmail.com>
32590
32591 Backport lp:~andyrock/unity/fix-1008603
32592
325932012-06-06 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32594
32595 Back-porting fix from unity trunk.
32596 Don't show the switcher window during constructing the view. Wait for the ShowView timeout.. Fixes: https://bugs.launchpad.net/bugs/987156. Approved by Tim Penhey.
32597
325982012-06-05 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32599
32600 Added two manual-tests for testing the fixed behavior. Better have everything well tested.
32601
326022012-06-05 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32603
32604 Added a unit test for the switcher show functionality. The same as in the previous proposition.
32605
326062012-06-05 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32607
32608 Don't show the switcher window during constructing the view. Wait for the show timeout.
32609
326102012-06-04 Andrea Azzarone <azzaronea@gmail.com>
32611
32612 Backports branch lp:~andyrock/unity/hud-text.. Fixes: https://bugs.launchpad.net/bugs/939436. Approved by Tim Penhey.
32613
326142012-05-31 Andrea Azzarone <azzaronea@gmail.com>
32615
32616 Backport lp:~andyrock/unity/hud-text.
32617
326182012-05-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
32619
32620 BamfLauncherIcon: Unset the BamfApplication when removing the icon.
32621
32622 Doing this manually, we prevent that a duplicated application can be added between the removal of the BamfLauncherIcon and the effective destruction (that is controlled by a timeout in LauncherModel).. Fixes: https://bugs.launchpad.net/bugs/1003574. Approved by .
32623
326242012-05-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
32625
32626 LauncherController: use glib::Signal to handle the Bamf matcher signal.
32627
326282012-05-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
32629
32630 BamfLauncherIcon: Disconnect all the _bamf_app signals at once on removal.
32631
326322012-05-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
32633
32634 GLib::SignalManager: allow to disconnect all the signals for a given Object.
32635
32636 When the signal string name is empty, we disconnect all the sigals
32637 for the given object.
32638
326392012-05-24 Gord Allott <gord.allott@canonical.com>
32640
32641 * Capture information about the icon of the application to be installed from the software center. Re-use it when rendering the launcher interface.
32642 * Fix bug #981168. Fixes: https://bugs.launchpad.net/bugs/981168. Approved by Gord Allott.
32643
326442012-05-24 Gord Allott <gord.allott@canonical.com>
32645
32646 fixed up memory leaks
32647
326482012-04-17 Jay Taoko <jay.taoko@canonical.com>
32649
32650 * Capture information about the icon of the application to be installed from the software center. Re-use it when rendering the launcher interface.
32651
326522012-04-16 Jay Taoko <jay.taoko@canonical.com>
32653
32654 * Capture part of the content of Launcher::handle_dbus_method_call into a lambda call.
32655
326562012-05-23 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32657
32658 Backported andyrock's fix from lp:unity/6.0 - Unmute launcher (LP: #949448).. Fixes: https://bugs.launchpad.net/bugs/949448. Approved by Andrea Azzarone.
32659
326602012-05-23 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32661
32662 Backported andyrock's fix for LP: #949448 from lp:unity/6.0.
32663
326642012-05-23 Andrea Azzarone <azzaronea@gmail.com>
32665
32666 Backports lp:~andyrock/unity/queue-draw-result-view-grid from lp:unity/6.0.. Fixes: . Approved by Andrea Azzarone, Łukasz Zemczak.
32667
326682012-05-23 Andrea Azzarone <azzaronea@gmail.com>
32669
32670 Backports branch lp:~andyrock/unity/queue-draw-result-view-grid.
32671
326722012-05-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
32673
32674 UnityScreen: reduce the BGHash::RefreshColor() calls
32675
32676 Don't call BGHash::RefreshColor() every atom on the XRoot window changes,
32677 do it only when the target one changes. Fixes: . Approved by Andrea Azzarone.
32678
326792012-05-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
32680
32681 UnityScreen: reduce the BGHash::RefreshColor() calls
32682
32683 Don't call BGHash::RefreshColor() every atom on the XRoot window changes,
32684 do it only when the target one changes.
32685
326862012-05-23 Andrea Azzarone <azzaronea@gmail.com>
32687
32688 Backports branch lp:~vanvugt/unity/fix-987304.. Fixes: https://bugs.launchpad.net/bugs/987304. Approved by Marco Trevisan (Treviño).
32689
326902012-05-23 Andrea Azzarone <azzaronea@gmail.com>
32691
32692 Backports branch lp:~vanvugt/unity/fix-987304.
32693
326942012-05-23 Andrea Azzarone <azzaronea@gmail.com>
32695
32696 Backported fix from lp:unity/6.0 - Dash - search field is hidden by tooltips (LP: #978030).. Fixes: https://bugs.launchpad.net/bugs/978030. Approved by Andrea Azzarone, Łukasz Zemczak.
32697
326982012-05-23 Andrea Azzarone <azzaronea@gmail.com>
32699
32700 Backports branch lp:~andyrock/unity/fix-978030.
32701
327022012-04-27 Andrea Azzarone <azzaronea@gmail.com>
32703
32704 Add AP tests.
32705
327062012-04-27 Andrea Azzarone <azzaronea@gmail.com>
32707
32708 Disable the bfb/hudlaunchericon tooltip when the dash/hud is open.
32709 Hide a launcher icon tooltip as soon as the dash/hud is shown.
32710
327112012-05-23 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32712
32713 Backported andyrock's fix from trunk - fix UnityViewWindow background when blur is disabled.. Fixes: . Approved by Gord Allott.
32714
327152012-05-23 Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com>
32716
32717 Backported andyrock's fix for LP: #989291. Fix UnityViewWindow background when blur is disabled.
32718
327192012-05-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
32720
32721 Merged branches lp:~3v1n0/unity/launcher-double-icons-tests and lp:~3v1n0/unity/quick-app-reopen-icon-fix. Fixes: https://bugs.launchpad.net/bugs/772063, https://bugs.launchpad.net/bugs/995916, https://bugs.launchpad.net/bugs/999820. Approved by .
32722
327232012-05-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
32724
32725 Merging fix for "Missing GIMP icon bug"
32726
327272012-05-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
32728
32729 Merging single-icon AP tests.
32730
327312012-04-27 Didier Roche <didier.roche@canonical.com>
32732
32733 Release\ 5.12.0
32734
327352012-04-26 Sebastien Bacher <seb128@ubuntu.com>
32736
32737 Revert r2331, it's creating hang issues on start.. Fixes: . Approved by Didier Roche.
32738
327392012-04-26 Sebastien Bacher <seb128@ubuntu.com>
32740
32741 Revert r2331, it's creating hang issues on start. The commit is not fixing any
32742 important issue and not needed in the SRU, it can come once the problems have
32743 been resolved.
32744
327452012-04-26 Michael Vogt <michael.vogt@ubuntu.com>
32746
32747 Check for "exit_state" on the install-finished signal from aptdaemon (LP: #982921) and remove launcher icon again on failure.. Fixes: https://bugs.launchpad.net/bugs/982921. Approved by Tim Penhey.
32748
327492012-04-26 Michael Vogt <michael.vogt@ubuntu.com>
32750
32751 manual-tests/SoftwareCenter.txt: add manual test for the launcher integration cancel
32752
327532012-04-17 Michael Vogt <michael.vogt@ubuntu.com>
32754
32755 remove USC launcher again from unity on download/install failure or cancel
32756
327572012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32758
32759 We need to flag a bamf view that we control using an icon using the "unity-seen" qdata, or unity will duplicate it on bamfdaemon respawn. (LP: #928912). Fixes: https://bugs.launchpad.net/bugs/928912. Approved by Michal Hruby, Tim Penhey.
32760
327612012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32762
32763 autopilot, test_launcher: removed the xclock test... We'll put it back soon.
32764
327652012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32766
32767 Merging thomi's fixes
32768
327692012-04-26 Thomi Richards <thomi.richards@canonical.com>
32770
32771 Added xclock.
32772
327732012-04-26 Thomi Richards <thomi.richards@canonical.com>
32774
32775 Renamed test methods.
32776
327772012-04-26 Thomi Richards <thomi.richards@canonical.com>
32778
32779 Removed tautology from the test.
32780
327812012-04-26 Thomi Richards <thomi.richards@canonical.com>
32782
32783 CLeaned up test.
32784
327852012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32786
32787 autopilot, use kill instead of pkill to close applications
32788
327892012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32790
32791 BamfLauncherIcon: export the application ID for introspection
32792
327932012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32794
32795 autopilot, test_launcher: added test to check the launcher status after bamfdaemon killing
32796
327972012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32798
32799 LauncherController: set the "unity-seen" qdata to all the BamfApplications we have
32800
32801 This avoid that we create two icons for the same application instance.
32802 Moving to the safer GUINT...
32803
328042012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32805
32806 BamfLauncherIcon: Focus an application if no child window is actually on top of the stack. Raises all urgent windows.
32807
32808 This fixes bug #802816 that happens when an application raises a window on the top of the stack but the focus doesn't change.
32809
32810 Plus, don't perform unneeded checks when focusing non-active applications.. Fixes: https://bugs.launchpad.net/bugs/802816, https://bugs.launchpad.net/bugs/986443. Approved by Tim Penhey.
32811
328122012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32813
32814 Merging with trunk.
32815
328162012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32817
32818 manual test: updated.
32819
328202012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
32821
32822 Merge with trunk
32823
328242012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
32825
32826 manual-tests, Launcher: added a test for non top non-focused windows
32827
328282012-04-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
32829
32830 BamfLauncherIcon: raise all the urgent windows, if there are any
32831
328322012-04-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
32833
32834 BamfLauncherIcon: focus an application if no child window is actually on top of the stack.
32835
32836 This fixes bug #802816 that happens when an application raises a window on the top of the stack but the
32837 focus doesn't change.
32838
32839 Plus, don't perform unneeded checks for non-active applications.
32840
328412012-04-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
32842
32843 WindowManager: add method to get if a window is on top.
32844
32845 Top window is a window that is on top of the stack, excluding invisible, not mapped,
32846 minimized, set "above" and unity windows.
32847
328482012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32849
32850 manual-test, Launcher: added manual test for the Chromium web applications. Fixes: . Approved by Tim Penhey.
32851
328522012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32853
32854 manual-test, Launcher: added manual test for the Chromium web applications
32855
328562012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
32857
32858 BamfLauncherIcon: activate the icon using the quicklist item using an Idle.
32859
32860 This fixes the bug #986461 that caused the spread not to initiate clicking on the quicklist application name.. Fixes: https://bugs.launchpad.net/bugs/986461. Approved by Thomi Richards.
32861
328622012-04-26 Marco Trevisan (Treviño) <mail@3v1n0.net>
32863
32864 WindowManager: removed the g_debug("%s", G_STRFUNC); from AddProperties dummy implementation
32865
328662012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
32867
32868 autopilot, test_quicklist: add a test to check that spread works when initiated by quicklist
32869
328702012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
32871
32872 autopilot, keybindings: include spread keybindings
32873
328742012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
32875
32876 autopilot, add WindowManager emulator
32877
328782012-04-25 Marco Trevisan (Treviño) <mail@3v1n0.net>
32879
32880 test_quicklist: added test to check if the application label works
32881
328822012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
32883
32884 unityshell: set PluginAdapter as introspectable child
32885
328862012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
32887
32888 WindowManager: make it introspectable, implementation in PluginAdapter.
32889
328902012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
32891
32892 Merge with trunk
32893
328942012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
32895
32896 BamfLauncherIcon: remove the _quicklist_activated_id related source on destruction
32897
328982012-04-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
32899
32900 BamfLauncherIcon: activate the icon using the quicklist item using an Idle.
32901
32902 This fixes the bug #986461 that caused the spread not to initiate clicking on the quicklist
32903 application name.
32904
329052012-04-25 Michal Hruby <michal.mhr@gmail.com>
32906
32907 Fix scale inversion when processing non-rect tile textures. Fixes: https://bugs.launchpad.net/bugs/988338. Approved by Gord Allott.
32908
329092012-04-25 Michal Hruby <michal.mhr@gmail.com>
32910
32911 Fix scale inversion when processing non-rect tile textures
32912
329132012-04-25 Andrea Azzarone <azzaronea@gmail.com>
32914
32915 Don't crop the bottom of results in card view when a category is not expanded.. Fixes: https://bugs.launchpad.net/bugs/975003. Approved by Marco Trevisan (Treviño).
32916
329172012-04-25 Andrea Azzarone <azzaronea@gmail.com>
32918
32919 Fixes LP bug #975003.
32920
329212012-04-25 Michal Hruby <michal.mhr@gmail.com>
32922
32923 Destroy lens views before destroying lens models. Fixes: . Approved by Gord Allott, Sam Spilsbury.
32924
329252012-04-24 Michal Hruby <michal.mhr@gmail.com>
32926
32927 Add a comment
32928
329292012-04-24 Michal Hruby <michal.mhr@gmail.com>
32930
32931 Destroy lens views before destroying lens models
32932
329332012-04-25 Michal Hruby <michal.mhr@gmail.com>
32934
32935 Make sure hud's spinner stops spinning after hud service returns reply. Fixes: https://bugs.launchpad.net/bugs/987781. Approved by Gord Allott, Marco Trevisan (Treviño).
32936
329372012-04-24 Michal Hruby <michal.mhr@gmail.com>
32938
32939 Make sure hud's spinner stops spinning after hud service returns reply
32940
329412012-04-25 Brandon Schaefer <brandontschaefer@gmail.com>
32942
32943 Shorten the press/release time of the Ctrl+Space for the IBus AP tests.. Fixes: . Approved by Thomi Richards.
32944
329452012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
32946
32947 * Shortens the press/release time for Ctrl+Space as jenkins is a little slow
32948
329492012-04-24 Andrea Azzarone <azzaronea@gmail.com>
32950
32951 Enable dnd for all launcher icons (and not just the ones matching the type).. Fixes: https://bugs.launchpad.net/bugs/880798. Approved by Marco Trevisan (Treviño).
32952
329532012-04-25 Andrea Azzarone <azzaronea@gmail.com>
32954
32955 Fix typo.
32956
329572012-04-25 Andrea Azzarone <azzaronea@gmail.com>
32958
32959 Fixes.
32960
329612012-04-25 Andrea Azzarone <azzaronea@gmail.com>
32962
32963 Add a manual test.
32964
329652012-04-25 Andrea Azzarone <azzaronea@gmail.com>
32966
32967 Fixes bug #880798.
32968
329692012-04-24 Andrea Azzarone <azzaronea@gmail.com>
32970
32971 Set a shortcut for the new apps on the launcher too.. Fixes: https://bugs.launchpad.net/bugs/778499. Approved by Marco Trevisan (Treviño).
32972
329732012-04-24 Andrea Azzarone <azzaronea@gmail.com>
32974
32975 Fix.
32976
329772012-04-24 Andrea Azzarone <azzaronea@gmail.com>
32978
32979 Merge trunk.
32980
329812012-04-23 Andrea Azzarone <azzaronea@gmail.com>
32982
32983 Adds AP test.
32984
329852012-04-23 Andrea Azzarone <azzaronea@gmail.com>
32986
32987 Fixes bug #778499.
32988
329892012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
32990
32991 DeviceLauncherSection: updated to use glib::SignalManager and glib::Object
32992
32993 This allow to be more safe; it fixes also some crashes caused by the fact that DeviceLauncherIcon didn't own the GVolume* object. Now it uses glib::Object completely, so we can automagically ref/unref the volume when the icon is created/removed.. Fixes: https://bugs.launchpad.net/bugs/918548, https://bugs.launchpad.net/bugs/977762. Approved by Andrea Azzarone.
32994
329952012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
32996
32997 DeviceLauncherSection: use glib::SignalManager
32998
329992012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
33000
33001 DeviceLauncherIcon: use a glib::Object to handle the volume.
33002
33003 So we can be safe about reference. This will automagically add
33004 and remove a reference when needed.
33005
330062012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
33007
33008 UnityScreen: use smart_pointers correctly, destruct items in correct order. Fixes: https://bugs.launchpad.net/bugs/987932. Approved by Marco Trevisan (Treviño).
33009
330102012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
33011
33012 * Remove useless namespace
33013
330142012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
33015
33016 * Fixed spacing issue
33017
330182012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
33019
33020 * Some fixes, also added some comments about the ordering (was causing the crashes)
33021
330222012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
33023
33024 * Changed WindowThread to use a unique ptr
33025 * Also fixed a memory leak with the debugger
33026 * Some cleaning up also
33027 * Thanks Treviño for the information :)
33028
330292012-04-24 Brandon Schaefer <brandontschaefer@gmail.com>
33030
33031 UnityScreen: destroy the controllers before the window thread
33032
33033 Fixes crashes enabling/disabling plugins in CCSM. Fixes: https://bugs.launchpad.net/bugs/931201, https://bugs.launchpad.net/bugs/942286, https://bugs.launchpad.net/bugs/947844, https://bugs.launchpad.net/bugs/952378. Approved by Marco Trevisan (Treviño).
33034
330352012-04-23 Brandon Schaefer <brandontschaefer@gmail.com>
33036
33037 * Fixes some crashes with the ccsm and plugins
33038 * There still seems to be a crash, but it looks to be in bamf
33039
330402012-04-24 Michal Hruby <michal.mhr@gmail.com>
33041
33042 GLibDBusProxy: Remove 1 second timeout we used before connecting to dbus proxies. Fixes: . Approved by Marco Trevisan (Treviño).
33043
330442012-04-24 Michal Hruby <michal.mhr@gmail.com>
33045
33046 Remove 1 second timeout we used before connecting to dbus proxies
33047
330482012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
33049
33050 HudLauncherIcon: close the HUD when activating the icon
33051
33052 As design requested in bug #963918. Fixes: https://bugs.launchpad.net/bugs/963918. Approved by Gord Allott.
33053
330542012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
33055
33056 HudLauncherIcon: removed unneeded space.
33057
330582012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
33059
33060 autopilot, test_hud: add test to check if clicking over the HUD icon closes it.
33061
330622012-04-24 Marco Trevisan (Treviño) <mail@3v1n0.net>
33063
33064 HudLauncherIcon: close the HUD when activating the icon
33065
33066 As design requested in bug #963918
33067
330682012-04-24 smspillaz <sam.spilsbury@canonical.com>
33069
33070 See Bug 880449 : Minimized windows were being considered for showdesktop and had their input shape removed twice.
33071
33072 1) Never allow different entities to fight over the input shape of the window. Have one shared interface between them with RAII semantics
33073 2) Don't allow minimized windows to enter showdesktop mode. Fixes: . Approved by Gord Allott.
33074
330752012-04-23 smspillaz <sam.spilsbury@canonical.com>
33076
33077 Fix style, use <memory>
33078
330792012-04-18 smspillaz <sam.spilsbury@canonical.com>
33080
33081 Don't showdesktop minimized windows
33082
330832012-04-18 smspillaz <sam.spilsbury@canonical.com>
33084
33085 Make the minimize handler use the same mechanism
33086
330872012-04-18 smspillaz <sam.spilsbury@canonical.com>
33088
33089 Acquire input shape removal through RAII semantics
33090
330912012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
33092
33093 Hud: update the icon size to match the launcher icon size when in auto-hide mode
33094
33095 Plus prevent a couple of crashes. Fixes: https://bugs.launchpad.net/bugs/921506, https://bugs.launchpad.net/bugs/983646. Approved by Tim Penhey.
33096
330972012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
33098
33099 HudView: Set the minimum icon height to match the content_layout
33100
33101 So the icon is vertically centered to the hud search (minimal) layout if needed.
33102
331032012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
33104
33105 HudIcon: use unsigned integer for padding.
33106
331072012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
33108
33109 HudView: remove space
33110
331112012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
33112
33113 HudIcon: Fix the icon position to be relative to size, add a minimum vertical padding
33114
33115 This makes the icon draw correctly when it's big, also it makes the view to increas its
33116 vertical size slightly to use some padding if needed.
33117
331182012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
33119
33120 HudView: fix the geometry not to change when the icon size changes
33121
331222012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
33123
33124 HudController: add SetIcon function that removes some code duplication
33125
331262012-04-23 Marco Trevisan (Treviño) <mail@3v1n0.net>
33127
33128 IconTexture: be more safe when handling _pixbuf_cached
33129
33130 Set it to null when invalid and during initialization
33131
331322012-04-22 Marco Trevisan (Treviño) <mail@3v1n0.net>
33133
33134 Merging with trunk (window button fixes)
33135
331362012-04-22 Marco Trevisan (Treviño) <mail@3v1n0.net>
33137
33138 Merging with trunk
33139
331402012-04-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
33141
33142 Hud: update the icon size to match the launcher icon size.
33143
331442012-04-01 Marco Trevisan (Treviño) <mail@3v1n0.net>
33145
33146 Merging with icon fixes branch
33147
331482012-04-23 Andrea Azzarone <azzaronea@gmail.com>
33149
33150 Use 2 columns in the card view in desktop mode when filters are opened.. Fixes: https://bugs.launchpad.net/bugs/977817. Approved by Mirco Müller, Marco Trevisan (Treviño), Andrea Cimitan.
33151
331522012-04-20 Andrea Azzarone <azzaronea@gmail.com>
33153
33154 Fix bug #977817.
33155
331562012-04-20 Andrea Azzarone <azzaronea@gmail.com>
33157
33158 Merge trunk.
33159
331602012-04-21 Michael Rawson <michaelrawson76@gmail.com>
33161
33162 Fixes position of "show desktop" icon-LP:964073. Fixes: https://bugs.launchpad.net/bugs/964073. Approved by Marco Trevisan (Treviño).
33163
331642012-04-18 Michael Rawson <michaelrawson76@gmail.com>
33165
33166 Fixed braces
33167
331682012-04-17 Michael Rawson <michaelrawson76@gmail.com>
33169
33170 Fixed indentation
33171
331722012-04-15 Michael Rawson <michaelrawson76@gmail.com>
33173
33174 Fixed ccsm problem
33175
331762012-04-15 Michael Rawson <michaelrawson76@gmail.com>
33177
33178 Removed excess DesktopLauncherIcons()
33179
331802012-04-14 Michael Rawson <michaelrawson76@gmail.com>
33181
33182 Re-added code
33183
331842012-04-14 Michael Rawson <michaelrawson76@gmail.com>
33185
33186 Made fix more explicit-thanks Marco
33187
331882012-04-13 Michael Rawson <michaelrawson76@gmail.com>
33189
33190 Moved show desktop icon to intended position
33191
331922012-04-21 Marco Trevisan (Treviño) <mail@3v1n0.net>
33193
33194 WindowButtons: avoid to disable the Overlay close button.
33195
33196 This fixes a regression I probabily introduced (sorry).. Fixes: https://bugs.launchpad.net/bugs/986264. Approved by Andrea Azzarone.
33197
331982012-04-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
33199
33200 WindowButtons: remove extra space, and be more crash-safe
33201
332022012-04-20 Marco Trevisan (Treviño) <mail@3v1n0.net>
33203
33204 WindowButtons: avoid to disable the Overlay close button.
33205
33206 This fixes a regression I probabily introduced (sorry).
33207
332082012-04-20 Andrea Azzarone <azzaronea@gmail.com>
33209
33210 Don't activate "home.lens" during dash closing.. Fixes: https://bugs.launchpad.net/bugs/914785. Approved by Michal Hruby, Marco Trevisan (Treviño).
33211
332122012-04-20 Andrea Azzarone <azzaronea@gmail.com>
33213
33214 Merge trunk.
33215
332162012-04-20 Andrea Azzarone <azzaronea@gmail.com>
33217
33218 Don't activate the home lens during the dash closing.
33219
332202012-04-20 Thomi Richards <thomi.richards@canonical.com>
33221
33222 Update IBus tests to only set the IME once per test case class.. Fixes: . Approved by Brandon Schaefer, Thomi Richards.
33223
332242012-04-20 Thomi Richards <thomi.richards@canonical.com>
33225
33226 Use a single setUpClass method.
33227
332282012-04-20 Brandon Schaefer <brandontschaefer@gmail.com>
33229
33230 * setUpClass, not tearDownClass
33231
332322012-04-20 Brandon Schaefer <brandontschaefer@gmail.com>
33233
33234 * Removed param, as it is no longer needed
33235
332362012-04-20 Brandon Schaefer <brandontschaefer@gmail.com>
33237
33238 * Now the ibus only reset the context when it changes test engines
33239
332402012-04-19 Brandon Schaefer <brandontschaefer@gmail.com>
33241
33242 * Changed to deactivate to an explicit call
33243
332442012-04-20 Chase Douglas <chase.douglas@ubuntu.com>
33245
33246 Fix potential pointer lockup on initial drag gesture.. Fixes: https://bugs.launchpad.net/bugs/979418. Approved by Marco Trevisan (Treviño), Alex Launi.
33247
332482012-04-12 Chase Douglas <chase.douglas@ubuntu.com>
33249
33250 Add test comment
33251
332522012-04-11 Chase Douglas <chase.douglas@ubuntu.com>
33253
33254 Fix pointer locking up after three touch window drag
33255
33256 GestureEngine::EndDrag() checks if a drag gesture was performed before
33257 ungrabbing the pointer. Unfortunately, it checks if the gesture ID is
33258 non-zero, but a zero ID is valid. We don't need to check the gesture ID
33259 at all since the drag window is maintained properly.
33260
332612012-04-11 Chase Douglas <chase.douglas@ubuntu.com>
33262
33263 Add regression test for drag gesture pointer grabs not being removed
33264
332652012-04-11 Chase Douglas <chase.douglas@ubuntu.com>
33266
33267 Add grab counting in compiz screen mock
33268
332692012-04-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
33270
33271 WindowButtons: disable the close button if the controlled window is not closable
33272
33273 Added support to WindowManager to get if a window is closable and maximizable, then used the IsWindowClosable method to enable or disable the close window button.. Fixes: https://bugs.launchpad.net/bugs/981196. Approved by Thomi Richards, Brandon Schaefer.
33274
332752012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
33276
33277 manual-tests: WindowButtons, added test case for disabled close button
33278
332792012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
33280
33281 WindowButtons: disable the close button if the controlled window is not closable
33282
332832012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
33284
33285 WindowManager: add functions to get if a window is maximizable and closable
33286
332872012-04-19 Thomi Richards <thomi.richards@canonical.com>
33288
33289 IBus autopilot tests now wait for input method context to be created before typing characters.. Fixes: . Approved by Brandon Schaefer.
33290
332912012-04-20 Thomi Richards <thomi.richards@canonical.com>
33292
33293 ibus tests now wait for ibus to be activated in the target widget. This removes the need for sleep statements alltogether.
33294
332952012-04-20 Thomi Richards <thomi.richards@canonical.com>
33296
33297 IBus tests now wait until the im_active property on the SearchBar is set to true.
33298
332992012-04-20 Thomi Richards <thomi.richards@canonical.com>
33300
33301 First pass at fixing the ibus tests.
33302
333032012-04-20 Thomi Richards <thomi.richards@canonical.com>
33304
33305 Merged launcher tests fix, needed by this branch.
33306
333072012-04-19 Andrea Azzarone <azzaronea@gmail.com>
33308
33309 Add a sanity check to avoid crashes.. Fixes: https://bugs.launchpad.net/bugs/982730. Approved by Marco Trevisan (Treviño).
33310
333112012-04-20 Andrea Azzarone <azzaronea@gmail.com>
33312
33313 Adds a sanity check to avoid crashes.
33314
333152012-04-19 Thomi Richards <thomi.richards@canonical.com>
33316
33317 Fixes autopilot launcher test.. Fixes: . Approved by Alex Launi.
33318
333192012-04-20 Thomi Richards <thomi.richards@canonical.com>
33320
33321 Fixed launcher emulator and tests.
33322
333232012-04-19 Michal Hruby <michal.mhr@gmail.com>
33324
33325 Finetune priorities when updating dash results, prevents flickering. Fixes: https://bugs.launchpad.net/bugs/961979. Approved by Gord Allott.
33326
333272012-04-19 Michal Hruby <michal.mhr@gmail.com>
33328
33329 Finetune priorities when updating dash results, prevents flickering
33330
333312012-04-19 Thomi Richards <thomi.richards@canonical.com>
33332
33333 Shortcut hint tests now all pass.. Fixes: . Approved by Alex Launi.
33334
333352012-04-19 Thomi Richards <thomi.richards@canonical.com>
33336
33337 Fixed shortcut hint tests, cleaned up the shortcut hint controller, and made tests use the new Eventually() matcher, which eliminates the need for many sleep() statements.
33338
333392012-04-19 Thomi Richards <thomi.richards@canonical.com>
33340
33341 Fixed two failing tests.
33342
333432012-04-19 Thomi Richards <thomi.richards@canonical.com>
33344
33345 Improve autopilot assertion messages inside the new wait_for method.. Fixes: . Approved by Alex Launi.
33346
333472012-04-19 Thomi Richards <thomi.richards@canonical.com>
33348
33349 Autopilot wait_for assertions have a slightly better error message.
33350
333512012-04-19 Thomi Richards <thomi.richards@canonical.com>
33352
33353 Fixed failing panel autopilot tests.. Fixes: . Approved by Brandon Schaefer.
33354
333552012-04-19 Thomi Richards <thomi.richards@canonical.com>
33356
33357 Fixed two failing panel tests.
33358
333592012-04-19 Brandon Schaefer <brandontschaefer@gmail.com>
33360
33361 HudIcon now filters out windows on different workspaces and windows that are hidden.. Fixes: . Approved by Marco Trevisan (Treviño).
33362
333632012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33364
33365 * changed xid back to a 0, not a pointer
33366
333672012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33368
33369 * Fixed ap test
33370 * Uses nullptr now
33371
333722012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33373
33374 * remove debug include
33375
333762012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33377
33378 * Fixed the ? icon appearing.
33379
333802012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33381
33382 * Added ap test
33383
333842012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33385
33386 * Now the hud filters out windows on different workspaces for the HudIcon.
33387
333882012-04-19 Thomi Richards <thomi.richards@canonical.com>
33389
33390 Fixed a failing test in the command_lens test suite.. Fixes: . Approved by Brandon Schaefer.
33391
333922012-04-19 Thomi Richards <thomi.richards@canonical.com>
33393
33394 Fixed a failing command lens test. Somehow the assertion got inverted in the porting process.
33395
333962012-04-18 Thomi Richards <thomi.richards@canonical.com>
33397
33398 Hud autopilot tests use the new Eventually autopilot matcher to reduce the number of test failures due to timing issues.. Fixes: . Approved by Thomi Richards.
33399
334002012-04-19 Thomi Richards <thomi.richards@canonical.com>
33401
33402 Merged trunk, resolved conflicts.
33403
334042012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33405
33406 * Fixed indent error
33407
334082012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33409
33410 * Fixed the dash test that was removed
33411
334122012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33413
33414 * uses properties
33415
334162012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33417
33418 * merged trunk, fixed conflicts* merged trunk, fixed conflicts* merged trunk, fixed conflicts* merged trunk, fixed conflicts* merged trunk, fixed conflicts* merged trunk, fixed conflicts* merged trunk, fixed conflicts* merged trunk, fixed conflicts
33419
334202012-04-17 Brandon Schaefer <brandontschaefer@gmail.com>
33421
33422 * Fixed 2 ap fails
33423
334242012-04-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
33425
33426 QuicklistView: fixed the quicklist key navigation, to make it consistent with Gtk menus navigation.
33427
33428 The prelight of the items is now completely controlled by QuicklistView and never by QuicklistMenuItem, the children can define now when they are slectable.. Fixes: https://bugs.launchpad.net/bugs/911561, https://bugs.launchpad.net/bugs/978926, https://bugs.launchpad.net/bugs/979096. Approved by Thomi Richards.
33429
334302012-04-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
33431
33432 autopilot, test_quicklist: cyclic keynav docstring fixes
33433
334342012-04-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
33435
33436 autopilot, test_quicklist: use the Eventually matcher to avoid false-negatives
33437
334382012-04-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
33439
33440 Merging with trunk
33441
334422012-04-19 Marco Trevisan (Treviño) <mail@3v1n0.net>
33443
33444 autopilot: quicklist emulator, applying Thomi's fixes.
33445
334462012-04-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
33447
33448 autopilot, test_quicklist: docstrings updated.
33449
334502012-04-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
33451
33452 autopilot: quicklist, use only properties
33453
334542012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
33455
33456 TestQuicklistMenuitems: added GetSelectable tests
33457
334582012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
33459
33460 autopilot, quicklist: added other tests to check the cyclic key-navigation
33461
33462 Also the quicklist emulator now includes the selectable_items property
33463
334642012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
33465
33466 autopilot, quicklist: use the new selectable item property instead of computing it
33467
334682012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
33469
33470 QuicklistMenuItem: add GetSelectable virtual method
33471
33472 So each item can define when it's possible to select them, by default all
33473 the items are selectable when visible and enabled, while the Separator
33474 item can never be selected.
33475
334762012-04-13 Marco Trevisan (Treviño) <mail@3v1n0.net>
33477
33478 autopilot, quicklist: add more last/first tests
33479
334802012-04-12 Marco Trevisan (Treviño) <mail@3v1n0.net>
33481
33482 autopilot, test_quicklist: added first bunch of key navigation tests
33483
334842012-04-12 Marco Trevisan (Treviño) <mail@3v1n0.net>
33485
33486 QuicklistView, QuicklistMenuItem: export absolute geometries for introspection
33487
334882012-04-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
33489
33490 QuicklistView: add support to Home/End Page up/down buttons to select items
33491
334922012-04-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
33493
33494 QuicklistView: use the new SelectItem into RecvItemMouseDrag
33495
334962012-04-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
33497
33498 QuicklistMenuItem: don't change the focus on move, only on enter/leave
33499
33500 This to keep the consistency with GTK menus.
33501 Also when leaving an unselected entry, we shouldn't unselect all.
33502
335032012-04-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
33504
33505 QuicklistMenuItem: make the introspection prelight name more explicit
33506
335072012-04-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
33508
33509 QuicklistView: enhance the key navigation to follow the same menus behavior
33510
33511 1) When no item is selected pressing the Down arrow key should
33512 select the first item (from top)
33513 2) When no item is selected pressing the Up arrow key should
33514 select the last item (from top)
33515 3) When the last item is selected, pressing the Down arrow key
33516 should select the first item
33517 4) When the first item is selected, pressing the Up arrow key
33518 should select the last item
33519
33520 All these cases assume that the mouse pointer is outside the
33521 quicklist or over an item and not moving, in the case that the
33522 mouse pointer is moved over an unselected item, the focus should
33523 be moved to that item.
33524
335252012-04-11 Marco Trevisan (Treviño) <mail@3v1n0.net>
33526
33527 QuicklistView: manage the prelight item status, avoid double-selected items
33528
335292012-04-18 Thomi Richards <thomi.richards@canonical.com>
33530
33531 Update HUD tests to use the new Eventually() matcher.. Fixes: . Approved by Brandon Schaefer.
33532
335332012-04-19 Thomi Richards <thomi.richards@canonical.com>
33534
33535 Removed unused import, fixed reference to property being treated as a function.
33536
335372012-04-19 Thomi Richards <thomi.richards@canonical.com>
33538
33539 Merged trunk.
33540
335412012-04-18 Thomi Richards <thomi.richards@canonical.com>
33542
33543 Cleaned up code after review.
33544
335452012-04-18 Thomi Richards <thomi.richards@canonical.com>
33546
33547 Merged home-lens-tests-to-wait_for-feature into hud-tests-to-wait_for-feature.
33548
335492012-04-18 Thomi Richards <thomi.richards@canonical.com>
33550
33551 Merged home-lens-tests-to-wait_for-feature into hud-tests-to-wait_for-feature.
33552
335532012-04-18 Thomi Richards <thomi.richards@canonical.com>
33554
33555 Hud tests now use Eventually() matcher object instead of wait_for.
33556
335572012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33558
33559 Fixed going from the Hud to the Dash forgetting window focus when exiting from the Dash.. Fixes: https://bugs.launchpad.net/bugs/984639. Approved by Andrea Azzarone, Thomi Richards.
33560
335612012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33562
33563 * Use the correct assert
33564
335652012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33566
33567 * removed sleep
33568
335692012-04-18 Brandon Schaefer <brandontschaefer@gmail.com>
33570
33571 * Fixes Hud to Dash not restoring window focus
33572 * Also fixes a Dash ap test failing
33573
335742012-04-18 Thomi Richards <thomi.richards@canonical.com>
33575
33576 Home lens tests use wait_for instead of explicit sleep statements.. Fixes: . Approved by Brandon Schaefer, Alex Launi, Thomi Richards.
33577
335782012-04-19 Thomi Richards <thomi.richards@canonical.com>
33579
33580 Merged trunk, reso;lved conflicts.
33581
335822012-04-18 Thomi Richards <thomi.richards@canonical.com>
33583
33584 Merged dash-tests-to-wait_for-feature into home-lens-tests-to-wait_for-feature.
33585
335862012-04-18 Thomi Richards <thomi.richards@canonical.com>
33587
33588 Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
33589
335902012-04-18 Thomi Richards <thomi.richards@canonical.com>
33591
33592 Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
33593
335942012-04-18 Thomi Richards <thomi.richards@canonical.com>
33595
33596 Merged dash-tests-to-wait_for-feature into home-lens-tests-to-wait_for-feature.
33597
335982012-04-18 Thomi Richards <thomi.richards@canonical.com>
33599
33600 Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
33601
336022012-04-18 Thomi Richards <thomi.richards@canonical.com>
33603
33604 Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
33605
336062012-04-18 Thomi Richards <thomi.richards@canonical.com>
33607
33608 Home lens tests now use the Eventually() syntax.
33609
336102012-04-18 Thomi Richards <thomi.richards@canonical.com>
33611
33612 IBus tests use new Eventually matcher.. Fixes: . Approved by Thomi Richards.
33613
336142012-04-18 Thomi Richards <thomi.richards@canonical.com>
33615
33616 IBus tests now use the Eventually() matcher instead of wait_for.
33617
336182012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33619
33620 Don't close the dash if the click is inside the desktop dash border.. Fixes: https://bugs.launchpad.net/bugs/839472. Approved by Tim Penhey.
33621
336222012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33623
33624 Merge trunk.
33625
336262012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33627
33628 Fix AP test.
33629
336302012-04-17 Andrea Azzarone <azzaronea@gmail.com>
33631
33632 Fixes typo. Adds AP test.
33633
336342012-04-17 Andrea Azzarone <azzaronea@gmail.com>
33635
33636 Clicking on the desktop dash border should do nothing, *NOT* close the dash.
33637
336382012-04-18 Michal Hruby <michal.mhr@gmail.com>
33639
33640 Make sure we don't try to remove sources that were already removed.. Fixes: . Approved by Marco Trevisan (Treviño), Andrea Azzarone.
33641
336422012-04-18 Michal Hruby <michal.mhr@gmail.com>
33643
33644 Don't remove invalid sources
33645
336462012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33647
33648 Fixes bug #980924.. Fixes: https://bugs.launchpad.net/bugs/980924. Approved by Gord Allott, Marco Trevisan (Treviño).
33649
336502012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33651
33652 Remove unneeded code.
33653
336542012-04-17 Andrea Azzarone <azzaronea@gmail.com>
33655
33656 Fixes LP bug #980924.
33657
336582012-04-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
33659
33660 UScreen: code updated to be more C++ friendly.
33661
33662 Also moved into the unity namespace.. Fixes: . Approved by Andrea Azzarone.
33663
336642012-04-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
33665
33666 UScreen: ref the GdkScreen object we own.
33667
336682012-04-18 Marco Trevisan (Treviño) <mail@3v1n0.net>
33669
33670 UScreen: code updated to be more C++ friendly.
33671
33672 Also moved into the unity namespace.
33673
336742012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33675
33676 Fix compilation of standalone launcher.. Fixes: https://bugs.launchpad.net/bugs/983989. Approved by Marco Trevisan (Treviño), Sam Spilsbury.
33677
336782012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33679
33680 Fix standalone launcher.
33681
336822012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33683
33684 Use std::shared_ptr::reset instead of = some::Ptr(new...) for UScreen::proxy_. Fixes: . Approved by Marco Trevisan (Treviño).
33685
336862012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33687
33688 Revert prev commit. Use std::shared_ptr::reset.
33689
336902012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33691
33692 Makes UScreen::proxy_ a unity::glib::DBusProxy.
33693
336942012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33695
33696 Fix bug #977922.. Fixes: https://bugs.launchpad.net/bugs/977922. Approved by Tim Penhey.
33697
336982012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33699
33700 Fix.
33701
337022012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33703
33704 Fix bug #977922.
33705
337062012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33707
33708 Fix the switcher so it displays the full title of apps in Chinese. Fixes: https://bugs.launchpad.net/bugs/830801. Approved by Tim Penhey.
33709
337102012-04-18 Andrea Azzarone <azzaronea@gmail.com>
33711
33712 Merge trunk
33713
337142012-04-16 Andrea Azzarone <azzaronea@gmail.com>
33715
33716 Add a manual test.
33717
337182012-04-14 Andrea Azzarone <azzaronea@gmail.com>
33719
33720 Fix bug #830801.
33721
337222012-04-18 Thomi Richards <thomi.richards@canonical.com>
33723
33724 Launcher tests use Eventually() matcher.. Fixes: . Approved by Thomi Richards.
33725
337262012-04-18 Thomi Richards <thomi.richards@canonical.com>
33727
33728 Launcher emulator now uses wait_for to block until the action has been performed. Reduces the need for sleep() statements inside tests.
33729
337302012-04-18 Thomi Richards <thomi.richards@canonical.com>
33731
33732 Launcher tests now use Eventually() matcher. Also removed some cruft from the launcher emulators.
33733
337342012-04-18 Thomi Richards <thomi.richards@canonical.com>
33735
33736 Merged ibus-test-to-wait_for-feature into launcher-tests-pep8-whitespace-fixes.
33737
337382012-04-18 Thomi Richards <thomi.richards@canonical.com>
33739
33740 Merged hud-tests-to-wait_for-feature into ibus-test-to-wait_for-feature.
33741
337422012-04-18 Thomi Richards <thomi.richards@canonical.com>
33743
33744 Merged home-lens-tests-to-wait_for-feature into hud-tests-to-wait_for-feature.
33745
337462012-04-18 Thomi Richards <thomi.richards@canonical.com>
33747
33748 Merged dash-tests-to-wait_for-feature into home-lens-tests-to-wait_for-feature.
33749
337502012-04-18 Thomi Richards <thomi.richards@canonical.com>
33751
33752 Merged ibus-test-to-wait_for-feature into launcher-tests-pep8-whitespace-fixes.
33753
337542012-04-18 Thomi Richards <thomi.richards@canonical.com>
33755
33756 Merged hud-tests-to-wait_for-feature into ibus-test-to-wait_for-feature.
33757
337582012-04-18 Thomi Richards <thomi.richards@canonical.com>
33759
33760 Merged home-lens-tests-to-wait_for-feature into hud-tests-to-wait_for-feature.
33761
337622012-04-18 Thomi Richards <thomi.richards@canonical.com>
33763
33764 Merged dash-tests-to-wait_for-feature into home-lens-tests-to-wait_for-feature.
33765
337662012-04-18 Thomi Richards <thomi.richards@canonical.com>
33767
33768 Merged ibus-test-to-wait_for-feature into launcher-tests-pep8-whitespace-fixes.
33769
337702012-04-18 Thomi Richards <thomi.richards@canonical.com>
33771
33772 Merged hud-tests-to-wait_for-feature into ibus-test-to-wait_for-feature.
33773
337742012-04-18 Thomi Richards <thomi.richards@canonical.com>
33775
33776 Merged home-lens-tests-to-wait_for-feature into hud-tests-to-wait_for-feature.
33777
337782012-04-18 Thomi Richards <thomi.richards@canonical.com>
33779
33780 Merged dash-tests-to-wait_for-feature into home-lens-tests-to-wait_for-feature.
33781
337822012-04-17 Thomi Richards <thomi.richards@canonical.com>
33783
33784 Fixes PEP8 and whitespace issues.
33785
337862012-04-17 Thomi Richards <thomi.richards@canonical.com>
33787
33788 IBUs tests now make use of the wait_for attribute feature. Also refactored the ibus tests so many of them are only a few lines long, and reduced the amount of duplicated code.
33789
337902012-04-17 Thomi Richards <thomi.richards@canonical.com>
33791
33792 Merged home-lens-tests-to-wait_for-feature into hud-tests-to-wait_for-feature.
33793
337942012-04-17 Thomi Richards <thomi.richards@canonical.com>
33795
33796 Merged dash-tests-to-wait_for-feature into home-lens-tests-to-wait_for-feature.
33797
337982012-04-17 Thomi Richards <thomi.richards@canonical.com>
33799
33800 Fixes several timing issues. Unity exports some properties in arrays, which makes it slightly tricky to use the wait_for feature.
33801
338022012-04-17 Thomi Richards <thomi.richards@canonical.com>
33803
33804 More hud test changes.
33805
338062012-04-17 Thomi Richards <thomi.richards@canonical.com>
33807
33808 Hud test changes first pass merge.
33809
338102012-04-17 Thomi Richards <thomi.richards@canonical.com>
33811
33812 Home lens uses wait_for instead of explicit sleeps.
33813
338142012-04-18 Thomi Richards <thomi.richards@canonical.com>
33815
33816 Dash autopilot tests use the new autopilot wait_for feature.. Fixes: . Approved by Brandon Schaefer, Tim Penhey.
33817
338182012-04-18 Thomi Richards <thomi.richards@canonical.com>
33819
33820 Missed one spot.
33821
338222012-04-18 Thomi Richards <thomi.richards@canonical.com>
33823
33824 Dash tests changed to use Eventually matcher.
33825
338262012-04-18 Thomi Richards <thomi.richards@canonical.com>
33827
33828 Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
33829
338302012-04-18 Thomi Richards <thomi.richards@canonical.com>
33831
33832 Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
33833
338342012-04-18 Thomi Richards <thomi.richards@canonical.com>
33835
33836 Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
33837
338382012-04-17 Thomi Richards <thomi.richards@canonical.com>
33839
33840 Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
33841
338422012-04-17 Thomi Richards <thomi.richards@canonical.com>
33843
33844 fixed code after code review.
33845
338462012-04-17 Thomi Richards <thomi.richards@canonical.com>
33847
33848 Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
33849
338502012-04-17 Thomi Richards <thomi.richards@canonical.com>
33851
33852 More fixes.
33853
338542012-04-17 Thomi Richards <thomi.richards@canonical.com>
33855
33856 Merged fix-command-lens-ap-tests-with-new-wait_for-featuer into dash-tests-to-wait_for-feature.
33857
338582012-04-17 Thomi Richards <thomi.richards@canonical.com>
33859
33860 Merged in code to fix up the dash tests.
33861
338622012-04-18 Thomi Richards <thomi.richards@canonical.com>
33863
33864 Command lens uses Eventually() autopilot matcher to eliminate the need for sleep() statements in autopilot tests.. Fixes: . Approved by Brandon Schaefer, Tim Penhey.
33865
338662012-04-18 Thomi Richards <thomi.richards@canonical.com>
33867
33868 Updated to use the Eventually matcher.
33869
338702012-04-18 Thomi Richards <thomi.richards@canonical.com>
33871
33872 Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
33873
338742012-04-18 Thomi Richards <thomi.richards@canonical.com>
33875
33876 Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
33877
338782012-04-18 Thomi Richards <thomi.richards@canonical.com>
33879
33880 Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
33881
338822012-04-17 Thomi Richards <thomi.richards@canonical.com>
33883
33884 Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
33885
338862012-04-17 Thomi Richards <thomi.richards@canonical.com>
33887
33888 Merged wait_for-to-use-testtools-exception into fix-command-lens-ap-tests-with-new-wait_for-featuer.
33889
338902012-04-17 Thomi Richards <thomi.richards@canonical.com>
33891
33892 Removed unused import
33893
338942012-04-17 Thomi Richards <thomi.richards@canonical.com>
33895
33896 Command lens tests updated to use the new wait_for feature, and various other API fixes.
33897
338982012-04-18 Thomi Richards <thomi.richards@canonical.com>
33899
33900 Cleaned up docstrings and whitespace in autopilot panel tests.. Fixes: . Approved by Tim Penhey.
33901
339022012-04-18 Thomi Richards <thomi.richards@canonical.com>
33903
33904 Whitespace, PEP8 and PEP257 fixes for the panel tests.
33905
339062012-04-17 Thomi Richards <thomi.richards@canonical.com>
33907
33908 Adds an Eventually() matcher that allows us to block a while until a unity attribute matches a testtools match object.. Fixes: . Approved by Tim Penhey, Thomi Richards.
33909
339102012-04-18 Thomi Richards <thomi.richards@canonical.com>
33911
33912 Check match and wait_for attribute are callables.:
33913
339142012-04-18 Thomi Richards <thomi.richards@canonical.com>
33915
33916 Fixed code from review.
33917
339182012-04-18 Thomi Richards <thomi.richards@canonical.com>
33919
33920 Fixed code from review.
33921
339222012-04-17 Andrea Azzarone <azzaronea@gmail.com>
33923
33924 Fix some uninitialized variables.. Fixes: https://bugs.launchpad.net/bugs/983333. Approved by Tim Penhey.
33925
339262012-04-16 Andrea Azzarone <azzaronea@gmail.com>
33927
33928 Fix bug #983333
33929
339302012-04-17 Andrea Azzarone <azzaronea@gmail.com>
33931
33932 Fixes bug #983268. Fixes: https://bugs.launchpad.net/bugs/983268. Approved by Thomi Richards.
33933
339342012-04-17 Andrea Azzarone <azzaronea@gmail.com>
33935
33936 Fixes bug #983268.
33937
339382012-04-17 Thomi Richards <thomi.richards@canonical.com>
33939
33940 Extend the autopilot wait_for feature to use testtools matcher instances as well as ordinary values. Also added an 'Eventually' matcher which makes tests more explicit.. Fixes: . Approved by Alex Launi.
33941
339422012-04-18 Thomi Richards <thomi.richards@canonical.com>
33943
33944 Fixed typo
33945
339462012-04-18 Thomi Richards <thomi.richards@canonical.com>
33947
33948 Added 'Eventually' autopilot matcher.
33949
339502012-04-17 Thomi Richards <thomi.richards@canonical.com>
33951
33952 Extend the autopilot wait_for feature to use testtools matcher instances as well as ordinary values.. Fixes: . Approved by Alex Launi.
33953
339542012-04-18 Thomi Richards <thomi.richards@canonical.com>
33955
33956 Don't use hasattr,
33957
339582012-04-17 Thomi Richards <thomi.richards@canonical.com>
33959
33960 Cleaned up code after code review.
33961
339622012-04-17 Thomi Richards <thomi.richards@canonical.com>
33963
33964 wait_for now deals with attributes that have a '-' in them correctly.
33965
339662012-04-17 Thomi Richards <thomi.richards@canonical.com>
33967
33968 wait_for attribute now accept testtools matchers.
33969
339702012-04-17 Thomi Richards <thomi.richards@canonical.com>
33971
33972 Attribute wait_for feature now raises an AssertionError instead of a RuntimeError. THis will make unit tests FAIL instead of ERRORing when wa wait_for call fails.
33973
339742012-04-17 Andrea Cimitan <andrea.cimitan@canonical.com>
33975
33976 Fix transparent panel in non-GLSL hardware, and use bool 'false' instead 'FALSE'. Fixes: https://bugs.launchpad.net/bugs/965323. Approved by Robert Carr, Michal Hruby.
33977
339782012-04-17 Andrea Cimitan <andrea.cimitan@canonical.com>
33979
33980 Correct fix for 965323
33981
339822012-04-17 Andrea Cimitan <andrea.cimitan@canonical.com>
33983
33984 Use false as boolean instead FALSE, whitespaces
33985
339862012-04-17 Andrea Cimitan <andrea.cimitan@canonical.com>
33987
33988 Attempt to fix 965323
33989
339902012-04-17 Thomi Richards <thomi.richards@canonical.com>
33991
33992 Added the autopilot wait_for attribute feature.. Fixes: . Approved by Marco Trevisan (Treviño), Brandon Schaefer.
33993
339942012-04-13 Thomi Richards <thomi.richards@canonical.com>
33995
33996 Dash and hud emulators use new wait_for attribute feature.
33997
339982012-04-13 Thomi Richards <thomi.richards@canonical.com>
33999
34000 Merged autopilot-attribute-feature into convert-to-use-wait_for.
34001
340022012-04-13 Thomi Richards <thomi.richards@canonical.com>
34003
34004 Don't change dash in this pipeline.
34005
340062012-04-13 Thomi Richards <thomi.richards@canonical.com>
34007
34008 Merged branch that fixes the multi key code.
34009
340102012-04-12 Thomi Richards <thomi.richards@canonical.com>
34011
34012 Cleaned up gsettings calling code. Don't want to run command through a shell, and removed extra quotes.
34013
340142012-04-11 Alex Launi <alex.launi@canonical.com>
34015
34016 Small fixes for compose key tests
34017
340182012-04-11 Alex Launi <alex.launi@canonical.com>
34019
34020 Args should be a list not a tuple
34021
340222012-04-13 Thomi Richards <thomi.richards@canonical.com>
34023
34024 Merged trunk.
34025
340262012-04-13 Thomi Richards <thomi.richards@canonical.com>
34027
34028 Dash tests now use new autopilot wait_for mechanism.
34029
340302012-04-13 Thomi Richards <thomi.richards@canonical.com>
34031
34032 Fix unity logging reset.
34033
340342012-04-11 Thomi Richards <thomi.richards@canonical.com>
34035
34036 Feature seems to work. Trying it out on the dash tests.
34037
340382012-04-11 Thomi Richards <thomi.richards@canonical.com>
34039
34040 Removed old code, added special sauce.
34041
340422012-04-17 Lars Uebernickel <lars.uebernickel@canonical.com>
34043
34044 Force menu reposition on popup in case its contents have changed.
34045
34046 Fixes bug 883317.. Fixes: https://bugs.launchpad.net/bugs/883317. Approved by Marco Trevisan (Treviño).
34047
340482012-04-13 Lars Uebernickel <lars.uebernickel@canonical.com>
34049
34050 Force menu reposition on popup in case its contents have changed
34051
340522012-04-17 Michal Hruby <michal.mhr@gmail.com>
34053
34054 Fix a couple of wrong reference/memory management issues. Fixes: https://bugs.launchpad.net/bugs/979429. Approved by Marco Trevisan (Treviño).
34055
340562012-04-16 Michal Hruby <michal.mhr@gmail.com>
34057
34058 Fix possible signal disconnection on already dead object
34059
340602012-04-16 Michal Hruby <michal.mhr@gmail.com>
34061
34062 Fix incorrect string freeing in Hud
34063
340642012-04-16 Michal Hruby <michal.mhr@gmail.com>
34065
34066 Fix wrong unref in DebugInterface
34067
340682012-04-17 Gord Allott <gord.allott@canonical.com>
34069
34070 Small fix for the unity cmake, depend on unity core was missing from a test. Fixes: . Approved by Michal Hruby.
34071
340722012-04-17 Gord Allott <gord.allott@canonical.com>
34073
34074 fixes small cmake depends issue
34075
340762012-04-16 Andrea Azzarone <azzaronea@gmail.com>
34077
34078 The shortcut keys in workspace section of the shortcut overlay aren't translated.. Fixes: https://bugs.launchpad.net/bugs/980828. Approved by Didier Roche.
34079
340802012-04-13 Andrea Azzarone <azzaronea@gmail.com>
34081
34082 Fixes bug #980828.
34083
340842012-04-16 Marco Trevisan (Treviño) <mail@3v1n0.net>
34085
34086 Fix the behaviour of alt-tab and clicking on the launcher icon to just raise the most recently used window, not all for that app.
34087
34088
34089 BamfLauncherIcon's activation related code has been updated to be more multimonitor aware (for free I've fixed also some bugs that caused the windows not to be put in spread mode in multi-monitor), and to support both the "Launcher only on Primary Monitor" and "Launcher on all monitors" options.
34090
34091 PluginAdapter's FocusWindowGroup method has been updated to optionally only unminimize / raise and activate only the top window. This code would have been more optimized using a reverse iterator to fetch the top_window, but not to change the whole logic and to allow to keep the previous behavior (that initially we wanted for "long alt+tab") without duplicating code, I've just hacked that.
34092 Implemented also GetWindowMonitor to workaround the mismatch we had with the compiz' window->outputDevice() and the UScreen values that now we use in the whole unity.
34093
34094 Screencast of the fixed version: http://ubuntuone.com/7YaWciQnaZHfzr35asSz0N. Fixes: https://bugs.launchpad.net/bugs/861250, https://bugs.launchpad.net/bugs/959339, https://bugs.launchpad.net/bugs/981795. Approved by Thomi Richards, Tim Penhey.
34095
340962012-04-16 Tim Penhey <tim.penhey@canonical.com>
34097
34098 Test the alt-tab appears on the monitor that has window focus.
34099
341002012-04-16 Tim Penhey <tim.penhey@canonical.com>
34101
34102 Add window stack assertions to the switcher tests.
34103
341042012-04-16 Tim Penhey <tim.penhey@canonical.com>
34105
34106 Assert that the visible window stack is what we expect.
34107
341082012-04-16 Tim Penhey <tim.penhey@canonical.com>
34109
34110 More AP test tweaks.
34111
341122012-04-16 Tim Penhey <tim.penhey@canonical.com>
34113
34114 Tweaks to the test.
34115
341162012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
34117
34118 PluginAdapter: avoid to raise and unminimize top_window if already done
34119
341202012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
34121
34122 Launcher: be more clear in comment (yeah?)
34123
341242012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
34125
34126 UScreen: use GetMonitorAtPosition in GetMonitorWithMouse
34127
341282012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
34129
34130 WindowManager, BamfLauncherIcon: some code cleanup
34131
341322012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
34133
34134 autopilot, test_launcher: updated click test to check minimized windows too
34135
34136 Removed debug data
34137
341382012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
34139
34140 autopilot, test_switcher: updated against new updates
34141
341422012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
34143
34144 unityshell: show the Alt+Tab window in the monitor where is the active window
34145
34146 As per design.
34147
341482012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
34149
34150 WindowManager: add method to get the active window.
34151
341522012-04-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
34153
34154 PluginAdapter: removing debugging bits
34155
341562012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34157
34158 Merging with branch changes
34159
341602012-04-14 Brandon Schaefer <brandontschaefer@gmail.com>
34161
34162 * removed something that got added somehow
34163
341642012-04-14 Brandon Schaefer <brandontschaefer@gmail.com>
34165
34166 * Added an AP test for the new design changes.
34167
341682012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34169
34170 SwitcherController: Removing the code for the Quick Alt+Tab, it should behave always at the same way
34171
34172 19:11:04 <JohnLea> so to summarize the above, when a app icon is selected
34173 in Alt-Tab, the most recently focused window (on any monitor, but only in
34174 the current workspace) of that application which is not minimised
34175 should be focused
34176
341772012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34178
34179 autopilot: fixed the AP test
34180
341812012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34182
34183 BamfLauncherIcon: Also invisible windows shouldn't be counted as available in monitor
34184
34185 Now the spread works as expected, clicking on each monitor's panel! ;)
34186
341872012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34188
34189 BamfLauncherIcon: don't consider an unmapped window as one in monitor
34190
341912012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34192
34193 BamfLauncherIcon: focus a window if the application is not active on the current monitor
34194
341952012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34196
34197 Launcher: if the current launcher is used for all the monitors, don't filter windows per monitor
34198
341992012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34200
34201 SwitcherController: include the switcher monitor when activating a group
34202
342032012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34204
34205 WindowManager: add GetWindowMonitor method, and use UScreen to fetch it
34206
34207 This now used in PluginAdapter not to have inconsistences.
34208
342092012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34210
34211 UScreen: allow to get the monitor for a given point
34212
342132012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34214
34215 unityshell: switcher, use UScreen to get the monitor value.
34216
34217 Not using this can cause inconsistences, due to the fact that compiz
34218 numbers the devices in a different way.
34219
342202012-04-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34221
34222 PluginAdapter::FocusWindowGroup: add a parameter to define if focusing the on-top window only
34223
34224 This allow to be more monitor/VP safe
34225
342262012-04-12 Brandon Schaefer <brandontschaefer@gmail.com>
34227
34228 * remove extra line
34229
342302012-04-12 Brandon Schaefer <brandontschaefer@gmail.com>
34231
34232 * Fixed the No new line error diff was reporting
34233
342342012-04-12 Brandon Schaefer <brandontschaefer@gmail.com>
34235
34236 * merged trunk
34237
342382012-04-12 Brandon Schaefer <brandontschaefer@gmail.com>
34239
34240 * removed random dash '-'
34241
342422012-04-12 Brandon Schaefer <brandontschaefer@gmail.com>
34243
34244 * Add autopilot test for both bugs!
34245
342462012-04-12 Brandon Schaefer <brandontschaefer@gmail.com>
34247
34248 * Added more autopilot test for quick alt+tab
34249
342502012-04-11 Brandon Schaefer <brandontschaefer@gmail.com>
34251
34252 * merged trunk
34253
342542012-04-09 Brandon Schaefer <brandontschaefer@gmail.com>
34255
34256 * merged trunk
34257
342582012-04-06 Brandon Schaefer <brandontschaefer@gmail.com>
34259
34260 * Added 2 autopilot test showing quick tab is true when pressed fast enough
34261
342622012-04-06 Brandon Schaefer <brandontschaefer@gmail.com>
34263
34264 * fixed manual test I messed up
34265
342662012-04-06 Brandon Schaefer <brandontschaefer@gmail.com>
34267
34268 * Added a timer for quick tab
34269
342702012-04-06 Brandon Schaefer <brandontschaefer@gmail.com>
34271
34272 * Merged trunk
34273
342742012-04-05 Brandon Schaefer <brandontschaefer@gmail.com>
34275
34276 * Added another manual test
34277 * Fixes
34278
342792012-04-04 Brandon Schaefer <brandontschaefer@gmail.com>
34280
34281 * Fixed tabbing issues
34282
342832012-04-04 Brandon Schaefer <brandontschaefer@gmail.com>
34284
34285 * Merged with trunk, fixed conficts
34286
342872011-12-15 Marco Trevisan (Treviño) <mail@3v1n0.net>
34288
34289 BamfLauncherIcon: don't include dialog windows on Alt+Tab.
34290
342912011-12-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34292
34293 manual-tests: Added test for QuickAltTab
34294
342952011-12-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34296
34297 PluginAdapter: Add support for the FocusVisibility::OnlyVisibleOnTop on FocusWindowGroup
34298
34299 When a group is asked to focus with OnlyVisibleOnTop, we look for the
34300 first non-minimized window on top of the stack and we raise and activate it.
34301
34302 Code indentation fixes included.
34303
343042011-12-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34305
34306 BamfLauncherIcon: when we receive a "quick" activate, use the OnlyVisibleOnTop focus visbility
34307
34308 Defined a new FocusVisibility called OnlyVisibleOnTop that is meant
34309 to only focus the first application window on top of the stack.
34310 That is used when we receive a Switcher activate with a button != 0.
34311
343122011-12-14 Marco Trevisan (Treviño) <mail@3v1n0.net>
34313
34314 SwitcherController: use the button value of ActionArg to indicate the switch type
34315
34316 Instead of defining another type of ActionArg, I've used the button value
34317 of ActionArg to define if we're currently performing a quick-alt+tab or
34318 a standard switch.
34319 Basically:
34320
343212012-04-16 Alexandros Frantzis <alexandros.frantzis@linaro.org>
34322
34323 Fix compilation with OpenGL ES 2.0.. Fixes: . Approved by Sam Spilsbury.
34324
343252012-04-06 Alexandros Frantzis <alexandros.frantzis@linaro.org>
34326
34327 Fix compilation with OpenGL ES 2.0.
34328
343292012-04-12 Gord Allott <gord.allott@canonical.com >
34330
34331 fixes an uninitalised variable in the dashview code
34332
343332012-04-12 Gord Allott <gord.allott@canonical.com>
34334
34335 fixed uninitalised value
34336
343372012-04-12 Didier Roche <didier.roche@canonical.com>
34338
34339 Release\ 5.10.0
34340
34341>>>>>>> MERGE-SOURCE
319012012-04-12 Michal Hruby <michal.mhr@gmail.com>343422012-04-12 Michal Hruby <michal.mhr@gmail.com>
3190234343
31903 Make sure the lenses search for things we want on startup. Fixes: https://bugs.launchpad.net/bugs/979799. Approved by Gord Allott.34344 Make sure the lenses search for things we want on startup. Fixes: https://bugs.launchpad.net/bugs/979799. Approved by Gord Allott.
3190434345
=== modified file 'HACKING'
--- HACKING 2012-09-13 10:56:42 +0000
+++ HACKING 2013-07-24 18:20:41 +0000
@@ -7,7 +7,11 @@
7 - gthread-2.07 - gthread-2.0
8 - indicator8 - indicator
9 - atk9 - atk
10<<<<<<< TREE
10 - libatk-adaptor11 - libatk-adaptor
12=======
13 - libgeis
14>>>>>>> MERGE-SOURCE
1115
12Or if you are on ubuntu run the command, apt-get build-dep unity16Or if you are on ubuntu run the command, apt-get build-dep unity
1317
1418
=== modified file 'UnityCore/DBusIndicators.cpp'
--- UnityCore/DBusIndicators.cpp 2013-06-17 11:16:12 +0000
+++ UnityCore/DBusIndicators.cpp 2013-07-24 18:20:41 +0000
@@ -47,7 +47,12 @@
47class DBusIndicators::Impl47class DBusIndicators::Impl
48{48{
49public:49public:
50 Impl(std::string const& dbus_name, DBusIndicators* owner);50<<<<<<< TREE
51 Impl(std::string const& dbus_name, DBusIndicators* owner);
52=======
53 Impl(std::string const& dbus_name, DBusIndicators* owner);
54 ~Impl();
55>>>>>>> MERGE-SOURCE
5156
52 void CheckLocalService();57 void CheckLocalService();
53 void RequestSyncAll();58 void RequestSyncAll();
@@ -82,7 +87,14 @@
82// Public Methods87// Public Methods
83DBusIndicators::Impl::Impl(std::string const& dbus_name, DBusIndicators* owner)88DBusIndicators::Impl::Impl(std::string const& dbus_name, DBusIndicators* owner)
84 : owner_(owner)89 : owner_(owner)
85 , gproxy_(dbus_name, SERVICE_PATH, SERVICE_IFACE,90<<<<<<< TREE
91 , gproxy_(dbus_name, SERVICE_PATH, SERVICE_IFACE,
92=======
93 , reconnect_timeout_id_(0)
94 , show_entry_idle_id_(0)
95 , show_appmenu_idle_id_(0)
96 , gproxy_(dbus_name, SERVICE_PATH, SERVICE_IFACE,
97>>>>>>> MERGE-SOURCE
86 G_BUS_TYPE_SESSION, G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES)98 G_BUS_TYPE_SESSION, G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES)
87{99{
88 gproxy_.Connect("ReSync", sigc::mem_fun(this, &DBusIndicators::Impl::OnReSync));100 gproxy_.Connect("ReSync", sigc::mem_fun(this, &DBusIndicators::Impl::OnReSync));
@@ -261,8 +273,13 @@
261 gint32 priority = -1;273 gint32 priority = -1;
262274
263 std::map<Indicator::Ptr, Indicator::Entries> indicators;275 std::map<Indicator::Ptr, Indicator::Entries> indicators;
276<<<<<<< TREE
264 int wanted_idx = 0;277 int wanted_idx = 0;
265 bool any_different_idx = false;278 bool any_different_idx = false;
279=======
280 int wantedIndex = 0;
281 bool anyIndexDifferent = false;
282>>>>>>> MERGE-SOURCE
266283
267 g_variant_get(args, "(a(ssssbbusbbi))", &iter);284 g_variant_get(args, "(a(ssssbbusbbi))", &iter);
268 while (g_variant_iter_loop(iter, "(ssssbbusbbi)",285 while (g_variant_iter_loop(iter, "(ssssbbusbbi)",
@@ -292,6 +309,7 @@
292 // Empty entries are empty indicators.309 // Empty entries are empty indicators.
293 if (!entry.empty())310 if (!entry.empty())
294 {311 {
312<<<<<<< TREE
295 Entry::Ptr e;313 Entry::Ptr e;
296 if (!any_different_idx)314 if (!any_different_idx)
297 {315 {
@@ -307,6 +325,20 @@
307 any_different_idx = true;325 any_different_idx = true;
308 }326 }
309 }327 }
328=======
329 Entry::Ptr e;
330 if (!anyIndexDifferent)
331 {
332 // Indicators can only add or remove entries, so if
333 // there is a index change we can't reuse the existing ones
334 // after that index
335 int existingEntryIndex = indicator->EntryIndex(entry_id);
336 if (wantedIndex == existingEntryIndex)
337 e = indicator->GetEntry(entry_id);
338 else
339 anyIndexDifferent = true;
340 }
341>>>>>>> MERGE-SOURCE
310342
311 if (!e)343 if (!e)
312 {344 {
@@ -322,7 +354,11 @@
322 }354 }
323355
324 entries.push_back(e);356 entries.push_back(e);
357<<<<<<< TREE
325 ++wanted_idx;358 ++wanted_idx;
359=======
360 wantedIndex++;
361>>>>>>> MERGE-SOURCE
326 }362 }
327 }363 }
328 g_variant_iter_free(iter);364 g_variant_iter_free(iter);
329365
=== modified file 'UnityCore/DBusIndicators.h'
--- UnityCore/DBusIndicators.h 2012-12-04 00:33:18 +0000
+++ UnityCore/DBusIndicators.h 2013-07-24 18:20:41 +0000
@@ -50,6 +50,10 @@
50 DBusIndicators(std::string const& dbus_name);50 DBusIndicators(std::string const& dbus_name);
51 bool IsConnected() const;51 bool IsConnected() const;
5252
53protected:
54 DBusIndicators(std::string const& dbus_name);
55 bool IsConnected() const;
56
53private:57private:
54 class Impl;58 class Impl;
55 std::unique_ptr<Impl> pimpl;59 std::unique_ptr<Impl> pimpl;
5660
=== modified file 'UnityCore/GLibSignal.cpp'
--- UnityCore/GLibSignal.cpp 2012-08-15 16:58:14 +0000
+++ UnityCore/GLibSignal.cpp 2013-07-24 18:20:41 +0000
@@ -37,8 +37,12 @@
3737
38void SignalBase::Disconnect()38void SignalBase::Disconnect()
39{39{
40<<<<<<< TREE
40 if (connection_id_ && G_IS_OBJECT(object_))41 if (connection_id_ && G_IS_OBJECT(object_))
41 {42 {
43=======
44 if (connection_id_ && G_IS_OBJECT(object_))
45>>>>>>> MERGE-SOURCE
42 g_signal_handler_disconnect(object_, connection_id_);46 g_signal_handler_disconnect(object_, connection_id_);
43 g_object_remove_weak_pointer(object_, reinterpret_cast<gpointer*>(&object_));47 g_object_remove_weak_pointer(object_, reinterpret_cast<gpointer*>(&object_));
44 }48 }
@@ -110,10 +114,15 @@
110// (it allows you to pass in a GObject without casting up).114// (it allows you to pass in a GObject without casting up).
111void SignalManager::Disconnect(void* object, std::string const& signal_name)115void SignalManager::Disconnect(void* object, std::string const& signal_name)
112{116{
117<<<<<<< TREE
113 bool all_signals = signal_name.empty();118 bool all_signals = signal_name.empty();
114119
115 for (auto it = connections_.begin(); it != connections_.end();)120 for (auto it = connections_.begin(); it != connections_.end();)
121=======
122 for (auto it = connections_.begin(); it != connections_.end(); ++it)
123>>>>>>> MERGE-SOURCE
116 {124 {
125<<<<<<< TREE
117 auto const& signal = *it;126 auto const& signal = *it;
118127
119 if (signal->object() == object && (all_signals || signal->name() == signal_name))128 if (signal->object() == object && (all_signals || signal->name() == signal_name))
@@ -124,6 +133,13 @@
124 else133 else
125 {134 {
126 ++it;135 ++it;
136=======
137 if ((*it)->object() == object &&
138 (signal_name.empty() || (*it)->name() == signal_name))
139 {
140 (*it)->Disconnect();
141 connections_.erase(it, it);
142>>>>>>> MERGE-SOURCE
127 }143 }
128 }144 }
129}145}
130146
=== modified file 'UnityCore/GLibSignal.h'
--- UnityCore/GLibSignal.h 2012-08-15 16:58:14 +0000
+++ UnityCore/GLibSignal.h 2013-07-24 18:20:41 +0000
@@ -87,6 +87,7 @@
87 SignalManager();87 SignalManager();
88 ~SignalManager();88 ~SignalManager();
89 void Add(SignalBase* signal);89 void Add(SignalBase* signal);
90<<<<<<< TREE
90 void Add(SignalBase::Ptr const& signal);91 void Add(SignalBase::Ptr const& signal);
91 template <typename R, typename G, typename... Ts>92 template <typename R, typename G, typename... Ts>
92 void Add(G object, std::string const& signal_name, typename Signal<R, G, Ts...>::SignalCallback const& callback)93 void Add(G object, std::string const& signal_name, typename Signal<R, G, Ts...>::SignalCallback const& callback)
@@ -95,6 +96,9 @@
95 }96 }
9697
97 void Disconnect(void* object, std::string const& signal_name = "");98 void Disconnect(void* object, std::string const& signal_name = "");
99=======
100 void Disconnect(void* object, std::string const& signal_name = "");
101>>>>>>> MERGE-SOURCE
98102
99private:103private:
100 static void OnObjectDestroyed(SignalManager* self, GObject* old_obj);104 static void OnObjectDestroyed(SignalManager* self, GObject* old_obj);
101105
=== modified file 'UnityCore/Hud.cpp'
=== modified file 'UnityCore/Indicator.cpp'
--- UnityCore/Indicator.cpp 2013-07-01 14:58:29 +0000
+++ UnityCore/Indicator.cpp 2013-07-24 18:20:41 +0000
@@ -101,6 +101,7 @@
101 return Entry::Ptr();101 return Entry::Ptr();
102}102}
103103
104<<<<<<< TREE
104int Indicator::EntryIndex(std::string const& entry_id) const105int Indicator::EntryIndex(std::string const& entry_id) const
105{106{
106 int i = 0;107 int i = 0;
@@ -125,6 +126,33 @@
125void Indicator::OnEntrySecondaryActivate(std::string const& entry_id)126void Indicator::OnEntrySecondaryActivate(std::string const& entry_id)
126{127{
127 on_secondary_activate.emit(entry_id);128 on_secondary_activate.emit(entry_id);
129=======
130int Indicator::EntryIndex(std::string const& entry_id) const
131{
132 int i = 0;
133 for (auto entry : entries_)
134 {
135 if (entry->id() == entry_id)
136 {
137 return i;
138 }
139 ++i;
140 }
141
142 return -1;
143}
144
145void Indicator::OnEntryShowMenu(std::string const& entry_id, unsigned int xid,
146 int x, int y, unsigned int button, unsigned int timestamp)
147{
148 on_show_menu.emit(entry_id, xid, x, y, button, timestamp);
149}
150
151void Indicator::OnEntrySecondaryActivate(std::string const& entry_id,
152 unsigned int timestamp)
153{
154 on_secondary_activate.emit(entry_id, timestamp);
155>>>>>>> MERGE-SOURCE
128}156}
129157
130void Indicator::OnEntryScroll(std::string const& entry_id, int delta)158void Indicator::OnEntryScroll(std::string const& entry_id, int delta)
131159
=== modified file 'UnityCore/Indicator.h'
=== modified file 'dash/DashController.cpp'
--- dash/DashController.cpp 2013-07-01 21:19:33 +0000
+++ dash/DashController.cpp 2013-07-24 18:20:41 +0000
@@ -90,11 +90,20 @@
90 }90 }
9191
92 SetupWindow();92 SetupWindow();
93<<<<<<< TREE
93 UScreen::GetDefault()->changed.connect([&] (int, std::vector<nux::Geometry>&) { Relayout(true); });94 UScreen::GetDefault()->changed.connect([&] (int, std::vector<nux::Geometry>&) { Relayout(true); });
9495
95 Settings::Instance().form_factor.changed.connect([this](FormFactor)96 Settings::Instance().form_factor.changed.connect([this](FormFactor)
97=======
98
99 Settings::Instance().changed.connect([&]()
100>>>>>>> MERGE-SOURCE
96 {101 {
102<<<<<<< TREE
97 if (window_ && view_ && visible_)103 if (window_ && view_ && visible_)
104=======
105 if (window_ && view_)
106>>>>>>> MERGE-SOURCE
98 {107 {
99 // Relayout here so the input window size updates.108 // Relayout here so the input window size updates.
100 Relayout();109 Relayout();
@@ -104,6 +113,7 @@
104 nux::GetWindowCompositor().SetKeyFocusArea(view_->default_focus());113 nux::GetWindowCompositor().SetKeyFocusArea(view_->default_focus());
105 }114 }
106 });115 });
116<<<<<<< TREE
107117
108 auto spread_cb = sigc::bind(sigc::mem_fun(this, &Controller::HideDash), true);118 auto spread_cb = sigc::bind(sigc::mem_fun(this, &Controller::HideDash), true);
109 WindowManager::Default().initiate_spread.connect(spread_cb);119 WindowManager::Default().initiate_spread.connect(spread_cb);
@@ -115,6 +125,24 @@
115125
116 return static_cast<GVariant*>(nullptr);126 return static_cast<GVariant*>(nullptr);
117 });127 });
128=======
129
130 auto spread_cb = sigc::bind(sigc::mem_fun(this, &Controller::HideDash), true);
131 PluginAdapter::Default()->initiate_spread.connect(spread_cb);
132}
133
134Controller::~Controller()
135{
136 if (window_)
137 window_->UnReference();
138 window_ = 0;
139
140 if (timeline_id_)
141 g_source_remove(timeline_id_);
142
143 if (ensure_id_)
144 g_source_remove(ensure_id_);
145>>>>>>> MERGE-SOURCE
118}146}
119147
120void Controller::SetupWindow()148void Controller::SetupWindow()
@@ -125,6 +153,7 @@
125 window_->ShowWindow(false);153 window_->ShowWindow(false);
126 window_->SetOpacity(0.0f);154 window_->SetOpacity(0.0f);
127 window_->mouse_down_outside_pointer_grab_area.connect(sigc::mem_fun(this, &Controller::OnMouseDownOutsideWindow));155 window_->mouse_down_outside_pointer_grab_area.connect(sigc::mem_fun(this, &Controller::OnMouseDownOutsideWindow));
156<<<<<<< TREE
128157
129 if (nux::GetWindowThread()->IsEmbeddedWindow())158 if (nux::GetWindowThread()->IsEmbeddedWindow())
130 {159 {
@@ -137,6 +166,14 @@
137 window_->EnableInputWindow(false, dash::window_title, true, false);166 window_->EnableInputWindow(false, dash::window_title, true, false);
138 wm.RestoreInputFocus();167 wm.RestoreInputFocus();
139 }168 }
169=======
170
171 /* FIXME - first time we load our windows there is a race that causes the input window not to actually get input, this side steps that by causing an input window show and hide before we really need it. */
172 PluginAdapter::Default()->saveInputFocus ();
173 window_->EnableInputWindow(true, "Dash", true, false);
174 window_->EnableInputWindow(false, "Dash", true, false);
175 PluginAdapter::Default()->restoreInputFocus ();
176>>>>>>> MERGE-SOURCE
140}177}
141178
142void Controller::SetupDashView()179void Controller::SetupDashView()
@@ -306,9 +343,13 @@
306 return;343 return;
307 }344 }
308345
346<<<<<<< TREE
309 monitor_ = GetIdealMonitor();347 monitor_ = GetIdealMonitor();
310348
349=======
350>>>>>>> MERGE-SOURCE
311 view_->AboutToShow();351 view_->AboutToShow();
352 visible_ = true;
312353
313 FocusWindow();354 FocusWindow();
314355
@@ -326,6 +367,7 @@
326void Controller::FocusWindow()367void Controller::FocusWindow()
327{368{
328 window_->ShowWindow(true);369 window_->ShowWindow(true);
370<<<<<<< TREE
329 window_->PushToFront();371 window_->PushToFront();
330 if (nux::GetWindowThread()->IsEmbeddedWindow())372 if (nux::GetWindowThread()->IsEmbeddedWindow())
331 {373 {
@@ -335,9 +377,16 @@
335 window_->UpdateInputWindowGeometry();377 window_->UpdateInputWindowGeometry();
336 }378 }
337 window_->SetInputFocus();379 window_->SetInputFocus();
380=======
381 window_->EnableInputWindow(true, "Dash", true, false);
382 FocusInput();
383
384 window_->CaptureMouseDownAnyWhereElse(true);
385>>>>>>> MERGE-SOURCE
338 window_->QueueDraw();386 window_->QueueDraw();
339387
340 nux::GetWindowCompositor().SetKeyFocusArea(view_->default_focus());388 nux::GetWindowCompositor().SetKeyFocusArea(view_->default_focus());
389<<<<<<< TREE
341}390}
342391
343void Controller::QuicklyHideDash(bool restore)392void Controller::QuicklyHideDash(bool restore)
@@ -345,6 +394,25 @@
345 HideDash(restore);394 HideDash(restore);
346 timeline_animator_.Stop();395 timeline_animator_.Stop();
347 window_->ShowWindow(false);396 window_->ShowWindow(false);
397=======
398
399 need_show_ = false;
400
401 StartShowHideTimeline();
402
403 monitor_ = GetIdealMonitor();
404 GVariant* info = g_variant_new(UBUS_OVERLAY_FORMAT_STRING, "dash", TRUE, monitor_);
405 ubus_manager_.SendMessage(UBUS_OVERLAY_SHOWN, info);
406>>>>>>> MERGE-SOURCE
407}
408
409void Controller::FocusInput()
410{
411 if (visible_)
412 {
413 window_->PushToFront();
414 window_->SetInputFocus();
415 }
348}416}
349417
350void Controller::HideDash(bool restore)418void Controller::HideDash(bool restore)
@@ -402,6 +470,11 @@
402 }470 }
403}471}
404472
473bool Controller::IsVisible() const
474{
475 return visible_;
476}
477
405void Controller::OnActivateRequest(GVariant* variant)478void Controller::OnActivateRequest(GVariant* variant)
406{479{
407 EnsureDash();480 EnsureDash();
@@ -414,11 +487,18 @@
414 std::string scope_id = view_->GetIdForShortcutActivation(std::string(key_string));487 std::string scope_id = view_->GetIdForShortcutActivation(std::string(key_string));
415 if (scope_id != "")488 if (scope_id != "")
416 {489 {
490<<<<<<< TREE
417 WindowManager& wm = WindowManager::Default();491 WindowManager& wm = WindowManager::Default();
418 if (wm.IsScaleActive())492 if (wm.IsScaleActive())
419 wm.TerminateScale();493 wm.TerminateScale();
420494
421 GVariant* args = g_variant_new("(sus)", scope_id.c_str(), dash::GOTO_DASH_URI, "");495 GVariant* args = g_variant_new("(sus)", scope_id.c_str(), dash::GOTO_DASH_URI, "");
496=======
497 if (PluginAdapter::Default()->IsScaleActive())
498 PluginAdapter::Default()->TerminateScale();
499
500 GVariant* args = g_variant_new("(sus)", lens_id.c_str(), dash::GOTO_DASH_URI, "");
501>>>>>>> MERGE-SOURCE
422 OnActivateRequest(args);502 OnActivateRequest(args);
423 g_variant_unref(args);503 g_variant_unref(args);
424 return true;504 return true;
425505
=== modified file 'dash/DashController.h'
--- dash/DashController.h 2013-07-01 21:19:33 +0000
+++ dash/DashController.h 2013-07-24 18:20:41 +0000
@@ -69,6 +69,9 @@
69 bool IsCommandLensOpen() const;69 bool IsCommandLensOpen() const;
70 nux::Geometry GetInputWindowGeometry();70 nux::Geometry GetInputWindowGeometry();
7171
72 void FocusInput();
73 bool IsVisible() const;
74
72protected:75protected:
73 std::string GetName() const;76 std::string GetName() const;
74 void AddProperties(GVariantBuilder* builder);77 void AddProperties(GVariantBuilder* builder);
7578
=== modified file 'dash/DashView.cpp'
--- dash/DashView.cpp 2013-07-01 21:19:33 +0000
+++ dash/DashView.cpp 2013-07-24 18:20:41 +0000
@@ -32,6 +32,7 @@
32#include <UnityCore/RadioOptionFilter.h>32#include <UnityCore/RadioOptionFilter.h>
33#include <UnityCore/PaymentPreview.h>33#include <UnityCore/PaymentPreview.h>
3434
35<<<<<<< TREE
35#include "unity-shared/DashStyle.h"36#include "unity-shared/DashStyle.h"
36#include "unity-shared/KeyboardUtil.h"37#include "unity-shared/KeyboardUtil.h"
37#include "unity-shared/PreviewStyle.h"38#include "unity-shared/PreviewStyle.h"
@@ -39,6 +40,13 @@
39#include "unity-shared/UBusMessages.h"40#include "unity-shared/UBusMessages.h"
40#include "unity-shared/UnitySettings.h"41#include "unity-shared/UnitySettings.h"
41#include "unity-shared/WindowManager.h"42#include "unity-shared/WindowManager.h"
43=======
44#include "DashStyle.h"
45#include "DashSettings.h"
46#include "UBusMessages.h"
47#include "KeyboardUtil.h"
48#include "WindowManager.h"
49>>>>>>> MERGE-SOURCE
4250
43namespace unity51namespace unity
44{52{
@@ -165,6 +173,7 @@
165173
166DashView::~DashView()174DashView::~DashView()
167{175{
176<<<<<<< TREE
168 // Do this explicitely, otherwise dee will complain about invalid access177 // Do this explicitely, otherwise dee will complain about invalid access
169 // to the scope models178 // to the scope models
170 RemoveLayout();179 RemoveLayout();
@@ -177,6 +186,16 @@
177 g_variant_get(data, "(dddd)", &red, &green, &blue, &alpha);186 g_variant_get(data, "(dddd)", &red, &green, &blue, &alpha);
178 background_color_ = nux::Color(red, green, blue, alpha);187 background_color_ = nux::Color(red, green, blue, alpha);
179 QueueDraw();188 QueueDraw();
189=======
190 if (searching_timeout_id_)
191 g_source_remove (searching_timeout_id_);
192 if (hide_message_delay_id_)
193 g_source_remove(hide_message_delay_id_);
194
195 // Do this explicitely, otherwise dee will complain about invalid access
196 // to the lens models
197 RemoveLayout ();
198>>>>>>> MERGE-SOURCE
180}199}
181200
182void DashView::SetMonitorOffset(int x, int y)201void DashView::SetMonitorOffset(int x, int y)
@@ -1079,10 +1098,23 @@
10791098
1080void DashView::OnMouseButtonDown(int x, int y, unsigned long button, unsigned long key)1099void DashView::OnMouseButtonDown(int x, int y, unsigned long button, unsigned long key)
1081{1100{
1101<<<<<<< TREE
1082 dash::Style& style = dash::Style::Instance();1102 dash::Style& style = dash::Style::Instance();
1083 nux::Geometry geo(content_geo_);1103 nux::Geometry geo(content_geo_);
10841104
1085 if (Settings::Instance().form_factor() == FormFactor::DESKTOP)1105 if (Settings::Instance().form_factor() == FormFactor::DESKTOP)
1106=======
1107 dash::Style& style = dash::Style::Instance();
1108 nux::Geometry geo(content_geo_);
1109
1110 if (Settings::Instance().GetFormFactor() == FormFactor::DESKTOP)
1111 {
1112 geo.width += style.GetDashRightTileWidth();
1113 geo.height += style.GetDashBottomTileHeight();
1114 }
1115
1116 if (!geo.IsPointInside(x, y))
1117>>>>>>> MERGE-SOURCE
1086 {1118 {
1087 geo.width += style.GetDashRightTileWidth();1119 geo.width += style.GetDashRightTileWidth();
1088 geo.height += style.GetDashBottomTileHeight();1120 geo.height += style.GetDashBottomTileHeight();
@@ -1097,6 +1129,7 @@
10971129
1098 g_variant_get(args, "(sus)", &uri, &handled_type, &search_string);1130 g_variant_get(args, "(sus)", &uri, &handled_type, &search_string);
10991131
1132<<<<<<< TREE
1100 std::string id(AnalyseScopeURI(uri.Str()));1133 std::string id(AnalyseScopeURI(uri.Str()));
11011134
1102 LOG_DEBUG(logger) << "External activation request: " << id << " (uri: "<< uri.Str() << ")";1135 LOG_DEBUG(logger) << "External activation request: " << id << " (uri: "<< uri.Str() << ")";
@@ -1124,6 +1157,23 @@
1124 if (!visible_)1157 if (!visible_)
1125 ubus_manager_.SendMessage(UBUS_DASH_EXTERNAL_ACTIVATION);1158 ubus_manager_.SendMessage(UBUS_DASH_EXTERNAL_ACTIVATION);
1126 }1159 }
1160=======
1161 std::string id(AnalyseLensURI(uri.Str()));
1162
1163 if (!visible_)
1164 {
1165 lens_bar_->Activate(id);
1166 ubus_manager_.SendMessage(UBUS_DASH_EXTERNAL_ACTIVATION);
1167 }
1168 else if (/* visible_ && */ handled_type == NOT_HANDLED)
1169 {
1170 ubus_manager_.SendMessage(UBUS_PLACE_VIEW_CLOSE_REQUEST);
1171 }
1172 else if (/* visible_ && */ handled_type == GOTO_DASH_URI)
1173 {
1174 lens_bar_->Activate(id);
1175 }
1176>>>>>>> MERGE-SOURCE
1127}1177}
11281178
1129std::string DashView::AnalyseScopeURI(std::string const& uri)1179std::string DashView::AnalyseScopeURI(std::string const& uri)
@@ -1253,8 +1303,20 @@
1253 preview_state_machine_.ActivatePreview(model); // this does not immediately display a preview - we now wait.1303 preview_state_machine_.ActivatePreview(model); // this does not immediately display a preview - we now wait.
1254 });1304 });
12551305
1306<<<<<<< TREE
1256 if (!active_scope_view_)1307 if (!active_scope_view_)
1257 scope_bar_->Activate(scope->id);1308 scope_bar_->Activate(scope->id);
1309=======
1310 // global search done is handled by the home lens, no need to connect to it
1311 // BUT, we will special case global search finished coming from
1312 // the applications lens, because we want to be able to launch applications
1313 // immediately without waiting for the search finished signal which will
1314 // be delayed by all the lenses we're searching
1315 if (id == "applications.lens")
1316 {
1317 lens->global_search_finished.connect(sigc::mem_fun(this, &DashView::OnAppsGlobalSearchFinished));
1318 }
1319>>>>>>> MERGE-SOURCE
1258}1320}
12591321
1260void DashView::OnScopeBarActivated(std::string const& id)1322void DashView::OnScopeBarActivated(std::string const& id)
@@ -1444,12 +1506,17 @@
1444 wrapper.add(nux::Geometry(GetAbsoluteX(), GetAbsoluteY(), content_geo_.width, content_geo_.height));1506 wrapper.add(nux::Geometry(GetAbsoluteX(), GetAbsoluteY(), content_geo_.width, content_geo_.height));
1445 wrapper.add("num_rows", num_rows);1507 wrapper.add("num_rows", num_rows);
1446 wrapper.add("form_factor", form_factor);1508 wrapper.add("form_factor", form_factor);
1509<<<<<<< TREE
1447 wrapper.add("right-border-width", style.GetDashRightTileWidth());1510 wrapper.add("right-border-width", style.GetDashRightTileWidth());
1448 wrapper.add("bottom-border-height", style.GetDashBottomTileHeight());1511 wrapper.add("bottom-border-height", style.GetDashBottomTileHeight());
1449 wrapper.add("preview_displaying", preview_displaying_);1512 wrapper.add("preview_displaying", preview_displaying_);
1450 wrapper.add("preview_animation", animate_split_value_ * animate_preview_container_value_ * animate_preview_value_);1513 wrapper.add("preview_animation", animate_split_value_ * animate_preview_container_value_ * animate_preview_value_);
1451 wrapper.add("dash_maximized", style.always_maximised());1514 wrapper.add("dash_maximized", style.always_maximised());
1452 wrapper.add("overlay_window_buttons_shown", overlay_window_buttons_->IsVisible());1515 wrapper.add("overlay_window_buttons_shown", overlay_window_buttons_->IsVisible());
1516=======
1517 wrapper.add("right-border-width", style.GetDashRightTileWidth());
1518 wrapper.add("bottom-border-height", style.GetDashBottomTileHeight());
1519>>>>>>> MERGE-SOURCE
1453}1520}
14541521
1455nux::Area* DashView::KeyNavIteration(nux::KeyNavDirection direction)1522nux::Area* DashView::KeyNavIteration(nux::KeyNavDirection direction)
@@ -1483,9 +1550,15 @@
1483 ubus_manager_.SendMessage(UBUS_OVERLAY_CLOSE_REQUEST);1550 ubus_manager_.SendMessage(UBUS_OVERLAY_CLOSE_REQUEST);
1484}1551}
14851552
1553<<<<<<< TREE
1486nux::Area* DashView::FindKeyFocusArea(unsigned int key_symbol,1554nux::Area* DashView::FindKeyFocusArea(unsigned int key_symbol,
1487 unsigned long x11_key_code,1555 unsigned long x11_key_code,
1488 unsigned long special_keys_state)1556 unsigned long special_keys_state)
1557=======
1558Area* DashView::FindKeyFocusArea(unsigned int key_symbol,
1559 unsigned long x11_key_code,
1560 unsigned long special_keys_state)
1561>>>>>>> MERGE-SOURCE
1489{1562{
1490 // Only care about states of Alt, Ctrl, Super, Shift, not the lock keys1563 // Only care about states of Alt, Ctrl, Super, Shift, not the lock keys
1491 special_keys_state &= (nux::NUX_STATE_ALT | nux::NUX_STATE_CTRL |1564 special_keys_state &= (nux::NUX_STATE_ALT | nux::NUX_STATE_CTRL |
@@ -1494,8 +1567,12 @@
1494 // Do what nux::View does, but if the event isn't a key navigation,1567 // Do what nux::View does, but if the event isn't a key navigation,
1495 // designate the text entry to process it.1568 // designate the text entry to process it.
14961569
1570<<<<<<< TREE
1497 using namespace nux;1571 using namespace nux;
1498 nux::KeyNavDirection direction = KEY_NAV_NONE;1572 nux::KeyNavDirection direction = KEY_NAV_NONE;
1573=======
1574 nux::KeyNavDirection direction = KEY_NAV_NONE;
1575>>>>>>> MERGE-SOURCE
1499 bool ctrl = (special_keys_state & NUX_STATE_CTRL);1576 bool ctrl = (special_keys_state & NUX_STATE_CTRL);
15001577
1501 switch (x11_key_code)1578 switch (x11_key_code)
@@ -1526,6 +1603,7 @@
1526 direction = KEY_NAV_ENTER;1603 direction = KEY_NAV_ENTER;
1527 break;1604 break;
1528 default:1605 default:
1606<<<<<<< TREE
1529 auto const& close_key = WindowManager::Default().close_window_key();1607 auto const& close_key = WindowManager::Default().close_window_key();
15301608
1531 if (close_key.first == special_keys_state && close_key.second == x11_key_code)1609 if (close_key.first == special_keys_state && close_key.second == x11_key_code)
@@ -1534,12 +1612,25 @@
1534 return nullptr;1612 return nullptr;
1535 }1613 }
15361614
1615=======
1616 auto const& close_key = WindowManager::Default()->close_window_key();
1617
1618 if (close_key.first == special_keys_state && close_key.second == x11_key_code)
1619 {
1620 ubus_manager_.SendMessage(UBUS_PLACE_VIEW_CLOSE_REQUEST);
1621 return nullptr;
1622 }
1623
1624>>>>>>> MERGE-SOURCE
1537 direction = KEY_NAV_NONE;1625 direction = KEY_NAV_NONE;
1626<<<<<<< TREE
1538 }1627 }
15391628
1540 if (preview_displaying_)1629 if (preview_displaying_)
1541 {1630 {
1542 return preview_container_->FindKeyFocusArea(key_symbol, x11_key_code, special_keys_state);1631 return preview_container_->FindKeyFocusArea(key_symbol, x11_key_code, special_keys_state);
1632=======
1633>>>>>>> MERGE-SOURCE
1543 }1634 }
15441635
1545 // We should not do it here, but I really don't want to make DashView1636 // We should not do it here, but I really don't want to make DashView
@@ -1628,6 +1719,7 @@
1628 }1719 }
1629 }1720 }
16301721
1722<<<<<<< TREE
1631 bool search_key = false;1723 bool search_key = false;
16321724
1633 if (direction == KEY_NAV_NONE)1725 if (direction == KEY_NAV_NONE)
@@ -1640,6 +1732,20 @@
1640 }1732 }
16411733
1642 if (!preview_displaying_ && (search_key || search_bar_->im_preedit))1734 if (!preview_displaying_ && (search_key || search_bar_->im_preedit))
1735=======
1736 bool search_key = false;
1737
1738 if (direction == KEY_NAV_NONE)
1739 {
1740 if (ui::KeyboardUtil::IsPrintableKeySymbol(x11_key_code) ||
1741 ui::KeyboardUtil::IsMoveKeySymbol(x11_key_code))
1742 {
1743 search_key = true;
1744 }
1745 }
1746
1747 if (search_key || search_bar_->im_preedit)
1748>>>>>>> MERGE-SOURCE
1643 {1749 {
1644 // then send the event to the search entry1750 // then send the event to the search entry
1645 return search_bar_->text_entry();1751 return search_bar_->text_entry();
@@ -1648,6 +1754,7 @@
1648 {1754 {
1649 return next_object_to_key_focus_area_->FindKeyFocusArea(key_symbol, x11_key_code, special_keys_state);1755 return next_object_to_key_focus_area_->FindKeyFocusArea(key_symbol, x11_key_code, special_keys_state);
1650 }1756 }
1757<<<<<<< TREE
16511758
1652 return nullptr;1759 return nullptr;
1653}1760}
@@ -1676,6 +1783,10 @@
1676nux::Geometry const& DashView::GetContentGeometry() const1783nux::Geometry const& DashView::GetContentGeometry() const
1677{1784{
1678 return content_geo_;1785 return content_geo_;
1786=======
1787
1788 return nullptr;
1789>>>>>>> MERGE-SOURCE
1679}1790}
16801791
1681}1792}
16821793
=== modified file 'dash/PlacesGroup.cpp'
--- dash/PlacesGroup.cpp 2013-05-01 18:11:32 +0000
+++ dash/PlacesGroup.cpp 2013-07-24 18:20:41 +0000
@@ -371,11 +371,17 @@
371void371void
372PlacesGroup::Relayout()372PlacesGroup::Relayout()
373{373{
374<<<<<<< TREE
374 if (_relayout_idle)375 if (_relayout_idle)
375 return;376 return;
376377
377 _relayout_idle.reset(new glib::Idle(glib::Source::Priority::HIGH));378 _relayout_idle.reset(new glib::Idle(glib::Source::Priority::HIGH));
378 _relayout_idle->Run(sigc::mem_fun(this, &PlacesGroup::OnIdleRelayout));379 _relayout_idle->Run(sigc::mem_fun(this, &PlacesGroup::OnIdleRelayout));
380=======
381 if (_idle_id == 0)
382 _idle_id = g_idle_add_full(G_PRIORITY_HIGH,
383 (GSourceFunc)OnIdleRelayout, this, NULL);
384>>>>>>> MERGE-SOURCE
379}385}
380386
381bool387bool
382388
=== modified file 'dash/ResultRendererTile.cpp'
--- dash/ResultRendererTile.cpp 2013-04-30 16:58:48 +0000
+++ dash/ResultRendererTile.cpp 2013-07-24 18:20:41 +0000
@@ -20,9 +20,21 @@
20 *20 *
21 */21 */
2222
23<<<<<<< TREE
24=======
25
26>>>>>>> MERGE-SOURCE
23#include "ResultRendererTile.h"27#include "ResultRendererTile.h"
2428
29<<<<<<< TREE
30=======
31#include <pango/pango.h>
32>>>>>>> MERGE-SOURCE
25#include <pango/pangocairo.h>33#include <pango/pangocairo.h>
34<<<<<<< TREE
35=======
36#include <gtk/gtk.h>
37>>>>>>> MERGE-SOURCE
2638
27#include <NuxCore/Logger.h>39#include <NuxCore/Logger.h>
28#include <UnityCore/GLibWrapper.h>40#include <UnityCore/GLibWrapper.h>
@@ -44,6 +56,12 @@
4456
45namespace57namespace
46{58{
59<<<<<<< TREE
60=======
61nux::logging::Logger logger("unity.dash.results");
62const std::string DEFAULT_GICON = ". GThemedIcon text-x-preview";
63
64>>>>>>> MERGE-SOURCE
47const int FONT_SIZE = 10;65const int FONT_SIZE = 10;
4866
49const float CORNER_HIGHTLIGHT_RADIUS = 2.0f;67const float CORNER_HIGHTLIGHT_RADIUS = 2.0f;
@@ -122,16 +140,32 @@
122 // set up our texture mode140 // set up our texture mode
123 nux::TexCoordXForm texxform;141 nux::TexCoordXForm texxform;
124142
125 int icon_width, icon_height;143<<<<<<< TREE
126 if (container->icon == nullptr)144 int icon_width, icon_height;
127 {145 if (container->icon == nullptr)
128 icon_width = icon_height = tile_icon_size;146 {
129 }147 icon_width = icon_height = tile_icon_size;
130 else148 }
131 {149 else
132 icon_width = container->icon->GetWidth();150 {
133 icon_height = container->icon->GetHeight();151 icon_width = container->icon->GetWidth();
134 }152 icon_height = container->icon->GetHeight();
153 }
154=======
155 int icon_width, icon_height;
156 if (container->icon == nullptr)
157 {
158 icon_width = icon_height = tile_icon_size;
159 }
160 else
161 {
162 icon_width = container->icon->GetWidth();
163 icon_height = container->icon->GetHeight();
164 }
165
166 int icon_left_hand_side = geometry.x + (geometry.width - icon_width) / 2;
167 int icon_top_side = geometry.y + padding + (tile_icon_size - icon_height) / 2;
168>>>>>>> MERGE-SOURCE
135169
136 int icon_left_hand_side = geometry.x + (geometry.width - icon_width) / 2;170 int icon_left_hand_side = geometry.x + (geometry.width - icon_width) / 2;
137 int icon_top_side = geometry.y + padding + (tile_icon_size - icon_height) / 2;171 int icon_top_side = geometry.y + padding + (tile_icon_size - icon_height) / 2;
@@ -210,7 +244,7 @@
210244
211void ResultRendererTile::Preload(Result const& row)245void ResultRendererTile::Preload(Result const& row)
212{246{
213 if (row.renderer<TextureContainer*>() == nullptr)247 if (!row.renderer<TextureContainer*>())
214 {248 {
215 // Shouldn't really do this, but it's safe in this case and quicker than making a copy.249 // Shouldn't really do this, but it's safe in this case and quicker than making a copy.
216 const_cast<Result&>(row).set_renderer(new TextureContainer());250 const_cast<Result&>(row).set_renderer(new TextureContainer());
@@ -221,6 +255,7 @@
221255
222void ResultRendererTile::Unload(Result const& row)256void ResultRendererTile::Unload(Result const& row)
223{257{
258<<<<<<< TREE
224 TextureContainer *container = row.renderer<TextureContainer*>();259 TextureContainer *container = row.renderer<TextureContainer*>();
225 if (container)260 if (container)
226 {261 {
@@ -245,10 +280,31 @@
245}280}
246281
247void ResultRendererTile::LoadIcon(Result const& row)282void ResultRendererTile::LoadIcon(Result const& row)
283=======
284 delete row.renderer<TextureContainer*>();
285 row.set_renderer<TextureContainer*>(nullptr);
286}
287
288void ResultRendererTile::LoadIcon(Result& row)
289>>>>>>> MERGE-SOURCE
248{290{
291 auto container = row.renderer<TextureContainer*>();
292
293 if (!container)
294 {
295 LOG_ERROR(logger) << "No valid container for Result " << row.name() << " with URI "
296 << row.uri();
297 return;
298 }
299
249 Style& style = Style::Instance();300 Style& style = Style::Instance();
301<<<<<<< TREE
250 std::string icon_hint(row.icon_hint);302 std::string icon_hint(row.icon_hint);
303=======
304 std::string const& icon_hint = row.icon_hint;
305>>>>>>> MERGE-SOURCE
251 std::string icon_name;306 std::string icon_name;
307
252 if (G_UNLIKELY(neko))308 if (G_UNLIKELY(neko))
253 {309 {
254 int tmp1 = style.GetTileGIconSize() + (rand() % 16) - 8;310 int tmp1 = style.GetTileGIconSize() + (rand() % 16) - 8;
@@ -264,6 +320,7 @@
264 icon_name = !icon_hint.empty() ? icon_hint : DEFAULT_GICON;320 icon_name = !icon_hint.empty() ? icon_hint : DEFAULT_GICON;
265 }321 }
266322
323<<<<<<< TREE
267 glib::Object<GIcon> icon(g_icon_new_for_string(icon_name.c_str(), NULL));324 glib::Object<GIcon> icon(g_icon_new_for_string(icon_name.c_str(), NULL));
268 TextureContainer* container = row.renderer<TextureContainer*>();325 TextureContainer* container = row.renderer<TextureContainer*>();
269326
@@ -282,9 +339,30 @@
282 bool use_large_icon = icon.IsType(G_TYPE_FILE_ICON) || !icon.IsType(G_TYPE_THEMED_ICON);339 bool use_large_icon = icon.IsType(G_TYPE_FILE_ICON) || !icon.IsType(G_TYPE_THEMED_ICON);
283 container->slot_handle = IconLoader::GetDefault().LoadFromGIconString(icon_name, style.GetTileImageSize(), use_large_icon ? style.GetTileImageSize() : style.GetTileGIconSize(), slot);340 container->slot_handle = IconLoader::GetDefault().LoadFromGIconString(icon_name, style.GetTileImageSize(), use_large_icon ? style.GetTileImageSize() : style.GetTileGIconSize(), slot);
284 }341 }
342=======
343 auto slot = sigc::bind(sigc::mem_fun(this, &ResultRendererTile::IconLoaded), icon_hint, row);
344
345 if (icon_name.find("://") != std::string::npos)
346 {
347 container->slot_handle = IconLoader::GetDefault().LoadFromURI(icon_name, style.GetTileIconSize(), slot);
348 }
349>>>>>>> MERGE-SOURCE
285 else350 else
286 {351 {
352<<<<<<< TREE
287 container->slot_handle = IconLoader::GetDefault().LoadFromIconName(icon_name, -1, style.GetTileGIconSize(), slot);353 container->slot_handle = IconLoader::GetDefault().LoadFromIconName(icon_name, -1, style.GetTileGIconSize(), slot);
354=======
355 glib::Object<GIcon> icon(g_icon_new_for_string(icon_name.c_str(), nullptr));
356
357 if (G_IS_ICON(icon.RawPtr()))
358 {
359 container->slot_handle = IconLoader::GetDefault().LoadFromGIconString(icon_name, style.GetTileIconSize(), slot);
360 }
361 else
362 {
363 container->slot_handle = IconLoader::GetDefault().LoadFromIconName(icon_name, style.GetTileIconSize(), slot);
364 }
365>>>>>>> MERGE-SOURCE
288 }366 }
289}367}
290368
291369
=== modified file 'dash/ResultView.cpp'
--- dash/ResultView.cpp 2013-07-01 21:19:33 +0000
+++ dash/ResultView.cpp 2013-07-24 18:20:41 +0000
@@ -60,6 +60,7 @@
6060
61ResultView::~ResultView()61ResultView::~ResultView()
62{62{
63<<<<<<< TREE
63 for( auto wrapper: introspectable_children_)64 for( auto wrapper: introspectable_children_)
64 {65 {
65 delete wrapper.second;66 delete wrapper.second;
@@ -71,6 +72,15 @@
71 renderer_->Unload(*it);72 renderer_->Unload(*it);
72 }73 }
7374
75=======
76 ClearIntrospectableWrappers();
77
78 for (auto result : results_)
79 {
80 renderer_->Unload(result);
81 }
82
83>>>>>>> MERGE-SOURCE
74 renderer_->UnReference();84 renderer_->UnReference();
75}85}
7686
7787
=== modified file 'dash/ResultViewGrid.cpp'
--- dash/ResultViewGrid.cpp 2013-07-18 18:27:35 +0000
+++ dash/ResultViewGrid.cpp 2013-07-24 18:20:41 +0000
@@ -66,8 +66,15 @@
66 , mouse_over_index_(-1)66 , mouse_over_index_(-1)
67 , active_index_(-1)67 , active_index_(-1)
68 , selected_index_(-1)68 , selected_index_(-1)
69<<<<<<< TREE
69 , last_lazy_loaded_result_(0)70 , last_lazy_loaded_result_(0)
70 , all_results_preloaded_(true)71 , all_results_preloaded_(true)
72=======
73 , preview_row_(0)
74 , last_lazy_loaded_result_ (0)
75 , lazy_load_handle_(0)
76 , view_changed_handle_(0)
77>>>>>>> MERGE-SOURCE
71 , last_mouse_down_x_(-1)78 , last_mouse_down_x_(-1)
72 , last_mouse_down_y_(-1)79 , last_mouse_down_y_(-1)
73 , drag_index_(~0)80 , drag_index_(~0)
@@ -80,13 +87,25 @@
80 EnableDoubleClick(true);87 EnableDoubleClick(true);
81 SetAcceptKeyNavFocusOnMouseDown(false);88 SetAcceptKeyNavFocusOnMouseDown(false);
8289
90<<<<<<< TREE
83 auto needredraw_lambda = [&](int value) { NeedRedraw(); };91 auto needredraw_lambda = [&](int value) { NeedRedraw(); };
92=======
93 auto needredraw_lambda = [&](int value)
94 {
95 NeedRedraw();
96 };
97
98>>>>>>> MERGE-SOURCE
84 horizontal_spacing.changed.connect(needredraw_lambda);99 horizontal_spacing.changed.connect(needredraw_lambda);
85 vertical_spacing.changed.connect(needredraw_lambda);100 vertical_spacing.changed.connect(needredraw_lambda);
86 padding.changed.connect(needredraw_lambda);101 padding.changed.connect(needredraw_lambda);
102<<<<<<< TREE
87 selected_index_.changed.connect(needredraw_lambda);103 selected_index_.changed.connect(needredraw_lambda);
88 expanded.changed.connect([&](bool value) { if (value) all_results_preloaded_ = false; });104 expanded.changed.connect([&](bool value) { if (value) all_results_preloaded_ = false; });
89 results_per_row.changed.connect([&](int value) { if (value > 0) all_results_preloaded_ = false; });105 results_per_row.changed.connect([&](int value) { if (value > 0) all_results_preloaded_ = false; });
106=======
107 selected_index_.changed.connect(needredraw_lambda);
108>>>>>>> MERGE-SOURCE
90109
91 key_nav_focus_change.connect(sigc::mem_fun(this, &ResultViewGrid::OnKeyNavFocusChange));110 key_nav_focus_change.connect(sigc::mem_fun(this, &ResultViewGrid::OnKeyNavFocusChange));
92 key_nav_focus_activate.connect([&] (nux::Area *area)111 key_nav_focus_activate.connect([&] (nux::Area *area)
@@ -179,6 +198,7 @@
179 });198 });
180199
181 SetDndEnabled(true, false);200 SetDndEnabled(true, false);
201<<<<<<< TREE
182}202}
183203
184void ResultViewGrid::Activate(LocalResult const& local_result, int index, ResultView::ActivateType type)204void ResultViewGrid::Activate(LocalResult const& local_result, int index, ResultView::ActivateType type)
@@ -217,10 +237,30 @@
217 guint64 timestamp = nux::GetGraphicsDisplay()->GetCurrentEvent().x11_timestamp;237 guint64 timestamp = nux::GetGraphicsDisplay()->GetCurrentEvent().x11_timestamp;
218 glib::Variant data(g_variant_new("(tiiiiii)", timestamp, column_x, row_y, column_width, row_height, left_results, right_results));238 glib::Variant data(g_variant_new("(tiiiiii)", timestamp, column_x, row_y, column_width, row_height, left_results, right_results));
219 ResultActivated.emit(local_result, type, data);239 ResultActivated.emit(local_result, type, data);
240=======
241}
242
243ResultViewGrid::~ResultViewGrid()
244{
245 if (lazy_load_handle_)
246 g_source_remove(lazy_load_handle_);
247
248 if (view_changed_handle_)
249 g_source_remove(view_changed_handle_);
250}
251
252gboolean ResultViewGrid::OnLazyLoad (gpointer data)
253{
254 ResultViewGrid *self = (ResultViewGrid*)data;
255 self->lazy_load_handle_ = 0;
256 self->DoLazyLoad();
257 return FALSE;
258>>>>>>> MERGE-SOURCE
220}259}
221260
222void ResultViewGrid::QueueLazyLoad()261void ResultViewGrid::QueueLazyLoad()
223{262{
263<<<<<<< TREE
224 if (all_results_preloaded_ || GetNumResults() == 0)264 if (all_results_preloaded_ || GetNumResults() == 0)
225 return;265 return;
226266
@@ -261,6 +301,55 @@
261301
262bool ResultViewGrid::DoLazyLoad()302bool ResultViewGrid::DoLazyLoad()
263{303{
304=======
305 if (lazy_load_handle_ == 0)
306 {
307 lazy_load_handle_ = g_idle_add_full (G_PRIORITY_DEFAULT, (GSourceFunc)(&ResultViewGrid::OnLazyLoad), this, NULL);
308 }
309 last_lazy_loaded_result_ = 0; // we always want to reset the lazy load index here
310}
311
312void ResultViewGrid::QueueViewChanged()
313{
314 if (view_changed_handle_ == 0)
315 {
316 // using G_PRIORITY_HIGH because this needs to happen *before* next draw
317 view_changed_handle_ = g_idle_add_full (G_PRIORITY_HIGH,
318 [](gpointer data) -> gboolean
319 {
320 ResultViewGrid *self = (ResultViewGrid*)data;
321 self->SizeReallocate();
322 self->last_lazy_loaded_result_ = 0; // reset the lazy load index
323 self->DoLazyLoad(); // also calls QueueDraw
324 self->view_changed_handle_ = 0;
325 return FALSE;
326 }, this, NULL);
327 }
328}
329
330void ResultViewGrid::DoLazyLoad()
331{
332 // FIXME - so this code was nice, it would only load the visible entries on the screen
333 // however nux does not give us a good enough indicator right now that we are scrolling,
334 // thus if you scroll more than a screen in one frame, you will end up with at least one frame where
335 // no icons are displayed (they have not been preloaded yet) - it sucked. we should fix this next cycle when we can break api
336 //~ int index = 0;
337//~
338 //~ ResultListBounds visible_bounds = GetVisableResults();
339 //~ int lower_bound = std::get<0>(visible_bounds);
340 //~ int upper_bound = std::get<1>(visible_bounds);
341//~
342 //~ ResultList::iterator it;
343 //~ for (it = results_.begin(); it != results_.end(); it++)
344 //~ {
345 //~ if (index >= lower_bound && index <= upper_bound)
346 //~ {
347 //~ renderer_->Preload((*it));
348 //~ }
349 //~ index++;
350 //~ }
351
352>>>>>>> MERGE-SOURCE
264 util::Timer timer;353 util::Timer timer;
265 bool queue_additional_load = false; // if this is set, we will return early and start loading more next frame354 bool queue_additional_load = false; // if this is set, we will return early and start loading more next frame
266355
@@ -323,16 +412,25 @@
323412
324void ResultViewGrid::AddResult(Result const& result)413void ResultViewGrid::AddResult(Result const& result)
325{414{
415<<<<<<< TREE
326 all_results_preloaded_ = false;416 all_results_preloaded_ = false;
327 QueueResultsChanged();417 QueueResultsChanged();
418=======
419 results_.push_back(result);
420 QueueViewChanged();
421>>>>>>> MERGE-SOURCE
328}422}
329423
330void ResultViewGrid::RemoveResult(Result const& result)424void ResultViewGrid::RemoveResult(Result const& result)
331{425{
332 ResultView::RemoveResult(result);426 ResultView::RemoveResult(result);
427<<<<<<< TREE
333 // removing a result might make a non-preloaded one visible428 // removing a result might make a non-preloaded one visible
334 all_results_preloaded_ = false;429 all_results_preloaded_ = false;
335 QueueResultsChanged();430 QueueResultsChanged();
431=======
432 QueueViewChanged();
433>>>>>>> MERGE-SOURCE
336}434}
337435
338void ResultViewGrid::SizeReallocate()436void ResultViewGrid::SizeReallocate()
@@ -518,6 +616,7 @@
518 break;616 break;
519 }617 }
520618
619<<<<<<< TREE
521 selected_index_ = std::max(0, selected_index_());620 selected_index_ = std::max(0, selected_index_());
522 selected_index_ = std::min(static_cast<int>(num_results - 1), selected_index_());621 selected_index_ = std::min(static_cast<int>(num_results - 1), selected_index_());
523 ResultIterator iter(GetIteratorAtRow(selected_index_));622 ResultIterator iter(GetIteratorAtRow(selected_index_));
@@ -527,15 +626,26 @@
527626
528 int focused_x = std::get<0>(focused_coord);627 int focused_x = std::get<0>(focused_coord);
529 int focused_y = std::get<1>(focused_coord);628 int focused_y = std::get<1>(focused_coord);
629=======
630 selected_index_ = std::max(0, selected_index_());
631 selected_index_ = std::min(static_cast<int>(results_.size() - 1), selected_index_());
632 focused_uri_ = results_[selected_index_].uri;
633
634 int focused_x = (renderer_->width + horizontal_spacing + extra_horizontal_spacing_) * (selected_index_ % items_per_row);
635 int focused_y = (renderer_->height + vertical_spacing) * (selected_index_ / items_per_row);
636>>>>>>> MERGE-SOURCE
530637
531 ubus_.SendMessage(UBUS_RESULT_VIEW_KEYNAV_CHANGED,638 ubus_.SendMessage(UBUS_RESULT_VIEW_KEYNAV_CHANGED,
532 g_variant_new("(iiii)", focused_x, focused_y, renderer_->width(), renderer_->height()));639 g_variant_new("(iiii)", focused_x, focused_y, renderer_->width(), renderer_->height()));
533 selection_change.emit();640 selection_change.emit();
641<<<<<<< TREE
534642
535 if (event_type == nux::NUX_KEYDOWN && event_keysym == XK_Menu)643 if (event_type == nux::NUX_KEYDOWN && event_keysym == XK_Menu)
536 {644 {
537 Activate(focused_result_, selected_index_, ActivateType::PREVIEW);645 Activate(focused_result_, selected_index_, ActivateType::PREVIEW);
538 }646 }
647=======
648>>>>>>> MERGE-SOURCE
539}649}
540650
541nux::Area* ResultViewGrid::KeyNavIteration(nux::KeyNavDirection direction)651nux::Area* ResultViewGrid::KeyNavIteration(nux::KeyNavDirection direction)
@@ -547,7 +657,11 @@
547{657{
548 if (HasKeyFocus())658 if (HasKeyFocus())
549 {659 {
660<<<<<<< TREE
550 if (result_model_ && selected_index_ < 0 && GetNumResults())661 if (result_model_ && selected_index_ < 0 && GetNumResults())
662=======
663 if (selected_index_ < 0 and !results_.empty())
664>>>>>>> MERGE-SOURCE
551 {665 {
552 ResultIterator first_iter(result_model_->model());666 ResultIterator first_iter(result_model_->model());
553 focused_result_ = (*first_iter);667 focused_result_ = (*first_iter);
@@ -592,8 +706,13 @@
592{706{
593 SizeReallocate();707 SizeReallocate();
594 QueueLazyLoad();708 QueueLazyLoad();
709<<<<<<< TREE
595710
596 return ResultView::ComputeContentSize();711 return ResultView::ComputeContentSize();
712=======
713 long ret = ResultView::ComputeContentSize();
714 return ret;
715>>>>>>> MERGE-SOURCE
597}716}
598717
599718
600719
=== modified file 'dash/ResultViewGrid.h'
--- dash/ResultViewGrid.h 2013-05-13 19:24:26 +0000
+++ dash/ResultViewGrid.h 2013-07-24 18:20:41 +0000
@@ -48,6 +48,7 @@
48 nux::Property<int> padding;48 nux::Property<int> padding;
4949
50 sigc::signal<void> selection_change;50 sigc::signal<void> selection_change;
51<<<<<<< TREE
5152
52 virtual int GetSelectedIndex() const;53 virtual int GetSelectedIndex() const;
53 virtual void SetSelectedIndex(int index);54 virtual void SetSelectedIndex(int index);
@@ -59,6 +60,11 @@
59 virtual void RenderResultTexture(ResultViewTexture::Ptr const& result_texture);60 virtual void RenderResultTexture(ResultViewTexture::Ptr const& result_texture);
6061
61 virtual void GetResultDimensions(int& rows, int& columns);62 virtual void GetResultDimensions(int& rows, int& columns);
63=======
64
65 int GetSelectedIndex();
66 virtual uint GetIndexAtPosition(int x, int y);
67>>>>>>> MERGE-SOURCE
6268
63protected:69protected:
64 void MouseMove(int x, int y, int dx, int dy, unsigned long button_flags, unsigned long key_flags);70 void MouseMove(int x, int y, int dx, int dy, unsigned long button_flags, unsigned long key_flags);
@@ -94,19 +100,33 @@
94 typedef std::tuple <int, int> ResultListBounds;100 typedef std::tuple <int, int> ResultListBounds;
95 ResultListBounds GetVisableResults();101 ResultListBounds GetVisableResults();
96102
103<<<<<<< TREE
97 void DrawRow(nux::GraphicsEngine& GfxContext, ResultListBounds const& visible_bounds, int row_index, int y_position, nux::Geometry const& absolute_position);104 void DrawRow(nux::GraphicsEngine& GfxContext, ResultListBounds const& visible_bounds, int row_index, int y_position, nux::Geometry const& absolute_position);
98105
106=======
107 static gboolean OnLazyLoad(gpointer data);
108>>>>>>> MERGE-SOURCE
99 void QueueLazyLoad();109 void QueueLazyLoad();
110<<<<<<< TREE
100 void QueueResultsChanged();111 void QueueResultsChanged();
101 bool DoLazyLoad();112 bool DoLazyLoad();
113=======
114 void QueueViewChanged();
115 void DoLazyLoad();
116>>>>>>> MERGE-SOURCE
102117
103 int GetItemsPerRow();118 int GetItemsPerRow();
104 void SizeReallocate();119 void SizeReallocate();
120<<<<<<< TREE
105 std::tuple<int, int> GetResultPosition(LocalResult const& local_result);121 std::tuple<int, int> GetResultPosition(LocalResult const& local_result);
106 std::tuple<int, int> GetResultPosition(const unsigned int& index);122 std::tuple<int, int> GetResultPosition(const unsigned int& index);
123=======
124 void PositionPreview();
125>>>>>>> MERGE-SOURCE
107126
108 unsigned mouse_over_index_;127 unsigned mouse_over_index_;
109 int active_index_;128 int active_index_;
129<<<<<<< TREE
110 nux::Property<int> selected_index_;130 nux::Property<int> selected_index_;
111 LocalResult focused_result_;131 LocalResult focused_result_;
112132
@@ -114,6 +134,15 @@
114134
115 unsigned last_lazy_loaded_result_;135 unsigned last_lazy_loaded_result_;
116 bool all_results_preloaded_;136 bool all_results_preloaded_;
137=======
138 nux::Property<int> selected_index_;
139 uint preview_row_;
140 std::string focused_uri_;
141
142 int last_lazy_loaded_result_;
143 unsigned lazy_load_handle_;
144 unsigned view_changed_handle_;
145>>>>>>> MERGE-SOURCE
117 int last_mouse_down_x_;146 int last_mouse_down_x_;
118 int last_mouse_down_y_;147 int last_mouse_down_y_;
119 LocalResult current_drag_result_;148 LocalResult current_drag_result_;
120149
=== modified file 'dash/ScopeBar.cpp'
--- dash/ScopeBar.cpp 2013-07-12 10:26:02 +0000
+++ dash/ScopeBar.cpp 2013-07-24 18:20:41 +0000
@@ -23,11 +23,16 @@
23#include <Nux/HLayout.h>23#include <Nux/HLayout.h>
24#include <Nux/LayeredLayout.h>24#include <Nux/LayeredLayout.h>
2525
26<<<<<<< TREE
26#include "unity-shared/DashStyle.h"27#include "unity-shared/DashStyle.h"
27#include "unity-shared/StaticCairoText.h"28#include "unity-shared/StaticCairoText.h"
28#include "unity-shared/CairoTexture.h"29#include "unity-shared/CairoTexture.h"
29#include "unity-shared/GraphicsUtils.h"30#include "unity-shared/GraphicsUtils.h"
30#include "unity-shared/UBusMessages.h"31#include "unity-shared/UBusMessages.h"
32=======
33#include "CairoTexture.h"
34#include "LensBar.h"
35>>>>>>> MERGE-SOURCE
3136
32namespace unity37namespace unity
33{38{
@@ -66,6 +71,7 @@
66 layout_->SetContentDistribution(nux::MAJOR_POSITION_CENTER);71 layout_->SetContentDistribution(nux::MAJOR_POSITION_CENTER);
67 SetLayout(layout_);72 SetLayout(layout_);
6873
74<<<<<<< TREE
69 SetMinimumHeight(SCOPEBAR_HEIGHT);75 SetMinimumHeight(SCOPEBAR_HEIGHT);
70 SetMaximumHeight(SCOPEBAR_HEIGHT);76 SetMaximumHeight(SCOPEBAR_HEIGHT);
71}77}
@@ -85,6 +91,39 @@
85}91}
8692
87void ScopeBar::Activate(std::string id)93void ScopeBar::Activate(std::string id)
94=======
95 SetMinimumHeight(LENSBAR_HEIGHT);
96 SetMaximumHeight(LENSBAR_HEIGHT);
97}
98
99void LensBar::SetupHomeLens()
100{
101 LensBarIcon* icon = new LensBarIcon("home.lens", PKGDATADIR"/lens-nav-home.svg");
102 icon->SetVisible(true);
103 icon->active = true;
104 icons_.push_back(icon);
105 layout_->AddView(icon, 0, nux::eCenter, nux::MINOR_SIZE_FULL);
106 AddChild(icon);
107
108 icon->mouse_click.connect([&, icon] (int x, int y, unsigned long button, unsigned long keyboard) { SetActive(icon); });
109 icon->key_nav_focus_activate.connect([&, icon](nux::Area*){ SetActive(icon); });
110}
111
112void LensBar::AddLens(Lens::Ptr& lens)
113{
114 LensBarIcon* icon = new LensBarIcon(lens->id, lens->icon_hint);
115 icon->SetVisible(lens->visible);
116 lens->visible.changed.connect([icon](bool visible) { icon->SetVisible(visible); } );
117 icons_.push_back(icon);
118 layout_->AddView(icon, 0, nux::eCenter, nux::eFix);
119 AddChild(icon);
120
121 icon->mouse_click.connect([&, icon] (int x, int y, unsigned long button, unsigned long keyboard) { SetActive(icon); });
122 icon->key_nav_focus_activate.connect([&, icon](nux::Area*){ SetActive(icon); });
123}
124
125void LensBar::Activate(std::string id)
126>>>>>>> MERGE-SOURCE
88{127{
89 for (auto icon: icons_)128 for (auto icon: icons_)
90 {129 {
@@ -100,6 +139,7 @@
100{139{
101 nux::Geometry const& base = GetGeometry();140 nux::Geometry const& base = GetGeometry();
102141
142<<<<<<< TREE
103 graphics_engine.PushClippingRectangle(base);143 graphics_engine.PushClippingRectangle(base);
104144
105 if (RedirectedAncestor())145 if (RedirectedAncestor())
@@ -112,6 +152,15 @@
112 }152 }
113153
114 graphics_engine.PopClippingRectangle();154 graphics_engine.PopClippingRectangle();
155=======
156 gfx_context.PushClippingRectangle(base);
157 nux::GetPainter().PaintBackground(gfx_context, base);
158
159 bg_layer_->SetGeometry(base);
160 nux::GetPainter().RenderSinglePaintLayer(gfx_context, base, bg_layer_.get());
161
162 gfx_context.PopClippingRectangle();
163>>>>>>> MERGE-SOURCE
115}164}
116165
117void ScopeBar::DrawContent(nux::GraphicsEngine& graphics_engine, bool force_draw)166void ScopeBar::DrawContent(nux::GraphicsEngine& graphics_engine, bool force_draw)
118167
=== modified file 'dash/ScopeBarIcon.cpp'
--- dash/ScopeBarIcon.cpp 2013-02-12 11:45:57 +0000
+++ dash/ScopeBarIcon.cpp 2013-07-24 18:20:41 +0000
@@ -56,8 +56,13 @@
56 SetAcceptKeyNavFocusOnMouseDown(false);56 SetAcceptKeyNavFocusOnMouseDown(false);
57 SetAcceptKeyNavFocusOnMouseEnter(true);57 SetAcceptKeyNavFocusOnMouseEnter(true);
5858
59<<<<<<< TREE
59 active.changed.connect(sigc::mem_fun(this, &ScopeBarIcon::OnActiveChanged));60 active.changed.connect(sigc::mem_fun(this, &ScopeBarIcon::OnActiveChanged));
60 key_nav_focus_change.connect([&](nux::Area*, bool, nux::KeyNavDirection){ QueueDraw(); });61 key_nav_focus_change.connect([&](nux::Area*, bool, nux::KeyNavDirection){ QueueDraw(); });
62=======
63 active.changed.connect(sigc::mem_fun(this, &LensBarIcon::OnActiveChanged));
64 key_nav_focus_change.connect([&](nux::Area*, bool, nux::KeyNavDirection){ QueueDraw(); });
65>>>>>>> MERGE-SOURCE
61}66}
6267
63ScopeBarIcon::~ScopeBarIcon()68ScopeBarIcon::~ScopeBarIcon()
6469
=== modified file 'hud/HudButton.cpp'
--- hud/HudButton.cpp 2012-12-14 12:14:34 +0000
+++ hud/HudButton.cpp 2013-07-24 18:20:41 +0000
@@ -33,8 +33,13 @@
33#include <UnityCore/GLibWrapper.h>33#include <UnityCore/GLibWrapper.h>
34#include <UnityCore/Variant.h>34#include <UnityCore/Variant.h>
3535
36<<<<<<< TREE
36#include "unity-shared/DashStyle.h"37#include "unity-shared/DashStyle.h"
37#include "unity-shared/StaticCairoText.h"38#include "unity-shared/StaticCairoText.h"
39=======
40#include "DashStyle.h"
41#include "StaticCairoText.h"
42>>>>>>> MERGE-SOURCE
3843
39#include "HudButton.h"44#include "HudButton.h"
40#include "HudPrivate.h"45#include "HudPrivate.h"
@@ -42,8 +47,15 @@
42DECLARE_LOGGER(logger, "unity.hud.button");47DECLARE_LOGGER(logger, "unity.hud.button");
43namespace48namespace
44{49{
45const int hlayout_left_padding = 46;50<<<<<<< TREE
46const char* const button_font = "Ubuntu 13"; // 17px = 1351const int hlayout_left_padding = 46;
52const char* const button_font = "Ubuntu 13"; // 17px = 13
53=======
54nux::logging::Logger logger("unity.hud.HudButton");
55
56const int hlayout_left_padding = 46;
57const char* const button_font = "Ubuntu 13"; // 17px = 13
58>>>>>>> MERGE-SOURCE
47}59}
4860
49namespace unity61namespace unity
@@ -51,6 +63,7 @@
51namespace hud63namespace hud
52{64{
5365
66<<<<<<< TREE
54NUX_IMPLEMENT_OBJECT_TYPE(HudButton);67NUX_IMPLEMENT_OBJECT_TYPE(HudButton);
5568
56HudButton::HudButton(NUX_FILE_LINE_DECL)69HudButton::HudButton(NUX_FILE_LINE_DECL)
@@ -63,6 +76,20 @@
63 hlayout_->SetLeftAndRightPadding(hlayout_left_padding, -1);76 hlayout_->SetLeftAndRightPadding(hlayout_left_padding, -1);
64 SetLayout(hlayout_);77 SetLayout(hlayout_);
6578
79=======
80NUX_IMPLEMENT_OBJECT_TYPE(HudButton);
81
82HudButton::HudButton (NUX_FILE_LINE_DECL)
83 : nux::Button (NUX_FILE_LINE_PARAM)
84 , is_rounded(false)
85 , is_focused_(false)
86 , skip_draw_(true)
87{
88 hlayout_ = new nux::HLayout(NUX_TRACKER_LOCATION);
89 hlayout_->SetLeftAndRightPadding(hlayout_left_padding, -1);
90 SetLayout(hlayout_);
91
92>>>>>>> MERGE-SOURCE
66 InitTheme();93 InitTheme();
6794
68 key_nav_focus_change.connect([&](nux::Area*, bool, nux::KeyNavDirection)95 key_nav_focus_change.connect([&](nux::Area*, bool, nux::KeyNavDirection)
@@ -92,6 +119,9 @@
92 });119 });
93}120}
94121
122HudButton::~HudButton() {
123}
124
95void HudButton::InitTheme()125void HudButton::InitTheme()
96{126{
97 is_rounded.changed.connect([&](bool)127 is_rounded.changed.connect([&](bool)
@@ -212,6 +242,7 @@
212{242{
213 query_ = query;243 query_ = query;
214 label = query->formatted_text;244 label = query->formatted_text;
245<<<<<<< TREE
215246
216 auto items(impl::RefactorText(label));247 auto items(impl::RefactorText(label));
217248
@@ -224,6 +255,19 @@
224 text->SetInputEventSensitivity(false);255 text->SetInputEventSensitivity(false);
225 hlayout_->AddView(text, 0, nux::MINOR_POSITION_CENTER, nux::MINOR_SIZE_FULL);256 hlayout_->AddView(text, 0, nux::MINOR_POSITION_CENTER, nux::MINOR_SIZE_FULL);
226 }257 }
258=======
259
260 auto items(impl::RefactorText(label()));
261
262 hlayout_->Clear();
263 for (auto item : items)
264 {
265 nux::StaticCairoText* text = new nux::StaticCairoText(item.first);
266 text->SetTextColor(nux::Color(1.0f, 1.0f, 1.0f, item.second ? 1.0f : 0.5f));
267 text->SetFont(button_font);
268 hlayout_->AddView(text, 0, nux::MINOR_POSITION_CENTER, nux::MINOR_SIZE_FULL);
269 }
270>>>>>>> MERGE-SOURCE
227}271}
228272
229Query::Ptr HudButton::GetQuery()273Query::Ptr HudButton::GetQuery()
@@ -246,8 +290,12 @@
246void HudButton::AddProperties(GVariantBuilder* builder)290void HudButton::AddProperties(GVariantBuilder* builder)
247{291{
248 variant::BuilderWrapper(builder)292 variant::BuilderWrapper(builder)
293<<<<<<< TREE
249 .add("label", label())294 .add("label", label())
250 .add("focused", fake_focused());295 .add("focused", fake_focused());
296=======
297 .add("label", label());
298>>>>>>> MERGE-SOURCE
251}299}
252300
253} // namespace hud301} // namespace hud
254302
=== modified file 'hud/HudButton.h'
--- hud/HudButton.h 2012-06-27 21:32:48 +0000
+++ hud/HudButton.h 2013-07-24 18:20:41 +0000
@@ -27,6 +27,7 @@
27#include <Nux/Button.h>27#include <Nux/Button.h>
28#include <Nux/TextureArea.h>28#include <Nux/TextureArea.h>
29#include <UnityCore/Hud.h>29#include <UnityCore/Hud.h>
30<<<<<<< TREE
30#include "unity-shared/Introspectable.h"31#include "unity-shared/Introspectable.h"
3132
32namespace nux { class HLayout; }33namespace nux { class HLayout; }
@@ -36,15 +37,34 @@
36namespace hud37namespace hud
37{38{
3839
40=======
41
42#include "Introspectable.h"
43
44namespace nux { class HLayout; }
45
46namespace unity
47{
48namespace hud
49{
50
51>>>>>>> MERGE-SOURCE
39class HudButton : public nux::Button, public unity::debug::Introspectable 52class HudButton : public nux::Button, public unity::debug::Introspectable
40{53{
41 NUX_DECLARE_OBJECT_TYPE(HudButton, nux::Button);54 NUX_DECLARE_OBJECT_TYPE(HudButton, nux::Button);
4255
43public:56public:
44 typedef nux::ObjectPtr<HudButton> Ptr;57 typedef nux::ObjectPtr<HudButton> Ptr;
58<<<<<<< TREE
4559
46 HudButton(NUX_FILE_LINE_PROTO);60 HudButton(NUX_FILE_LINE_PROTO);
4761
62=======
63
64 HudButton (NUX_FILE_LINE_PROTO);
65 virtual ~HudButton();
66
67>>>>>>> MERGE-SOURCE
48 void SetQuery(Query::Ptr query);68 void SetQuery(Query::Ptr query);
49 std::shared_ptr<Query> GetQuery();69 std::shared_ptr<Query> GetQuery();
5070
@@ -62,8 +82,13 @@
6282
63 std::string GetName() const;83 std::string GetName() const;
64 void AddProperties(GVariantBuilder* builder);84 void AddProperties(GVariantBuilder* builder);
85<<<<<<< TREE
65 86
66 void InitTheme();87 void InitTheme();
88=======
89
90 void InitTheme();
91>>>>>>> MERGE-SOURCE
67 void RedrawTheme(nux::Geometry const& geom, cairo_t* cr, nux::ButtonVisualState faked_state);92 void RedrawTheme(nux::Geometry const& geom, cairo_t* cr, nux::ButtonVisualState faked_state);
6893
69private:94private:
7095
=== modified file 'hud/HudController.cpp'
--- hud/HudController.cpp 2013-03-20 01:14:35 +0000
+++ hud/HudController.cpp 2013-07-24 18:20:41 +0000
@@ -16,11 +16,14 @@
16 * Authored by: Gord Allott <gord.allott@canonical.com>16 * Authored by: Gord Allott <gord.allott@canonical.com>
17 */17 */
1818
19#include <config.h>
20
19#include "HudController.h"21#include "HudController.h"
2022
21#include <NuxCore/Logger.h>23#include <NuxCore/Logger.h>
22#include <Nux/HLayout.h>24#include <Nux/HLayout.h>
23#include <UnityCore/Variant.h>25#include <UnityCore/Variant.h>
26<<<<<<< TREE
2427
25#include "unity-shared/ApplicationManager.h"28#include "unity-shared/ApplicationManager.h"
26#include "unity-shared/WindowManager.h"29#include "unity-shared/WindowManager.h"
@@ -30,15 +33,33 @@
3033
31#include "config.h"34#include "config.h"
3235
36=======
37#include "WindowManager.h"
38#include "PanelStyle.h"
39#include "UBusMessages.h"
40#include "UScreen.h"
41
42#include <libbamf/libbamf.h>
43>>>>>>> MERGE-SOURCE
3344
34namespace unity45namespace unity
35{46{
36namespace hud47namespace hud
37{48{
49<<<<<<< TREE
38DECLARE_LOGGER(logger, "unity.hud.controller");50DECLARE_LOGGER(logger, "unity.hud.controller");
3951
40Controller::Controller(Controller::ViewCreator const& create_view,52Controller::Controller(Controller::ViewCreator const& create_view,
41 Controller::WindowCreator const& create_window)53 Controller::WindowCreator const& create_window)
54=======
55
56namespace
57{
58nux::logging::Logger logger("unity.hud.controller");
59}
60
61Controller::Controller(std::function<AbstractView*(void)> const& function)
62>>>>>>> MERGE-SOURCE
42 : launcher_width(64)63 : launcher_width(64)
43 , launcher_locked_out(false)64 , launcher_locked_out(false)
44 , multiple_launchers(true)65 , multiple_launchers(true)
@@ -47,9 +68,14 @@
47 , need_show_(false)68 , need_show_(false)
48 , view_(nullptr)69 , view_(nullptr)
49 , monitor_index_(0)70 , monitor_index_(0)
71<<<<<<< TREE
50 , create_view_(create_view)72 , create_view_(create_view)
51 , create_window_(create_window)73 , create_window_(create_window)
52 , timeline_animator_(90)74 , timeline_animator_(90)
75=======
76 , type_wait_handle_(0)
77 , view_function_(function)
78>>>>>>> MERGE-SOURCE
53{79{
54 LOG_DEBUG(logger) << "hud startup";80 LOG_DEBUG(logger) << "hud startup";
5581
@@ -97,9 +123,15 @@
97123
98 launcher_width.changed.connect([&] (int new_width) { Relayout(); });124 launcher_width.changed.connect([&] (int new_width) { Relayout(); });
99125
126<<<<<<< TREE
100 WindowManager& wm = WindowManager::Default();127 WindowManager& wm = WindowManager::Default();
101 wm.screen_ungrabbed.connect(sigc::mem_fun(this, &Controller::OnScreenUngrabbed));128 wm.screen_ungrabbed.connect(sigc::mem_fun(this, &Controller::OnScreenUngrabbed));
102 wm.initiate_spread.connect(sigc::bind(sigc::mem_fun(this, &Controller::HideHud), true));129 wm.initiate_spread.connect(sigc::bind(sigc::mem_fun(this, &Controller::HideHud), true));
130=======
131 auto wm = WindowManager::Default();
132 wm->compiz_screen_ungrabbed.connect(sigc::mem_fun(this, &Controller::OnScreenUngrabbed));
133 wm->initiate_spread.connect(sigc::bind(sigc::mem_fun(this, &Controller::HideHud), true));
134>>>>>>> MERGE-SOURCE
103135
104 hud_service_.queries_updated.connect(sigc::mem_fun(this, &Controller::OnQueriesFinished));136 hud_service_.queries_updated.connect(sigc::mem_fun(this, &Controller::OnQueriesFinished));
105 timeline_animator_.updated.connect(sigc::mem_fun(this, &Controller::OnViewShowHideFrame));137 timeline_animator_.updated.connect(sigc::mem_fun(this, &Controller::OnViewShowHideFrame));
@@ -107,6 +139,25 @@
107 EnsureHud();139 EnsureHud();
108}140}
109141
142<<<<<<< TREE
143=======
144Controller::~Controller()
145{
146 if (window_)
147 window_->UnReference();
148 window_ = 0;
149
150 if (timeline_id_)
151 g_source_remove(timeline_id_);
152
153 if (ensure_id_)
154 g_source_remove(ensure_id_);
155
156 if (type_wait_handle_)
157 g_source_remove(type_wait_handle_);
158}
159
160>>>>>>> MERGE-SOURCE
110void Controller::SetupWindow()161void Controller::SetupWindow()
111{162{
112 // Since BaseWindow is a View it is initially unowned. This means that the first163 // Since BaseWindow is a View it is initially unowned. This means that the first
@@ -117,6 +168,7 @@
117 window_->SetConfigureNotifyCallback(&Controller::OnWindowConfigure, this);168 window_->SetConfigureNotifyCallback(&Controller::OnWindowConfigure, this);
118 window_->ShowWindow(false);169 window_->ShowWindow(false);
119 window_->SetOpacity(0.0f);170 window_->SetOpacity(0.0f);
171<<<<<<< TREE
120 window_->mouse_down_outside_pointer_grab_area.connect(172 window_->mouse_down_outside_pointer_grab_area.connect(
121 sigc::mem_fun(this, &Controller::OnMouseDownOutsideWindow));173 sigc::mem_fun(this, &Controller::OnMouseDownOutsideWindow));
122174
@@ -131,12 +183,26 @@
131 window_->EnableInputWindow(false, "Hud", true, false);183 window_->EnableInputWindow(false, "Hud", true, false);
132 wm.RestoreInputFocus();184 wm.RestoreInputFocus();
133 }185 }
186=======
187 window_->mouse_down_outside_pointer_grab_area.connect(sigc::mem_fun(this, &Controller::OnMouseDownOutsideWindow));
188
189 /* FIXME - first time we load our windows there is a race that causes the input window not to actually get input, this side steps that by causing an input window show and hide before we really need it. */
190 auto wm = WindowManager::Default();
191 wm->saveInputFocus ();
192 window_->EnableInputWindow(true, "Hud", true, false);
193 window_->EnableInputWindow(false, "Hud", true, false);
194 wm->restoreInputFocus ();
195>>>>>>> MERGE-SOURCE
134}196}
135197
136void Controller::SetupHudView()198void Controller::SetupHudView()
137{199{
138 LOG_DEBUG(logger) << "SetupHudView called";200 LOG_DEBUG(logger) << "SetupHudView called";
201<<<<<<< TREE
139 view_ = create_view_();202 view_ = create_view_();
203=======
204 view_ = view_function_();
205>>>>>>> MERGE-SOURCE
140206
141 layout_ = new nux::VLayout(NUX_TRACKER_LOCATION);207 layout_ = new nux::VLayout(NUX_TRACKER_LOCATION);
142 layout_->AddView(view_, 1, nux::MINOR_POSITION_START);208 layout_->AddView(view_, 1, nux::MINOR_POSITION_START);
@@ -322,7 +388,11 @@
322388
323void Controller::ShowHud()389void Controller::ShowHud()
324{390{
391<<<<<<< TREE
325 WindowManager& wm = WindowManager::Default();392 WindowManager& wm = WindowManager::Default();
393=======
394 WindowManager* adaptor = WindowManager::Default();
395>>>>>>> MERGE-SOURCE
326 LOG_DEBUG(logger) << "Showing the hud";396 LOG_DEBUG(logger) << "Showing the hud";
327 EnsureHud();397 EnsureHud();
328398
@@ -346,6 +416,7 @@
346 view_->ShowEmbeddedIcon(!IsLockedToLauncher(monitor_index_));416 view_->ShowEmbeddedIcon(!IsLockedToLauncher(monitor_index_));
347 view_->AboutToShow();417 view_->AboutToShow();
348418
419<<<<<<< TREE
349 ApplicationManager& app_manager = ApplicationManager::Default();420 ApplicationManager& app_manager = ApplicationManager::Default();
350 ApplicationPtr active_application;421 ApplicationPtr active_application;
351 ApplicationWindowPtr active_window = app_manager.GetActiveWindow();422 ApplicationWindowPtr active_window = app_manager.GetActiveWindow();
@@ -355,6 +426,54 @@
355 if (active_application)426 if (active_application)
356 {427 {
357 focused_app_icon_ = active_application->icon();428 focused_app_icon_ = active_application->icon();
429=======
430 // We first want to grab the currently active window
431 glib::Object<BamfMatcher> matcher(bamf_matcher_get_default());
432 BamfWindow* active_win = bamf_matcher_get_active_window(matcher);
433
434 Window active_xid = bamf_window_get_xid(active_win);
435 std::vector<Window> const& unity_xids = nux::XInputWindow::NativeHandleList();
436
437 // If the active window is an unity window, we must get the top-most valid window
438 if (std::find(unity_xids.begin(), unity_xids.end(), active_xid) != unity_xids.end())
439 {
440 // Windows list stack for all the monitors
441 GList *windows = bamf_matcher_get_window_stack_for_monitor(matcher, -1);
442
443 // Reset values, in case we can't find a window ie. empty current desktop
444 active_xid = 0;
445 active_win = nullptr;
446
447 for (GList *l = windows; l; l = l->next)
448 {
449 if (!BAMF_IS_WINDOW(l->data))
450 continue;
451
452 auto win = static_cast<BamfWindow*>(l->data);
453 auto view = static_cast<BamfView*>(l->data);
454 Window xid = bamf_window_get_xid(win);
455
456 if (bamf_view_user_visible(view) && bamf_window_get_window_type(win) != BAMF_WINDOW_DOCK &&
457 WindowManager::Default()->IsWindowOnCurrentDesktop(xid) &&
458 WindowManager::Default()->IsWindowVisible(xid) &&
459 std::find(unity_xids.begin(), unity_xids.end(), xid) == unity_xids.end())
460 {
461 active_win = win;
462 active_xid = xid;
463 }
464 }
465
466 g_list_free(windows);
467 }
468
469 BamfApplication* active_app = bamf_matcher_get_application_for_window(matcher, active_win);
470
471 if (BAMF_IS_VIEW(active_app))
472 {
473 auto active_view = reinterpret_cast<BamfView*>(active_app);
474 glib::String view_icon(bamf_view_get_icon(active_view));
475 focused_app_icon_ = view_icon.Str();
476>>>>>>> MERGE-SOURCE
358 }477 }
359 else478 else
360 {479 {
@@ -362,14 +481,28 @@
362 }481 }
363482
364 LOG_DEBUG(logger) << "Taking application icon: " << focused_app_icon_;483 LOG_DEBUG(logger) << "Taking application icon: " << focused_app_icon_;
365 SetIcon(focused_app_icon_);484<<<<<<< TREE
366485 SetIcon(focused_app_icon_);
486=======
487 SetIcon(focused_app_icon_);
488
489 visible_ = true;
490>>>>>>> MERGE-SOURCE
491
492<<<<<<< TREE
367 WindowManager::Default().SaveInputFocus();493 WindowManager::Default().SaveInputFocus();
368 FocusWindow();494 FocusWindow();
495=======
496 window_->ShowWindow(true);
497 window_->EnableInputWindow(true, "Hud", true, false);
498 FocusInput();
499 window_->CaptureMouseDownAnyWhereElse(true);
500 view_->CaptureMouseDownAnyWhereElse(true);
501 window_->QueueDraw();
502>>>>>>> MERGE-SOURCE
369503
370 view_->ResetToDefault();504 view_->ResetToDefault();
371 need_show_ = true;505 need_show_ = true;
372 visible_ = true;
373506
374 StartShowHideTimeline();507 StartShowHideTimeline();
375508
@@ -386,6 +519,7 @@
386 window_->SetEnterFocusInputArea(view_->default_focus());519 window_->SetEnterFocusInputArea(view_->default_focus());
387}520}
388521
522<<<<<<< TREE
389void Controller::FocusWindow()523void Controller::FocusWindow()
390{524{
391 window_->ShowWindow(true);525 window_->ShowWindow(true);
@@ -401,6 +535,17 @@
401 window_->QueueDraw();535 window_->QueueDraw();
402}536}
403537
538=======
539void Controller::FocusInput()
540{
541 if (visible_)
542 {
543 window_->PushToFront();
544 window_->SetInputFocus();
545 }
546}
547
548>>>>>>> MERGE-SOURCE
404void Controller::HideHud(bool restore)549void Controller::HideHud(bool restore)
405{550{
406 LOG_DEBUG (logger) << "hiding the hud";551 LOG_DEBUG (logger) << "hiding the hud";
@@ -420,7 +565,11 @@
420565
421 restore = true;566 restore = true;
422 if (restore)567 if (restore)
568<<<<<<< TREE
423 WindowManager::Default().RestoreInputFocus();569 WindowManager::Default().RestoreInputFocus();
570=======
571 WindowManager::Default ()->restoreInputFocus ();
572>>>>>>> MERGE-SOURCE
424573
425 hud_service_.CloseQuery();574 hud_service_.CloseQuery();
426575
@@ -444,8 +593,25 @@
444 }593 }
445 else594 else
446 {595 {
596<<<<<<< TREE
447 if (visible_)597 if (visible_)
448 timeline_animator_.SetStartValue(0.0f).SetFinishValue(1.0f).Start();598 timeline_animator_.SetStartValue(0.0f).SetFinishValue(1.0f).Start();
599=======
600 self->window_->SetOpacity(last_opacity - (last_opacity * progress));
601 }
602
603 if (diff > LENGTH)
604 {
605 self->timeline_id_ = 0;
606
607 // Make sure the state is right
608 self->window_->SetOpacity(self->visible_ ? 1.0f : 0.0f);
609 if (!self->visible_)
610 {
611 self->window_->ShowWindow(false);
612 self->view_->ResetToDefault();
613 }
614>>>>>>> MERGE-SOURCE
449 else615 else
450 timeline_animator_.SetStartValue(1.0f).SetFinishValue(0.0f).Start();616 timeline_animator_.SetStartValue(1.0f).SetFinishValue(0.0f).Start();
451 }617 }
452618
=== modified file 'hud/HudController.h'
--- hud/HudController.h 2012-12-13 03:17:19 +0000
+++ hud/HudController.h 2013-07-24 18:20:41 +0000
@@ -47,8 +47,13 @@
47 typedef std::function<AbstractView*()> ViewCreator;47 typedef std::function<AbstractView*()> ViewCreator;
48 typedef std::function<ResizingBaseWindow*()> WindowCreator;48 typedef std::function<ResizingBaseWindow*()> WindowCreator;
4949
50<<<<<<< TREE
50 Controller(ViewCreator const& create_view = nullptr,51 Controller(ViewCreator const& create_view = nullptr,
51 WindowCreator const& create_window = nullptr);52 WindowCreator const& create_window = nullptr);
53=======
54 Controller(std::function<AbstractView*(void)> const& function = []() { return new View; });
55 ~Controller();
56>>>>>>> MERGE-SOURCE
5257
53 nux::BaseWindow* window() const;58 nux::BaseWindow* window() const;
5459
@@ -64,8 +69,13 @@
64 void ReFocusKeyInput();69 void ReFocusKeyInput();
65 bool IsVisible();70 bool IsVisible();
6671
72<<<<<<< TREE
67 nux::Geometry GetInputWindowGeometry();73 nux::Geometry GetInputWindowGeometry();
6874
75=======
76 void FocusInput();
77
78>>>>>>> MERGE-SOURCE
69protected:79protected:
70 // Introspectable80 // Introspectable
71 std::string GetName() const;81 std::string GetName() const;
@@ -76,11 +86,17 @@
76 void SetupWindow();86 void SetupWindow();
77 void SetupHudView();87 void SetupHudView();
78 void RegisterUBusInterests();88 void RegisterUBusInterests();
89<<<<<<< TREE
79 void SetIcon(std::string const& icon_name);90 void SetIcon(std::string const& icon_name);
8091
81 void FocusWindow();92 void FocusWindow();
8293
83 int GetIdealMonitor();94 int GetIdealMonitor();
95=======
96 void SetIcon(std::string const& icon_name);
97
98 int GetTargetMonitor();
99>>>>>>> MERGE-SOURCE
84 bool IsLockedToLauncher(int monitor);100 bool IsLockedToLauncher(int monitor);
85101
86 nux::Geometry GetIdealWindowGeometry();102 nux::Geometry GetIdealWindowGeometry();
@@ -110,11 +126,21 @@
110 bool visible_;126 bool visible_;
111 bool need_show_;127 bool need_show_;
112128
113 AbstractView* view_;129<<<<<<< TREE
130 AbstractView* view_;
131=======
132 guint timeline_id_;
133 float last_opacity_;
134 gint64 start_time_;
135
136 AbstractView* view_;
137 guint ensure_id_;
138>>>>>>> MERGE-SOURCE
114 std::string focused_app_icon_;139 std::string focused_app_icon_;
115 nux::Layout* layout_;140 nux::Layout* layout_;
116 uint monitor_index_;141 uint monitor_index_;
117 std::string last_search_;142 std::string last_search_;
143<<<<<<< TREE
118144
119 ViewCreator create_view_;145 ViewCreator create_view_;
120 WindowCreator create_window_;146 WindowCreator create_window_;
@@ -122,9 +148,21 @@
122 UBusManager ubus;148 UBusManager ubus;
123 glib::SignalManager sig_manager_;149 glib::SignalManager sig_manager_;
124 nux::animation::AnimateValue<double> timeline_animator_;150 nux::animation::AnimateValue<double> timeline_animator_;
151=======
152
153 std::function<AbstractView*(void)> view_function_;
154>>>>>>> MERGE-SOURCE
125};155};
126156
127} // namespace hud157<<<<<<< TREE
128} // namespace unity158} // namespace hud
129159} // namespace unity
130#endif // UNITYSHELL_HUD_CONTROLLER_H160
161#endif // UNITYSHELL_HUD_CONTROLLER_H
162=======
163} // namespace hud
164} // namespace unity
165
166#endif // UNITYSHELL_HUD_CONTROLLER_H
167
168>>>>>>> MERGE-SOURCE
131169
=== modified file 'hud/HudIcon.cpp'
--- hud/HudIcon.cpp 2013-02-13 17:34:32 +0000
+++ hud/HudIcon.cpp 2013-07-24 18:20:41 +0000
@@ -22,6 +22,14 @@
22#include "NuxCore/Logger.h"22#include "NuxCore/Logger.h"
23#include "config.h"23#include "config.h"
2424
25<<<<<<< TREE
26=======
27namespace
28{
29nux::logging::Logger logger("unity.hud.icon");
30}
31
32>>>>>>> MERGE-SOURCE
25namespace unity33namespace unity
26{34{
27namespace hud35namespace hud
@@ -31,7 +39,11 @@
31Icon::Icon()39Icon::Icon()
32 : IconTexture("", 0, true)40 : IconTexture("", 0, true)
33{41{
42<<<<<<< TREE
34 texture_updated.connect([this] (nux::ObjectPtr<nux::BaseTexture> const& texture)43 texture_updated.connect([this] (nux::ObjectPtr<nux::BaseTexture> const& texture)
44=======
45 texture_updated.connect([&] (nux::BaseTexture* texture)
46>>>>>>> MERGE-SOURCE
35 {47 {
36 icon_texture_source_ = new HudIconTextureSource(texture);48 icon_texture_source_ = new HudIconTextureSource(texture);
37 icon_texture_source_->ColorForIcon(_pixbuf_cached);49 icon_texture_source_->ColorForIcon(_pixbuf_cached);
3850
=== modified file 'hud/HudIcon.h'
=== modified file 'hud/HudView.cpp'
--- hud/HudView.cpp 2013-03-22 12:44:53 +0000
+++ hud/HudView.cpp 2013-07-24 18:20:41 +0000
@@ -26,6 +26,7 @@
26#include <UnityCore/GLibWrapper.h>26#include <UnityCore/GLibWrapper.h>
27#include <UnityCore/Variant.h>27#include <UnityCore/Variant.h>
28#include <Nux/HLayout.h>28#include <Nux/HLayout.h>
29<<<<<<< TREE
29#include <Nux/VLayout.h>30#include <Nux/VLayout.h>
3031
31#include "unity-shared/Introspectable.h"32#include "unity-shared/Introspectable.h"
@@ -33,6 +34,13 @@
33#include "unity-shared/UBusMessages.h"34#include "unity-shared/UBusMessages.h"
34#include "unity-shared/DashStyle.h"35#include "unity-shared/DashStyle.h"
35#include "unity-shared/WindowManager.h"36#include "unity-shared/WindowManager.h"
37=======
38#include <Nux/VLayout.h>
39
40#include "UBusMessages.h"
41#include "DashStyle.h"
42#include "WindowManager.h"
43>>>>>>> MERGE-SOURCE
3644
37namespace unity45namespace unity
38{46{
@@ -41,6 +49,12 @@
41DECLARE_LOGGER(logger, "unity.hud.view");49DECLARE_LOGGER(logger, "unity.hud.view");
42namespace50namespace
43{51{
52<<<<<<< TREE
53=======
54
55nux::logging::Logger logger("unity.hud.view");
56
57>>>>>>> MERGE-SOURCE
44const int grow_anim_length = 90 * 1000;58const int grow_anim_length = 90 * 1000;
45const int pause_before_grow_length = 32 * 1000;59const int pause_before_grow_length = 32 * 1000;
4660
@@ -58,10 +72,16 @@
58NUX_IMPLEMENT_OBJECT_TYPE(View);72NUX_IMPLEMENT_OBJECT_TYPE(View);
5973
60View::View()74View::View()
75<<<<<<< TREE
61 : AbstractView()76 : AbstractView()
62 , button_views_(nullptr)77 , button_views_(nullptr)
63 , visible_(false)78 , visible_(false)
64 , timeline_animating_(false)79 , timeline_animating_(false)
80=======
81 : AbstractView()
82 , button_views_(NULL)
83 , timeline_id_(0)
84>>>>>>> MERGE-SOURCE
65 , start_time_(0)85 , start_time_(0)
66 , last_known_height_(0)86 , last_known_height_(0)
67 , current_height_(0)87 , current_height_(0)
@@ -126,12 +146,22 @@
126146
127View::~View()147View::~View()
128{148{
149<<<<<<< TREE
129}150}
130151
131void View::SetMonitorOffset(int x, int y)152void View::SetMonitorOffset(int x, int y)
132{153{
133 renderer_.x_offset = x;154 renderer_.x_offset = x;
134 renderer_.y_offset = y;155 renderer_.y_offset = y;
156=======
157 for (auto button = buttons_.begin(); button != buttons_.end(); button++)
158 {
159 RemoveChild((*button).GetPointer());
160 }
161
162 if (timeline_id_)
163 g_source_remove(timeline_id_);
164>>>>>>> MERGE-SOURCE
135}165}
136166
137void View::ProcessGrowShrink()167void View::ProcessGrowShrink()
@@ -162,10 +192,19 @@
162 current_height_ = new_height;192 current_height_ = new_height;
163 }193 }
164194
165 for (auto button : buttons_)195<<<<<<< TREE
166 {196 for (auto button : buttons_)
167 button->SetSkipDraw((button->GetAbsoluteY() + button->GetBaseHeight()) > (GetAbsoluteY() + current_height_));197 {
168 }198 button->SetSkipDraw((button->GetAbsoluteY() + button->GetBaseHeight()) > (GetAbsoluteY() + current_height_));
199 }
200=======
201 for (auto button : buttons_)
202 {
203 button->SetSkipDraw((button->GetAbsoluteY() + button->GetBaseHeight()) > (GetAbsoluteY() + current_height_));
204 }
205
206 QueueDraw();
207>>>>>>> MERGE-SOURCE
169208
170 if (diff > grow_anim_length + pause_before_grow_length)209 if (diff > grow_anim_length + pause_before_grow_length)
171 {210 {
@@ -189,25 +228,76 @@
189228
190void View::ResetToDefault()229void View::ResetToDefault()
191{230{
231<<<<<<< TREE
192 SetQueries(Hud::Queries());232 SetQueries(Hud::Queries());
193 current_height_ = content_layout_->GetBaseHeight();;233 current_height_ = content_layout_->GetBaseHeight();;
194234
195 UpdateLayoutGeometry();235 UpdateLayoutGeometry();
196236
237=======
238 SetQueries(Hud::Queries());
239 current_height_ = content_layout_->GetBaseHeight();
240
241>>>>>>> MERGE-SOURCE
197 search_bar_->search_string = "";242 search_bar_->search_string = "";
198 search_bar_->search_hint = _("Type your command");243 search_bar_->search_hint = _("Type your command");
199}244}
200245
246<<<<<<< TREE
247=======
248void View::Relayout()
249{
250 nux::Geometry const& geo = GetGeometry();
251 content_geo_ = GetBestFitGeometry(geo);
252 LOG_DEBUG(logger) << "content_geo: " << content_geo_.width << "x" << content_geo_.height;
253
254 layout_->SetMinimumWidth(content_geo_.width);
255 layout_->SetMaximumSize(content_geo_.width, content_geo_.height);
256
257 QueueDraw();
258}
259
260long View::PostLayoutManagement(long LayoutResult)
261{
262 Relayout();
263 if (GetGeometry().height != last_known_height_)
264 {
265 // Start the timeline of drawing the dash resize
266 if (timeline_need_more_draw_)
267 {
268 // already started, just reset the last known height
269 last_known_height_ = current_height_;
270 }
271
272 timeline_need_more_draw_ = true;
273 start_time_ = g_get_monotonic_time();
274 QueueDraw();
275 }
276
277 return LayoutResult;
278}
279
280
281>>>>>>> MERGE-SOURCE
201nux::View* View::default_focus() const282nux::View* View::default_focus() const
202{283{
203 return search_bar_->text_entry();284 return search_bar_->text_entry();
204}285}
205286
206std::list<HudButton::Ptr> const& View::buttons() const287<<<<<<< TREE
207{288std::list<HudButton::Ptr> const& View::buttons() const
208 return buttons_;289{
209}290 return buttons_;
210291}
292
293=======
294std::list<HudButton::Ptr> const& View::buttons() const
295{
296 return buttons_;
297}
298
299
300>>>>>>> MERGE-SOURCE
211void View::SetQueries(Hud::Queries queries)301void View::SetQueries(Hud::Queries queries)
212{302{
213 // early exit, if the user is key navigating on the hud, we don't want to set new303 // early exit, if the user is key navigating on the hud, we don't want to set new
@@ -232,10 +322,16 @@
232322
233 HudButton::Ptr button(new HudButton());323 HudButton::Ptr button(new HudButton());
234 buttons_.push_front(button);324 buttons_.push_front(button);
325<<<<<<< TREE
235 button->SetInputEventSensitivity(false);326 button->SetInputEventSensitivity(false);
236 button->SetMinimumWidth(content_width);327 button->SetMinimumWidth(content_width);
237 button->SetMaximumWidth(content_width);328 button->SetMaximumWidth(content_width);
238 button->SetQuery(query);329 button->SetQuery(query);
330=======
331 button->SetMinimumWidth(content_width);
332 button->SetMaximumWidth(content_width);
333 button->SetQuery(query);
334>>>>>>> MERGE-SOURCE
239335
240 button_views_->AddView(button.GetPointer(), 0, nux::MINOR_POSITION_START);336 button_views_->AddView(button.GetPointer(), 0, nux::MINOR_POSITION_START);
241337
@@ -243,6 +339,7 @@
243 query_activated.emit(dynamic_cast<HudButton*>(view)->GetQuery());339 query_activated.emit(dynamic_cast<HudButton*>(view)->GetQuery());
244 });340 });
245341
342<<<<<<< TREE
246 button->mouse_move.connect([this](int x, int y, int dx, int dy, unsigned long mouse_button, unsigned long special_key) {343 button->mouse_move.connect([this](int x, int y, int dx, int dy, unsigned long mouse_button, unsigned long special_key) {
247 if (keyboard_stole_focus_)344 if (keyboard_stole_focus_)
248 {345 {
@@ -260,10 +357,17 @@
260 });357 });
261358
262 button->key_nav_focus_activate.connect([this](nux::Area* area) {359 button->key_nav_focus_activate.connect([this](nux::Area* area) {
360=======
361 button->key_nav_focus_activate.connect([&](nux::Area* area) {
362>>>>>>> MERGE-SOURCE
263 query_activated.emit(dynamic_cast<HudButton*>(area)->GetQuery());363 query_activated.emit(dynamic_cast<HudButton*>(area)->GetQuery());
264 });364 });
265365
366<<<<<<< TREE
266 button->key_nav_focus_change.connect([this](nux::Area* area, bool recieving, nux::KeyNavDirection direction){367 button->key_nav_focus_change.connect([this](nux::Area* area, bool recieving, nux::KeyNavDirection direction){
368=======
369 button->key_nav_focus_change.connect([&](nux::Area* area, bool recieving, KeyNavDirection direction){
370>>>>>>> MERGE-SOURCE
267 if (recieving)371 if (recieving)
268 query_selected.emit(dynamic_cast<HudButton*>(area)->GetQuery());372 query_selected.emit(dynamic_cast<HudButton*>(area)->GetQuery());
269 });373 });
@@ -276,7 +380,12 @@
276 buttons_.front()->is_rounded = true;380 buttons_.front()->is_rounded = true;
277 buttons_.back()->fake_focused = true;381 buttons_.back()->fake_focused = true;
278 selected_button_ = 1;382 selected_button_ = 1;
279 }383<<<<<<< TREE
384 }
385=======
386 }
387
388>>>>>>> MERGE-SOURCE
280389
281 QueueRelayout();390 QueueRelayout();
282 QueueDraw();391 QueueDraw();
@@ -422,10 +531,19 @@
422{531{
423 LOG_DEBUG(logger) << "got search change";532 LOG_DEBUG(logger) << "got search change";
424 search_changed.emit(search_string);533 search_changed.emit(search_string);
534<<<<<<< TREE
425535
426 for(auto button : buttons_)536 for(auto button : buttons_)
427 button->fake_focused = false;537 button->fake_focused = false;
428538
539=======
540
541 for (auto button : buttons_)
542 {
543 button->fake_focused = false;
544 }
545
546>>>>>>> MERGE-SOURCE
429 if (!buttons_.empty())547 if (!buttons_.empty())
430 buttons_.back()->fake_focused = true;548 buttons_.back()->fake_focused = true;
431}549}
@@ -497,6 +615,7 @@
497615
498 gfx_context.PopClippingRectangle();616 gfx_context.PopClippingRectangle();
499617
618<<<<<<< TREE
500 renderer_.DrawInnerCleanup(gfx_context, draw_content_geo, GetAbsoluteGeometry(), GetGeometry());619 renderer_.DrawInnerCleanup(gfx_context, draw_content_geo, GetAbsoluteGeometry(), GetGeometry());
501}620}
502621
@@ -523,6 +642,13 @@
523 for (auto it = buttons_.rbegin(); it != buttons_.rend(); ++it)642 for (auto it = buttons_.rbegin(); it != buttons_.rend(); ++it)
524 {643 {
525 if ((*it)->fake_focused)644 if ((*it)->fake_focused)
645=======
646 renderer_.DrawInnerCleanup(gfx_context, draw_content_geo, absolute_window_geometry_, window_geometry_);
647
648 if (timeline_need_more_draw_ && !timeline_id_)
649 {
650 timeline_id_ = g_idle_add([] (gpointer data) -> gboolean
651>>>>>>> MERGE-SOURCE
526 {652 {
527 query_selected.emit((*it)->GetQuery());653 query_selected.emit((*it)->GetQuery());
528 selected_button_ = button_index;654 selected_button_ = button_index;
@@ -559,7 +685,7 @@
559{685{
560 unsigned num_buttons = buttons_.size();686 unsigned num_buttons = buttons_.size();
561 variant::BuilderWrapper(builder)687 variant::BuilderWrapper(builder)
562 .add(GetGeometry())688 .add(content_geo_)
563 .add("selected_button", selected_button_)689 .add("selected_button", selected_button_)
564 .add("overlay_window_buttons_shown", overlay_window_buttons_->IsVisible())690 .add("overlay_window_buttons_shown", overlay_window_buttons_->IsVisible())
565 .add("num_buttons", num_buttons);691 .add("num_buttons", num_buttons);
@@ -596,11 +722,19 @@
596 return false;722 return false;
597}723}
598724
725<<<<<<< TREE
599void View::SearchFinished()726void View::SearchFinished()
600{727{
601 search_bar_->SetSearchFinished();728 search_bar_->SetSearchFinished();
602}729}
603730
731=======
732void View::SearchFinished()
733{
734 search_bar_->SearchFinished();
735}
736
737>>>>>>> MERGE-SOURCE
604void View::OnSearchbarActivated()738void View::OnSearchbarActivated()
605{739{
606 // The "Enter" key has been received and the text entry has the key focus.740 // The "Enter" key has been received and the text entry has the key focus.
@@ -655,6 +789,7 @@
655 direction = nux::KEY_NAV_ENTER;789 direction = nux::KEY_NAV_ENTER;
656 break;790 break;
657 default:791 default:
792<<<<<<< TREE
658 auto const& close_key = WindowManager::Default().close_window_key();793 auto const& close_key = WindowManager::Default().close_window_key();
659794
660 if (close_key.first == special_keys_state && close_key.second == x11_key_code)795 if (close_key.first == special_keys_state && close_key.second == x11_key_code)
@@ -663,6 +798,16 @@
663 return nullptr;798 return nullptr;
664 }799 }
665800
801=======
802 auto const& close_key = WindowManager::Default()->close_window_key();
803
804 if (close_key.first == special_keys_state && close_key.second == x11_key_code)
805 {
806 ubus.SendMessage(UBUS_HUD_CLOSE_REQUEST);
807 return nullptr;
808 }
809
810>>>>>>> MERGE-SOURCE
666 direction = nux::KEY_NAV_NONE;811 direction = nux::KEY_NAV_NONE;
667 break;812 break;
668 }813 }
669814
=== modified file 'hud/HudView.h'
--- hud/HudView.h 2013-03-19 17:52:08 +0000
+++ hud/HudView.h 2013-07-24 18:20:41 +0000
@@ -23,15 +23,26 @@
2323
24#include <Nux/Nux.h>24#include <Nux/Nux.h>
25#include <Nux/VLayout.h>25#include <Nux/VLayout.h>
26<<<<<<< TREE
26#include <UnityCore/GLibSource.h>27#include <UnityCore/GLibSource.h>
2728
29=======
30
31#include "HudAbstractView.h"
32>>>>>>> MERGE-SOURCE
28#include "HudIcon.h"33#include "HudIcon.h"
29#include "HudButton.h"34#include "HudButton.h"
35<<<<<<< TREE
30#include "HudAbstractView.h"36#include "HudAbstractView.h"
31#include "unity-shared/OverlayRenderer.h"37#include "unity-shared/OverlayRenderer.h"
32#include "unity-shared/OverlayWindowButtons.h"38#include "unity-shared/OverlayWindowButtons.h"
33#include "unity-shared/SearchBar.h"39#include "unity-shared/SearchBar.h"
34#include "unity-shared/UBusWrapper.h"40#include "unity-shared/UBusWrapper.h"
41=======
42#include "SearchBar.h"
43#include "OverlayRenderer.h"
44#include "UBusWrapper.h"
45>>>>>>> MERGE-SOURCE
3546
36namespace unity47namespace unity
37{48{
@@ -40,8 +51,13 @@
4051
41class View : public AbstractView52class View : public AbstractView
42{53{
54<<<<<<< TREE
43 NUX_DECLARE_OBJECT_TYPE(View, AbstractView);55 NUX_DECLARE_OBJECT_TYPE(View, AbstractView);
44public:56public:
57=======
58 NUX_DECLARE_OBJECT_TYPE(HudView, AbstractView);
59public:
60>>>>>>> MERGE-SOURCE
45 typedef nux::ObjectPtr<View> Ptr;61 typedef nux::ObjectPtr<View> Ptr;
4662
47 View();63 View();
@@ -60,7 +76,11 @@
60 void AboutToShow();76 void AboutToShow();
61 void AboutToHide();77 void AboutToHide();
6278
79<<<<<<< TREE
63 void SetMonitorOffset(int x, int y);80 void SetMonitorOffset(int x, int y);
81=======
82 void SetWindowGeometry(nux::Geometry const& absolute_geo, nux::Geometry const& geo);
83>>>>>>> MERGE-SOURCE
64 84
65 nux::Geometry GetContentGeometry();85 nux::Geometry GetContentGeometry();
6686
@@ -71,7 +91,12 @@
7191
72 void SetupViews();92 void SetupViews();
73 void OnSearchChanged(std::string const& search_string);93 void OnSearchChanged(std::string const& search_string);
7494<<<<<<< TREE
95
96=======
97 virtual long PostLayoutManagement(long LayoutResult);
98
99>>>>>>> MERGE-SOURCE
75private:100private:
76 void OnMouseButtonDown(int x, int y, unsigned long button, unsigned long key);101 void OnMouseButtonDown(int x, int y, unsigned long button, unsigned long key);
77 void OnKeyDown (unsigned long event_type, unsigned long event_keysym,102 void OnKeyDown (unsigned long event_type, unsigned long event_keysym,
@@ -127,8 +152,14 @@
127 nux::ObjectPtr<OverlayWindowButtons> overlay_window_buttons_;152 nux::ObjectPtr<OverlayWindowButtons> overlay_window_buttons_;
128};153};
129154
155} // namespace hud
156} // namespace unity
130157
158<<<<<<< TREE
131} // namespace hud159} // namespace hud
132} // namespace unity160} // namespace unity
161=======
162#endif // UNITYSHELL_HUD_VIEW_H
163>>>>>>> MERGE-SOURCE
133164
134#endif // UNITYSHELL_HUD_VIEW_H165#endif // UNITYSHELL_HUD_VIEW_H
135166
=== modified file 'launcher/AbstractLauncherIcon.h'
--- launcher/AbstractLauncherIcon.h 2013-07-01 21:20:51 +0000
+++ launcher/AbstractLauncherIcon.h 2013-07-24 18:20:41 +0000
@@ -136,9 +136,13 @@
136 virtual ~AbstractLauncherIcon() {}136 virtual ~AbstractLauncherIcon() {}
137137
138 nux::Property<std::string> tooltip_text;138 nux::Property<std::string> tooltip_text;
139<<<<<<< TREE
139 nux::Property<bool> tooltip_enabled;140 nux::Property<bool> tooltip_enabled;
140 nux::Property<Position> position;141 nux::Property<Position> position;
141 nux::Property<bool> removed;142 nux::Property<bool> removed;
143=======
144 nux::Property<bool> tooltip_enabled;
145>>>>>>> MERGE-SOURCE
142146
143 virtual void ShowTooltip() = 0;147 virtual void ShowTooltip() = 0;
144 virtual void HideTooltip() = 0;148 virtual void HideTooltip() = 0;
@@ -149,8 +153,12 @@
149153
150 virtual void SetSortPriority(int priority) = 0;154 virtual void SetSortPriority(int priority) = 0;
151155
156<<<<<<< TREE
152 virtual bool OpenQuicklist(bool select_first_item = false, int monitor = -1) = 0;157 virtual bool OpenQuicklist(bool select_first_item = false, int monitor = -1) = 0;
153 virtual void CloseQuicklist() = 0;158 virtual void CloseQuicklist() = 0;
159=======
160 virtual bool OpenQuicklist(bool select_first_item = false, int monitor = -1) = 0;
161>>>>>>> MERGE-SOURCE
154162
155 virtual void SetCenter(nux::Point3 const& center, int monitor, nux::Geometry const& parent_geo) = 0;163 virtual void SetCenter(nux::Point3 const& center, int monitor, nux::Geometry const& parent_geo) = 0;
156164
@@ -197,6 +205,7 @@
197205
198 virtual std::string RemoteUri() = 0;206 virtual std::string RemoteUri() = 0;
199207
208<<<<<<< TREE
200 virtual MenuItemsVector Menus() = 0;209 virtual MenuItemsVector Menus() = 0;
201210
202 virtual nux::DndAction QueryAcceptDrop(DndData const& dnd_data) = 0;211 virtual nux::DndAction QueryAcceptDrop(DndData const& dnd_data) = 0;
@@ -204,6 +213,15 @@
204 virtual bool ShouldHighlightOnDrag(DndData const& dnd_data) = 0;213 virtual bool ShouldHighlightOnDrag(DndData const& dnd_data) = 0;
205214
206 virtual void AcceptDrop(DndData const& dnd_data) = 0;215 virtual void AcceptDrop(DndData const& dnd_data) = 0;
216=======
217 virtual std::list<DbusmenuMenuitem*> Menus() = 0;
218
219 virtual nux::DndAction QueryAcceptDrop(DndData const& dnd_data) = 0;
220
221 virtual bool ShouldHighlightOnDrag(DndData const& dnd_data) = 0;
222
223 virtual void AcceptDrop(DndData const& dnd_data) = 0;
224>>>>>>> MERGE-SOURCE
207225
208 virtual void SendDndEnter() = 0;226 virtual void SendDndEnter() = 0;
209227
@@ -228,6 +246,7 @@
228246
229 virtual void UnStick() = 0;247 virtual void UnStick() = 0;
230248
249<<<<<<< TREE
231 static int DefaultPriority(IconType type)250 static int DefaultPriority(IconType type)
232 {251 {
233 return static_cast<int>(type) * 1000;252 return static_cast<int>(type) * 1000;
@@ -238,15 +257,27 @@
238 sigc::signal<void, int, int, unsigned long> mouse_down;257 sigc::signal<void, int, int, unsigned long> mouse_down;
239 sigc::signal<void, int, int, unsigned long> mouse_up;258 sigc::signal<void, int, int, unsigned long> mouse_up;
240 sigc::signal<void, int, int, unsigned long> mouse_click;259 sigc::signal<void, int, int, unsigned long> mouse_click;
260=======
261 sigc::signal<void, int, unsigned long, int> mouse_down;
262 sigc::signal<void, int, unsigned long, int> mouse_up;
263 sigc::signal<void, int, unsigned long, int> mouse_click;
264>>>>>>> MERGE-SOURCE
241 sigc::signal<void, int> mouse_enter;265 sigc::signal<void, int> mouse_enter;
The diff has been truncated for viewing.