Code review comment for lp:~garyvdm/bzr/extdiff-no-tmp-for-wt

Revision history for this message
John A Meinel (jameinel) wrote :

This seems better than what we currently have. So we should merge it as is.

What about deleted files, though?

Also, self._execute looks like it is using relative paths. Do you know if this still works if you are in a subdir of the working tree, etc?

review: Approve

« Back to merge proposal