Gary van der Merwe wrote:
> Gary van der Merwe has proposed merging lp:~garyvdm/bzr/PublicStackedParentsProvider into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> The patch make StackedParentsProvider a public api. It also adds a test to check that overlaping revisions from the different providers are handled correctly.
>
def __repr__(self):
- - return "_StackedParentsProvider(%r)" % self._parent_providers
+ return "StackedParentsProvider(%r)" % self._parent_providers
I realize we don't *need* to by our contract rules. But where we can, it
is a lot nicer to start giving deprecation warnings, rather than causing
existing code to just start breaking.
John
=:->
Review: approve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Gary van der Merwe wrote: rovider a public api. It also adds a test to check that overlaping revisions from the different providers are handled correctly. sProvider( %r)" % self._parent_ providers Provider( %r)" % self._parent_ providers
> Gary van der Merwe has proposed merging lp:~garyvdm/bzr/PublicStackedParentsProvider into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> The patch make StackedParentsP
>
def __repr__(self):
- - return "_StackedParent
+ return "StackedParents
^- we generally try to do:
return "%s(%r)" % (self._ _class_ _.__name_ _, self._parent_ providers)
so that you don't have to update these things, and so that child classes
automatically get named the right thing, too.
We might want to add:
@deprecated((0,1, 16) Provider( *args, **kwargs): rovider( *args, **kwargs)
def _StackedParents
return StackedParentsP
I realize we don't *need* to by our contract rules. But where we can, it
is a lot nicer to start giving deprecation warnings, rather than causing
existing code to just start breaking.
John
=:->
Review: approve
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org
eZFMACgkQJdeBCY SNAANTBQCcCGnzp FlAqI74sq5veUie oEOP pRDdA+Vh/ 2ZUDS35bRo8kiC
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAko
5BgAn2Jk/
=12aX
-----END PGP SIGNATURE-----