Code review comment for lp:~gary/zc.buildout/python-support-6-egg-control

Revision history for this message
Gary Poster (gary) wrote :

I made a small but important change in r557. The buildout script itself is now created with sitepackage_safe_scripts. This fixes a problem encountered in Launchpad.

I have not come up with an automated test for why this is necessary. We do have plenty of automated tests showing that it works as well as the ``scripts`` function for this purpose. I will spend a bit more time determining if I can come up with a test that shows why this change is necessary, but I'm hopeful it is acceptable as is.

I also determined that the do_build change I mentioned in the initial review request was unnecessary. I removed it.

« Back to merge proposal