Code review comment for lp:~gary/zc.buildout/python-support-5-initial-egg-control

This branch builds the infrastructure in easy_install that is needed for z3c.recipe.scripts to control what packages from site-packages can be used to fulfill setup.py dependencies. Hooking it up comes in the subsequent branch, ~gary/zc.buildout/python-support-6-egg-control .

This branch merged the remaining work from my previous zc.buildout effort. Much of this branch has therefore been reviewed before.

In the previous branch, I had a flag called "include-site-packages" (or "include_site_packages" depending on whether it is a config file or Python) for behavior related to what I had been calling "add-site-packages" (or "add_site_packages") in the more recent effort. I settled on "include-site-packages"/"include_site_packages" because it seemed to me to better describe the behavior of the flag, particularly in the case of the zc.buildout.easy_install.include_site_packages function.

My addition and use of _get_version_info is new to this branch. It seems OK to me, but I questioned it, and would welcome other ideas. You'll notice that previously buildout indiscriminately added the buildout and setuptools paths. I felt that being more careful was warranted, but maybe I'm wrong.

I noticed a couple of intermittent test failures during the development of this branch. I got them to go away with the use of get_installer_values and set_installer_values for careful teardowns of various test changes. This work is also new.

That's it. Thank you.

Gary