Code review comment for lp:~gary/zc.buildout/python-support-3-options

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Hi Gary,

Everything looks fine, the only snippet I don't understand is that one

> === modified file 'src/zc/buildout/tests.py'
> --- src/zc/buildout/tests.py 2010-02-17 21:27:15 +0000
> +++ src/zc/buildout/tests.py 2010-02-17 21:27:15 +0000
> @@ -2981,6 +2981,9 @@
> '-q develop -mxN -d /sample-buildout/develop-eggs'
> ),
> (re.compile(r'^[*]...'), '...'),
> + # for bug_92891_bootstrap_crashes_with_egg_recipe_in_buildout_section
> + (re.compile(r"Unused options for buildout: 'eggs' 'scripts'\."),
> + "Unused options for buildout: 'scripts' 'eggs'."),
> ]),
> ),
> zc.buildout.testselectingpython.test_suite(),
>

I assume it's good, but I'd like to have an explanation for it, since you
didn't mention it in your presentation.

Cheers

review: Approve

« Back to merge proposal